Skip to content

Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.

fix: launch review issues 0.7.0 (#6367)

Richard Shiue806fc75a8a40
diff --git a/frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_checkbox_column_header.dart b/frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_checkbox_column_header.dart
index 8953e0f324..8ac06bf2df 100644
--- a/frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_checkbox_column_header.dart
+++ b/frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_checkbox_column_header.dart
@@ -33,11 +33,14 @@ class CheckboxColumnHeader extends StatelessWidget {
),
const HSpace(6),
Expanded(
- child: FlowyTooltip(
- message: groupName,
- child: FlowyText.medium(
- groupName,
- overflow: TextOverflow.ellipsis,
+ child: Align(
+ alignment: AlignmentDirectional.centerStart,
+ child: FlowyTooltip(
+ message: groupName,
+ child: FlowyText.medium(
+ groupName,
+ overflow: TextOverflow.ellipsis,
+ ),
),
),
),
diff --git a/frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_column_header.dart b/frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_column_header.dart
index 4b105eb1ed..90eb1ccece 100644
--- a/frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_column_header.dart
+++ b/frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_column_header.dart
@@ -208,11 +208,14 @@ class _DefaultColumnHeaderContent extends StatelessWidget {
return Row(
children: [
Expanded(
- child: FlowyTooltip(
- message: groupName,
- child: FlowyText.medium(
- groupName,
- overflow: TextOverflow.ellipsis,
+ child: Align(
+ alignment: AlignmentDirectional.centerStart,
+ child: FlowyTooltip(
+ message: groupName,
+ child: FlowyText.medium(
+ groupName,
+ overflow: TextOverflow.ellipsis,
+ ),
),
),
),
diff --git a/frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_editable_column_header.dart b/frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_editable_column_header.dart
index aec7b7e1cc..bc07ddf3c1 100644
--- a/frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_editable_column_header.dart
+++ b/frontend/appflowy_flutter/lib/plugins/database/board/presentation/widgets/board_editable_column_header.dart
@@ -110,17 +110,17 @@ class _EditableColumnHeaderState extends State<EditableColumnHeader> {
Widget _buildTitle() {
final (backgroundColor, dotColor) = _generateGroupColor();
final groupName = _generateGroupName();
- return FlowyTooltip(
- message: groupName,
- child: MouseRegion(
- cursor: SystemMouseCursors.click,
- child: GestureDetector(
- behavior: HitTestBehavior.opaque,
- onTap: () {
- widget.isEditing.value = true;
- },
- child: Align(
- alignment: AlignmentDirectional.centerStart,
+ return MouseRegion(
+ cursor: SystemMouseCursors.click,
+ child: GestureDetector(
+ behavior: HitTestBehavior.opaque,
+ onTap: () {
+ widget.isEditing.value = true;
+ },
+ child: Align(
+ alignment: AlignmentDirectional.centerStart,
+ child: FlowyTooltip(
+ message: groupName,
child: Container(
height: 20,
padding: const EdgeInsets.symmetric(horizontal: 8, vertical: 1),
@@ -146,6 +146,7 @@ class _EditableColumnHeaderState extends State<EditableColumnHeader> {
child: FlowyText.medium(
groupName,
overflow: TextOverflow.ellipsis,
+ lineHeight: 1.0,
),
),
],
diff --git a/frontend/appflowy_flutter/lib/plugins/database/widgets/card/card.dart b/frontend/appflowy_flutter/lib/plugins/database/widgets/card/card.dart
index e87b2e2d18..7a063227e1 100644
--- a/frontend/appflowy_flutter/lib/plugins/database/widgets/card/card.dart
+++ b/frontend/appflowy_flutter/lib/plugins/database/widgets/card/card.dart
@@ -215,6 +215,7 @@ class _CardContent extends StatelessWidget {
@override
Widget build(BuildContext context) {
final child = Column(
+ mainAxisAlignment: MainAxisAlignment.center,
mainAxisSize: MainAxisSize.min,
children: [
CardCover(
diff --git a/frontend/appflowy_flutter/lib/plugins/database/widgets/card/container/card_container.dart b/frontend/appflowy_flutter/lib/plugins/database/widgets/card/container/card_container.dart
index 3584f2fce0..51e7ef4d80 100644
--- a/frontend/appflowy_flutter/lib/plugins/database/widgets/card/container/card_container.dart
+++ b/frontend/appflowy_flutter/lib/plugins/database/widgets/card/container/card_container.dart
@@ -28,7 +28,7 @@ class RowCardContainer extends StatelessWidget {
create: (_) => _CardContainerNotifier(),
child: Consumer<_CardContainerNotifier>(
builder: (context, notifier, _) {
- Widget container = Center(child: child);
+ Widget container = child;
bool shouldBuildAccessory = true;
if (buildAccessoryWhen != null) {
shouldBuildAccessory = buildAccessoryWhen!.call();
@@ -52,7 +52,7 @@ class RowCardContainer extends StatelessWidget {
}
},
child: ConstrainedBox(
- constraints: const BoxConstraints(minHeight: 30),
+ constraints: const BoxConstraints(minHeight: 42),
child: container,
),
);
diff --git a/frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/select_option_cell_editor.dart b/frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/select_option_cell_editor.dart
index 8f6f14f714..d3d6da72ec 100644
--- a/frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/select_option_cell_editor.dart
+++ b/frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/select_option_cell_editor.dart
@@ -454,17 +454,15 @@ class SelectOptionTagCell extends StatelessWidget {
onTap: onSelected,
child: MouseRegion(
cursor: SystemMouseCursors.click,
- child: Align(
+ child: Container(
alignment: AlignmentDirectional.centerStart,
- child: Padding(
- padding: const EdgeInsets.symmetric(horizontal: 6.0),
- child: SelectOptionTag(
- fontSize: 14,
- option: option,
- padding: const EdgeInsets.symmetric(
- horizontal: 8,
- vertical: 2,
- ),
+ padding: const EdgeInsets.symmetric(horizontal: 6.0),
+ child: SelectOptionTag(
+ fontSize: 14,
+ option: option,
+ padding: const EdgeInsets.symmetric(
+ horizontal: 8,
+ vertical: 2,
),
),
),
diff --git a/frontend/appflowy_flutter/lib/plugins/database/widgets/field/type_option_editor/media.dart b/frontend/appflowy_flutter/lib/plugins/database/widgets/field/type_option_editor/media.dart
index 532b19fe66..9ce62fd20a 100644
--- a/frontend/appflowy_flutter/lib/plugins/database/widgets/field/type_option_editor/media.dart
+++ b/frontend/appflowy_flutter/lib/plugins/database/widgets/field/type_option_editor/media.dart
@@ -27,35 +27,25 @@ class MediaTypeOptionEditorFactory implements TypeOptionEditorFactory {
final typeOption = _parseTypeOptionData(field.typeOptionData);
return Container(
- padding: const EdgeInsets.symmetric(horizontal: 6),
+ padding: const EdgeInsets.symmetric(horizontal: 8),
height: GridSize.popoverItemHeight,
alignment: Alignment.centerLeft,
- child: Column(
- mainAxisSize: MainAxisSize.min,
- children: [
- Row(
- children: [
- Expanded(
- child: FlowyButton(
- resetHoverOnRebuild: false,
- text: FlowyText.medium(
- LocaleKeys.grid_media_hideFileNames.tr(),
- lineHeight: 1.0,
- ),
- rightIcon: Toggle(
- value: typeOption.hideFileNames,
- onChanged: (value) {
- onTypeOptionUpdated(
- _toggleHideFiles(typeOption, !value).writeToBuffer(),
- );
- },
- padding: EdgeInsets.zero,
- ),
- ),
- ),
- ],
- ),
- ],
+ child: FlowyButton(
+ resetHoverOnRebuild: false,
+ text: FlowyText.medium(
+ LocaleKeys.grid_media_hideFileNames.tr(),
+ lineHeight: 1.0,
+ ),
+ onHover: (_) => popoverMutex.close(),
+ rightIcon: Toggle(
+ value: typeOption.hideFileNames,
+ onChanged: (value) {
+ onTypeOptionUpdated(
+ _toggleHideFiles(typeOption, !value).writeToBuffer(),
+ );
+ },
+ padding: EdgeInsets.zero,
+ ),
),
);
}