Skip to content

Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.

fix: hide field & add field tests (#1340)

Nathan.fooo87247ccd9d27
diff --git a/frontend/app_flowy/lib/plugins/grid/application/field/field_controller.dart b/frontend/app_flowy/lib/plugins/grid/application/field/field_controller.dart
index 73127ed6df..e8622629b7 100644
--- a/frontend/app_flowy/lib/plugins/grid/application/field/field_controller.dart
+++ b/frontend/app_flowy/lib/plugins/grid/application/field/field_controller.dart
@@ -16,7 +16,8 @@ class _GridFieldNotifier extends ChangeNotifier {
List<GridFieldContext> _fieldContexts = [];
set fieldContexts(List<GridFieldContext> fieldContexts) {
- _fieldContexts = fieldContexts;
+ _fieldContexts =
+ fieldContexts.where((element) => element.visibility).toList();
notifyListeners();
}
diff --git a/frontend/rust-lib/flowy-document/src/editor/document_serde.rs b/frontend/rust-lib/flowy-document/src/editor/document_serde.rs
index 099da01454..a3c9257a32 100644
--- a/frontend/rust-lib/flowy-document/src/editor/document_serde.rs
+++ b/frontend/rust-lib/flowy-document/src/editor/document_serde.rs
@@ -1,12 +1,10 @@
use crate::editor::document::Document;
-
use bytes::Bytes;
use flowy_error::FlowyResult;
use lib_ot::core::{
AttributeHashMap, Body, Changeset, Extension, NodeData, NodeId, NodeOperation, NodeTree, NodeTreeContext, Path,
Selection, Transaction,
};
-
use lib_ot::text_delta::DeltaTextOperations;
use serde::de::{self, MapAccess, Unexpected, Visitor};
use serde::ser::{SerializeMap, SerializeSeq};
diff --git a/frontend/rust-lib/flowy-grid/src/entities/field_entities.rs b/frontend/rust-lib/flowy-grid/src/entities/field_entities.rs
index 6675fcf034..3dd7a5723f 100644
--- a/frontend/rust-lib/flowy-grid/src/entities/field_entities.rs
+++ b/frontend/rust-lib/flowy-grid/src/entities/field_entities.rs
@@ -474,6 +474,7 @@ impl FieldChangesetParams {
|| self.frozen.is_some()
|| self.type_option_data.is_some()
|| self.frozen.is_some()
+ || self.visibility.is_some()
|| self.width.is_some()
}
}