Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.
Dart blogconfluence-alternativecontent-managementcontent-servicesdocumentationflutternote-takingnotion-alternativeproject-managementtask-managementteam-collaborationwiki
fix: potential crash while calling apply_insert if the path is empty
appflowy89a5ee4a8a93
diff --git a/shared-lib/lib-ot/src/core/document/document.rs b/shared-lib/lib-ot/src/core/document/document.rsindex 95508237a4..a20457a656 100644--- a/shared-lib/lib-ot/src/core/document/document.rs+++ b/shared-lib/lib-ot/src/core/document/document.rs@@ -121,14 +121,15 @@ impl DocumentTree {}fn apply_insert(&mut self, path: &Path, nodes: &[NodeSubTree]) -> Result<(), OTError> {+ debug_assert!(!path.is_empty());+ if path.is_empty() {+ return Err(OTErrorCode::PathIsEmpty.into());+ }-- let parent_path = &path.0[0..(path.0.len() - 1)];- let last_index = path.0[path.0.len() - 1];--+ let (parent_path, last_path) = path.split_at(path.0.len() - 1);+ let last_index = *last_path.first().unwrap();let parent_node = self- .node_at_path(&Path(parent_path.to_vec()))+ .node_at_path(parent_path).ok_or_else(|| ErrorBuilder::new(OTErrorCode::PathNotFound).build())?;self.insert_child_at_index(parent_node, last_index, nodes)diff --git a/shared-lib/lib-ot/src/core/document/position.rs b/shared-lib/lib-ot/src/core/document/position.rsindex 697bde8177..e45c2556d6 100644--- a/shared-lib/lib-ot/src/core/document/position.rs+++ b/shared-lib/lib-ot/src/core/document/position.rs@@ -39,6 +39,12 @@ impl From<&Vec<usize>> for Path {}}+impl From<&[usize]> for Path {+ fn from(values: &[usize]) -> Self {+ Path(values.to_vec())+ }+}+impl Path {// delta is default to be 1