Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.
Dart blogconfluence-alternativecontent-managementcontent-servicesdocumentationflutternote-takingnotion-alternativeproject-managementtask-managementteam-collaborationwiki
fix: edge case for text filters (#6387)
Richard Shiuec6dd5db6da4a
diff --git a/frontend/rust-lib/flowy-database2/src/services/field/type_options/text_type_option/text_filter.rs b/frontend/rust-lib/flowy-database2/src/services/field/type_options/text_type_option/text_filter.rsindex 8f090f5802..a378824929 100644--- a/frontend/rust-lib/flowy-database2/src/services/field/type_options/text_type_option/text_filter.rs+++ b/frontend/rust-lib/flowy-database2/src/services/field/type_options/text_type_option/text_filter.rs@@ -8,7 +8,18 @@ impl TextFilterPB {pub fn is_visible<T: AsRef<str>>(&self, cell_data: T) -> bool {let cell_data = cell_data.as_ref().to_lowercase();let content = &self.content.to_lowercase();+match self.condition {+ TextFilterConditionPB::TextIs+ | TextFilterConditionPB::TextIsNot+ | TextFilterConditionPB::TextContains+ | TextFilterConditionPB::TextDoesNotContain+ | TextFilterConditionPB::TextStartsWith+ | TextFilterConditionPB::TextEndsWith+ if content.is_empty() =>+ {+ true+ },TextFilterConditionPB::TextIs => &cell_data == content,TextFilterConditionPB::TextIsNot => &cell_data != content,TextFilterConditionPB::TextContains => cell_data.contains(content),@@ -53,10 +64,22 @@ mod tests {content: "appflowy".to_owned(),};- assert!(text_filter.is_visible("AppFlowy"));+ assert_eq!(text_filter.is_visible("AppFlowy"), true);assert_eq!(text_filter.is_visible("appflowy"), true);assert_eq!(text_filter.is_visible("Appflowy"), true);assert_eq!(text_filter.is_visible("AppFlowy.io"), false);+ assert_eq!(text_filter.is_visible(""), false);++ let text_filter = TextFilterPB {+ condition: TextFilterConditionPB::TextIs,+ content: "".to_owned(),+ };++ assert_eq!(text_filter.is_visible("AppFlowy"), true);+ assert_eq!(text_filter.is_visible("appflowy"), true);+ assert_eq!(text_filter.is_visible("Appflowy"), true);+ assert_eq!(text_filter.is_visible("AppFlowy.io"), true);+ assert_eq!(text_filter.is_visible(""), true);}#[test]fn text_filter_start_with_test() {@@ -68,6 +91,17 @@ mod tests {assert_eq!(text_filter.is_visible("AppFlowy.io"), true);assert_eq!(text_filter.is_visible(""), false);assert_eq!(text_filter.is_visible("https"), false);+ assert_eq!(text_filter.is_visible(""), false);++ let text_filter = TextFilterPB {+ condition: TextFilterConditionPB::TextStartsWith,+ content: "".to_owned(),+ };++ assert_eq!(text_filter.is_visible("AppFlowy.io"), true);+ assert_eq!(text_filter.is_visible(""), true);+ assert_eq!(text_filter.is_visible("https"), true);+ assert_eq!(text_filter.is_visible(""), true);}#[test]@@ -80,6 +114,17 @@ mod tests {assert_eq!(text_filter.is_visible("https://github.com/appflowy"), true);assert_eq!(text_filter.is_visible("App"), false);assert_eq!(text_filter.is_visible("appflowy.io"), false);+ assert_eq!(text_filter.is_visible(""), false);++ let text_filter = TextFilterPB {+ condition: TextFilterConditionPB::TextEndsWith,+ content: "".to_owned(),+ };++ assert_eq!(text_filter.is_visible("https://github.com/appflowy"), true);+ assert_eq!(text_filter.is_visible("App"), true);+ assert_eq!(text_filter.is_visible("appflowy.io"), true);+ assert_eq!(text_filter.is_visible(""), true);}#[test]fn text_filter_empty_test() {@@ -90,6 +135,14 @@ mod tests {assert_eq!(text_filter.is_visible(""), true);assert_eq!(text_filter.is_visible("App"), false);++ let text_filter = TextFilterPB {+ condition: TextFilterConditionPB::TextIsEmpty,+ content: "".to_owned(),+ };++ assert_eq!(text_filter.is_visible(""), true);+ assert_eq!(text_filter.is_visible("App"), false);}#[test]fn text_filter_contain_test() {@@ -103,5 +156,16 @@ mod tests {assert_eq!(text_filter.is_visible("App"), false);assert_eq!(text_filter.is_visible(""), false);assert_eq!(text_filter.is_visible("github"), false);++ let text_filter = TextFilterPB {+ condition: TextFilterConditionPB::TextContains,+ content: "".to_owned(),+ };++ assert_eq!(text_filter.is_visible("https://github.com/appflowy"), true);+ assert_eq!(text_filter.is_visible("AppFlowy"), true);+ assert_eq!(text_filter.is_visible("App"), true);+ assert_eq!(text_filter.is_visible(""), true);+ assert_eq!(text_filter.is_visible("github"), true);}}