Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.
Dart blogconfluence-alternativecontent-managementcontent-servicesdocumentationflutternote-takingnotion-alternativeproject-managementtask-managementteam-collaborationwiki
fix: open-row-as-full-page-related launch review issues (#5266)
Richard Shiued52042fa4fbb
diff --git a/frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_banner.dart b/frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_banner.dartindex 675b2e308a..358d26bece 100644--- a/frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_banner.dart+++ b/frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_banner.dart@@ -13,6 +13,7 @@ import 'package:appflowy/workspace/presentation/settings/widgets/emoji_picker/emimport 'package:appflowy_popover/appflowy_popover.dart';import 'package:easy_localization/easy_localization.dart';import 'package:flowy_infra_ui/flowy_infra_ui.dart';+import 'package:flowy_infra_ui/widget/flowy_tooltip.dart';import 'package:flutter/material.dart';import 'package:flutter_bloc/flutter_bloc.dart';@@ -262,11 +263,14 @@ class RowActionButton extends StatelessWidget {return AppFlowyPopover(direction: PopoverDirection.bottomWithLeftAligned,popupBuilder: (context) => RowActionList(rowController: rowController),- child: FlowyIconButton(- width: 20,- height: 20,- icon: const FlowySvg(FlowySvgs.details_horizontal_s),- iconColorOnHover: Theme.of(context).colorScheme.onSecondary,+ child: FlowyTooltip(+ message: LocaleKeys.grid_rowPage_moreRowActions.tr(),+ child: FlowyIconButton(+ width: 20,+ height: 20,+ icon: const FlowySvg(FlowySvgs.details_horizontal_s),+ iconColorOnHover: Theme.of(context).colorScheme.onSecondary,+ ),),);}diff --git a/frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_detail.dart b/frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_detail.dartindex 605d4e5235..430f817095 100644--- a/frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_detail.dart+++ b/frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_detail.dart@@ -1,4 +1,5 @@import 'package:appflowy/generated/flowy_svgs.g.dart';+import 'package:appflowy/generated/locale_keys.g.dart';import 'package:appflowy/plugins/database/application/database_controller.dart';import 'package:appflowy/plugins/database/application/row/row_controller.dart';import 'package:appflowy/plugins/database/domain/database_view_service.dart';@@ -9,7 +10,9 @@ import 'package:appflowy/startup/plugin/plugin.dart';import 'package:appflowy/startup/startup.dart';import 'package:appflowy/user/application/reminder/reminder_bloc.dart';import 'package:appflowy/workspace/application/tabs/tabs_bloc.dart';+import 'package:easy_localization/easy_localization.dart';import 'package:flowy_infra_ui/flowy_infra_ui.dart';+import 'package:flowy_infra_ui/widget/flowy_tooltip.dart';import 'package:flutter/material.dart';import 'package:flutter_bloc/flutter_bloc.dart';@@ -107,35 +110,39 @@ class _RowDetailPageState extends State<RowDetailPage> {List<Widget> _actions(BuildContext context) {return [if (widget.allowOpenAsFullPage) ...[- FlowyIconButton(- width: 20,- height: 20,- icon: const FlowySvg(FlowySvgs.full_view_s),- onPressed: () async {- Navigator.of(context).pop();- final databaseId = await DatabaseViewBackendService(- viewId: widget.databaseController.viewId,- )- .getDatabaseId()- .then((value) => value.fold((s) => s, (f) => null));- final documentId = widget.rowController.rowMeta.documentId;- if (databaseId != null) {- getIt<TabsBloc>().add(- TabsEvent.openPlugin(- plugin: DatabaseDocumentPlugin(- data: DatabaseDocumentContext(- view: widget.databaseController.view,- databaseId: databaseId,- rowId: widget.rowController.rowId,- documentId: documentId,+ FlowyTooltip(+ message: LocaleKeys.grid_rowPage_openAsFullPage.tr(),+ child: FlowyIconButton(+ width: 20,+ height: 20,+ icon: const FlowySvg(FlowySvgs.full_view_s),+ iconColorOnHover: Theme.of(context).colorScheme.onSurface,+ onPressed: () async {+ Navigator.of(context).pop();+ final databaseId = await DatabaseViewBackendService(+ viewId: widget.databaseController.viewId,+ )+ .getDatabaseId()+ .then((value) => value.fold((s) => s, (f) => null));+ final documentId = widget.rowController.rowMeta.documentId;+ if (databaseId != null) {+ getIt<TabsBloc>().add(+ TabsEvent.openPlugin(+ plugin: DatabaseDocumentPlugin(+ data: DatabaseDocumentContext(+ view: widget.databaseController.view,+ databaseId: databaseId,+ rowId: widget.rowController.rowId,+ documentId: documentId,+ ),+ pluginType: PluginType.databaseDocument,),- pluginType: PluginType.databaseDocument,+ setLatest: false,),- setLatest: false,- ),- );- }- },+ );+ }+ },+ ),),const HSpace(4),],diff --git a/frontend/resources/translations/en.json b/frontend/resources/translations/en.jsonindex dac7b45308..c09c4b5e9f 100644--- a/frontend/resources/translations/en.json+++ b/frontend/resources/translations/en.json@@ -759,7 +759,9 @@"one": "Hide {count} hidden field","many": "Hide {count} hidden fields","other": "Hide {count} hidden fields"- }+ },+ "openAsFullPage": "Open as full page",+ "moreRowActions": "More row actions"},"sort": {"ascending": "Ascending",