Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.
Dart blogconfluence-alternativecontent-managementcontent-servicesdocumentationflutternote-takingnotion-alternativeproject-managementtask-managementteam-collaborationwiki
fix: rename untitled view (#6789)
Mathias Mogensene4385adfa9aa
diff --git a/frontend/appflowy_flutter/integration_test/desktop/cloud/cloud_runner.dart b/frontend/appflowy_flutter/integration_test/desktop/cloud/cloud_runner.dartindex a0b6901f2d..0b35cffe51 100644--- a/frontend/appflowy_flutter/integration_test/desktop/cloud/cloud_runner.dart+++ b/frontend/appflowy_flutter/integration_test/desktop/cloud/cloud_runner.dart@@ -3,6 +3,8 @@ import 'data_migration/data_migration_test_runner.dart'import 'document/document_test_runner.dart' as document_test_runner;import 'set_env.dart' as preset_af_cloud_env_test;import 'sidebar/sidebar_move_page_test.dart' as sidebar_move_page_test;+import 'sidebar/sidebar_rename_untitled_test.dart'+ as sidebar_rename_untitled_test;import 'uncategorized/uncategorized_test_runner.dart'as uncategorized_test_runner;import 'workspace/workspace_test_runner.dart' as workspace_test_runner;@@ -23,4 +25,5 @@ Future<void> main() async {// sidebarsidebar_move_page_test.main();+ sidebar_rename_untitled_test.main();}diff --git a/frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_rename_untitled_test.dart b/frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_rename_untitled_test.dartnew file mode 100644index 0000000000..8226b68b26--- /dev/null+++ b/frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_rename_untitled_test.dart@@ -0,0 +1,55 @@+import 'package:appflowy/env/cloud_env.dart';+import 'package:appflowy/generated/locale_keys.g.dart';+import 'package:appflowy/workspace/application/view/view_ext.dart';+import 'package:appflowy/workspace/presentation/widgets/dialogs.dart';+import 'package:appflowy_backend/protobuf/flowy-folder/view.pbenum.dart';+import 'package:easy_localization/easy_localization.dart';+import 'package:flowy_infra_ui/style_widget/text_input.dart';+import 'package:flutter_test/flutter_test.dart';+import 'package:integration_test/integration_test.dart';++import '../../../shared/constants.dart';+import '../../../shared/util.dart';++void main() {+ IntegrationTestWidgetsFlutterBinding.ensureInitialized();++ testWidgets('Rename empty name view (untitled)', (tester) async {+ await tester.initializeAppFlowy(+ cloudType: AuthenticatorType.appflowyCloudSelfHost,+ );+ await tester.tapGoogleLoginInButton();+ await tester.expectToSeeHomePageWithGetStartedPage();++ await tester.createNewPageInSpace(+ spaceName: Constants.generalSpaceName,+ layout: ViewLayoutPB.Document,+ );++ // click the ... button and open rename dialog+ await tester.hoverOnPageName(+ ViewLayoutPB.Document.defaultName,+ onHover: () async {+ await tester.tapPageOptionButton();+ await tester.tapButtonWithName(+ LocaleKeys.disclosureAction_rename.tr(),+ );+ },+ );+ await tester.pumpAndSettle();++ expect(find.byType(NavigatorTextFieldDialog), findsOneWidget);++ final textField = tester.widget<FlowyFormTextInput>(+ find.descendant(+ of: find.byType(NavigatorTextFieldDialog),+ matching: find.byType(FlowyFormTextInput),+ ),+ );++ expect(+ textField.controller!.text,+ LocaleKeys.menuAppHeader_defaultNewPageName.tr(),+ );+ });+}diff --git a/frontend/appflowy_flutter/integration_test/shared/common_operations.dart b/frontend/appflowy_flutter/integration_test/shared/common_operations.dartindex 5aef1e34ec..0c4b05da4c 100644--- a/frontend/appflowy_flutter/integration_test/shared/common_operations.dart+++ b/frontend/appflowy_flutter/integration_test/shared/common_operations.dart@@ -449,11 +449,8 @@ extension CommonOperations on WidgetTester {// open the page after createdif (openAfterCreated) {- await openPage(- // if the name is null, use the default name- pageName ?? LocaleKeys.menuAppHeader_defaultNewPageName.tr(),- layout: layout,- );+ // if the name is null, use empty string+ await openPage(pageName ?? '', layout: layout);await pumpAndSettle();}}diff --git a/frontend/appflowy_flutter/lib/plugins/database/tab_bar/desktop/tab_bar_header.dart b/frontend/appflowy_flutter/lib/plugins/database/tab_bar/desktop/tab_bar_header.dartindex 116e47349c..e9408660ee 100644--- a/frontend/appflowy_flutter/lib/plugins/database/tab_bar/desktop/tab_bar_header.dart+++ b/frontend/appflowy_flutter/lib/plugins/database/tab_bar/desktop/tab_bar_header.dart@@ -219,9 +219,7 @@ class TabBarItemButton extends StatelessWidget {color: color,),text: FlowyText(- view.name.isEmpty- ? LocaleKeys.document_title_placeholder.tr()- : view.name,+ view.nameOrDefault,lineHeight: 1.0,textAlign: TextAlign.center,overflow: TextOverflow.ellipsis,@@ -236,7 +234,7 @@ class TabBarItemButton extends StatelessWidget {case TabBarViewAction.rename:NavigatorTextFieldDialog(title: LocaleKeys.menuAppHeader_renameDialog.tr(),- value: view.name,+ value: view.nameOrDefault,onConfirm: (newValue, _) {context.read<DatabaseTabBarBloc>().add(DatabaseTabBarEvent.renameView(view.id, newValue),diff --git a/frontend/appflowy_flutter/lib/plugins/database/tab_bar/mobile/mobile_tab_bar_header.dart b/frontend/appflowy_flutter/lib/plugins/database/tab_bar/mobile/mobile_tab_bar_header.dartindex 8796df14ef..3606ed82a3 100644--- a/frontend/appflowy_flutter/lib/plugins/database/tab_bar/mobile/mobile_tab_bar_header.dart+++ b/frontend/appflowy_flutter/lib/plugins/database/tab_bar/mobile/mobile_tab_bar_header.dart@@ -1,6 +1,4 @@-import 'package:appflowy/generated/locale_keys.g.dart';import 'package:appflowy/plugins/database/grid/presentation/layout/sizes.dart';-import 'package:easy_localization/easy_localization.dart';import 'package:flutter/material.dart';import 'package:appflowy/generated/flowy_svgs.g.dart';@@ -107,9 +105,7 @@ class _DatabaseViewSelectorButton extends StatelessWidget {const HSpace(6),Flexible(child: FlowyText.medium(- tabBar.view.name.isEmpty- ? LocaleKeys.document_title_placeholder.tr()- : tabBar.view.name,+ tabBar.view.nameOrDefault,fontSize: 14,overflow: TextOverflow.ellipsis,),diff --git a/frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/favorites/favorite_more_actions.dart b/frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/favorites/favorite_more_actions.dartindex 5f12ed1b04..09b8a44842 100644--- a/frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/favorites/favorite_more_actions.dart+++ b/frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/favorites/favorite_more_actions.dart@@ -5,6 +5,7 @@ import 'package:appflowy/workspace/application/favorite/favorite_bloc.dart';import 'package:appflowy/workspace/application/sidebar/folder/folder_bloc.dart';import 'package:appflowy/workspace/application/tabs/tabs_bloc.dart';import 'package:appflowy/workspace/application/view/view_bloc.dart';+import 'package:appflowy/workspace/application/view/view_ext.dart';import 'package:appflowy/workspace/application/view/view_service.dart';import 'package:appflowy/workspace/presentation/home/menu/view/view_action_type.dart';import 'package:appflowy/workspace/presentation/home/menu/view/view_more_action_button.dart';@@ -43,7 +44,7 @@ class FavoriteMoreActions extends StatelessWidget {NavigatorTextFieldDialog(title: LocaleKeys.disclosureAction_rename.tr(),autoSelectAllText: true,- value: view.name,+ value: view.nameOrDefault,maxLength: 256,onConfirm: (newValue, _) {// can not use bloc here because it has been disposed.diff --git a/frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart b/frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dartindex 6d6611b403..f54fc66c8d 100644--- a/frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart+++ b/frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart@@ -739,7 +739,7 @@ class _SingleInnerViewItemState extends State<SingleInnerViewItem> {NavigatorTextFieldDialog(title: LocaleKeys.disclosureAction_rename.tr(),autoSelectAllText: true,- value: widget.view.name,+ value: widget.view.nameOrDefault,maxLength: 256,onConfirm: (newValue, _) {context.read<ViewBloc>().add(ViewEvent.rename(newValue));