Skip to content

Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.

Fix/URL cell edit button hover (#1714)

Onyedika Israel Ukwuezee6b186cc4349
diff --git a/frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/cell_container.dart b/frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/cell_container.dart
index ade2c03465..a5e645c039 100644
--- a/frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/cell_container.dart
+++ b/frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/cell_container.dart
@@ -23,11 +23,8 @@ class CellContainer extends StatelessWidget {
@override
Widget build(BuildContext context) {
- return ChangeNotifierProxyProvider<RegionStateNotifier,
- _CellContainerNotifier>(
+ return ChangeNotifierProvider<_CellContainerNotifier>(
create: (_) => _CellContainerNotifier(child),
- update: (_, rowStateNotifier, cellStateNotifier) =>
- cellStateNotifier!..onEnter = rowStateNotifier.onEnter,
child: Selector<_CellContainerNotifier, bool>(
selector: (context, notifier) => notifier.isFocus,
builder: (privderContext, isFocus, _) {
@@ -90,8 +87,8 @@ class _GridCellEnterRegion extends StatelessWidget {
@override
Widget build(BuildContext context) {
- return Selector<_CellContainerNotifier, bool>(
- selector: (context, notifier) => notifier.onEnter,
+ return Selector2<RegionStateNotifier, _CellContainerNotifier, bool>(
+ selector: (context, regionNotifier, cellNotifier) => !cellNotifier.isFocus && (cellNotifier.onEnter),
builder: (context, onEnter, _) {
List<Widget> children = [child];
if (onEnter) {
diff --git a/frontend/app_flowy/packages/flowy_sdk/pubspec.lock b/frontend/app_flowy/packages/flowy_sdk/pubspec.lock
deleted file mode 100644
index 9066a7950c..0000000000
--- a/frontend/app_flowy/packages/flowy_sdk/pubspec.lock
+++ /dev/null
@@ -1,490 +0,0 @@
-# Generated by pub
-# See https://dart.dev/tools/pub/glossary#lockfile
-packages:
- _fe_analyzer_shared:
- dependency: transitive
- description:
- name: _fe_analyzer_shared
- url: "https://pub.dartlang.org"
- source: hosted
- version: "50.0.0"
- analyzer:
- dependency: transitive
- description:
- name: analyzer
- url: "https://pub.dartlang.org"
- source: hosted
- version: "5.2.0"
- args:
- dependency: transitive
- description:
- name: args
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.3.1"
- async:
- dependency: transitive
- description:
- name: async
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.9.0"
- boolean_selector:
- dependency: transitive
- description:
- name: boolean_selector
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.1.0"
- build:
- dependency: transitive
- description:
- name: build
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.3.1"
- build_config:
- dependency: transitive
- description:
- name: build_config
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.1.1"
- build_daemon:
- dependency: transitive
- description:
- name: build_daemon
- url: "https://pub.dartlang.org"
- source: hosted
- version: "3.1.0"
- build_resolvers:
- dependency: transitive
- description:
- name: build_resolvers
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.1.0"
- build_runner:
- dependency: "direct dev"
- description:
- name: build_runner
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.3.3"
- build_runner_core:
- dependency: transitive
- description:
- name: build_runner_core
- url: "https://pub.dartlang.org"
- source: hosted
- version: "7.2.7"
- built_collection:
- dependency: transitive
- description:
- name: built_collection
- url: "https://pub.dartlang.org"
- source: hosted
- version: "5.1.1"
- built_value:
- dependency: transitive
- description:
- name: built_value
- url: "https://pub.dartlang.org"
- source: hosted
- version: "8.4.2"
- characters:
- dependency: transitive
- description:
- name: characters
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.2.1"
- checked_yaml:
- dependency: transitive
- description:
- name: checked_yaml
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.0.2"
- clock:
- dependency: transitive
- description:
- name: clock
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.1.1"
- code_builder:
- dependency: transitive
- description:
- name: code_builder
- url: "https://pub.dartlang.org"
- source: hosted
- version: "4.4.0"
- collection:
- dependency: transitive
- description:
- name: collection
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.16.0"
- convert:
- dependency: transitive
- description:
- name: convert
- url: "https://pub.dartlang.org"
- source: hosted
- version: "3.1.1"
- crypto:
- dependency: transitive
- description:
- name: crypto
- url: "https://pub.dartlang.org"
- source: hosted
- version: "3.0.2"
- dart_style:
- dependency: transitive
- description:
- name: dart_style
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.2.4"
- dartz:
- dependency: "direct main"
- description:
- name: dartz
- url: "https://pub.dartlang.org"
- source: hosted
- version: "0.10.1"
- fake_async:
- dependency: transitive
- description:
- name: fake_async
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.3.1"
- ffi:
- dependency: "direct main"
- description:
- name: ffi
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.2.1"
- file:
- dependency: transitive
- description:
- name: file
- url: "https://pub.dartlang.org"
- source: hosted
- version: "6.1.4"
- fixnum:
- dependency: transitive
- description:
- name: fixnum
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.0.1"
- flutter:
- dependency: "direct main"
- description: flutter
- source: sdk
- version: "0.0.0"
- flutter_lints:
- dependency: "direct dev"
- description:
- name: flutter_lints
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.0.1"
- flutter_test:
- dependency: "direct dev"
- description: flutter
- source: sdk
- version: "0.0.0"
- freezed:
- dependency: "direct dev"
- description:
- name: freezed
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.3.2"
- freezed_annotation:
- dependency: "direct main"
- description:
- name: freezed_annotation
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.2.0"
- frontend_server_client:
- dependency: transitive
- description:
- name: frontend_server_client
- url: "https://pub.dartlang.org"
- source: hosted
- version: "3.2.0"
- glob:
- dependency: transitive
- description:
- name: glob
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.1.1"
- graphs:
- dependency: transitive
- description:
- name: graphs
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.2.0"
- http_multi_server:
- dependency: transitive
- description:
- name: http_multi_server
- url: "https://pub.dartlang.org"
- source: hosted
- version: "3.2.1"
- http_parser:
- dependency: transitive
- description:
- name: http_parser
- url: "https://pub.dartlang.org"
- source: hosted
- version: "4.0.2"
- io:
- dependency: transitive
- description:
- name: io
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.0.3"
- isolates:
- dependency: "direct main"
- description:
- name: isolates
- url: "https://pub.dartlang.org"
- source: hosted
- version: "3.0.3+8"
- js:
- dependency: transitive
- description:
- name: js
- url: "https://pub.dartlang.org"
- source: hosted
- version: "0.6.5"
- json_annotation:
- dependency: transitive
- description:
- name: json_annotation
- url: "https://pub.dartlang.org"
- source: hosted
- version: "4.7.0"
- lints:
- dependency: transitive
- description:
- name: lints
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.0.1"
- logger:
- dependency: "direct main"
- description:
- name: logger
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.1.0"
- logging:
- dependency: transitive
- description:
- name: logging
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.1.0"
- matcher:
- dependency: transitive
- description:
- name: matcher
- url: "https://pub.dartlang.org"
- source: hosted
- version: "0.12.12"
- material_color_utilities:
- dependency: transitive
- description:
- name: material_color_utilities
- url: "https://pub.dartlang.org"
- source: hosted
- version: "0.1.5"
- meta:
- dependency: transitive
- description:
- name: meta
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.8.0"
- mime:
- dependency: transitive
- description:
- name: mime
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.0.3"
- package_config:
- dependency: transitive
- description:
- name: package_config
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.1.0"
- path:
- dependency: transitive
- description:
- name: path
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.8.2"
- pool:
- dependency: transitive
- description:
- name: pool
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.5.1"
- protobuf:
- dependency: "direct main"
- description:
- name: protobuf
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.0.0"
- pub_semver:
- dependency: transitive
- description:
- name: pub_semver
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.1.3"
- pubspec_parse:
- dependency: transitive
- description:
- name: pubspec_parse
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.2.1"
- shelf:
- dependency: transitive
- description:
- name: shelf
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.4.0"
- shelf_web_socket:
- dependency: transitive
- description:
- name: shelf_web_socket
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.0.3"
- sky_engine:
- dependency: transitive
- description: flutter
- source: sdk
- version: "0.0.99"
- source_gen:
- dependency: transitive
- description:
- name: source_gen
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.2.6"
- source_span:
- dependency: transitive
- description:
- name: source_span
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.9.0"
- stack_trace:
- dependency: transitive
- description:
- name: stack_trace
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.10.0"
- stream_channel:
- dependency: transitive
- description:
- name: stream_channel
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.1.0"
- stream_transform:
- dependency: transitive
- description:
- name: stream_transform
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.1.0"
- string_scanner:
- dependency: transitive
- description:
- name: string_scanner
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.1.1"
- term_glyph:
- dependency: transitive
- description:
- name: term_glyph
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.2.1"
- test_api:
- dependency: transitive
- description:
- name: test_api
- url: "https://pub.dartlang.org"
- source: hosted
- version: "0.4.12"
- timing:
- dependency: transitive
- description:
- name: timing
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.0.0"
- typed_data:
- dependency: transitive
- description:
- name: typed_data
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.3.1"
- vector_math:
- dependency: transitive
- description:
- name: vector_math
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.1.2"
- watcher:
- dependency: transitive
- description:
- name: watcher
- url: "https://pub.dartlang.org"
- source: hosted
- version: "1.0.2"
- web_socket_channel:
- dependency: transitive
- description:
- name: web_socket_channel
- url: "https://pub.dartlang.org"
- source: hosted
- version: "2.2.0"
- yaml:
- dependency: transitive
- description:
- name: yaml
- url: "https://pub.dartlang.org"
- source: hosted
- version: "3.1.1"
-sdks:
- dart: ">=2.18.0 <3.0.0"
- flutter: ">=1.17.0"
diff --git a/frontend/app_flowy/pubspec.lock b/frontend/app_flowy/pubspec.lock
index 5709286955..8b779634f6 100644
--- a/frontend/app_flowy/pubspec.lock
+++ b/frontend/app_flowy/pubspec.lock
@@ -1431,4 +1431,4 @@ packages:
version: "3.1.1"
sdks:
dart: ">=2.18.0 <3.0.0"
- flutter: ">=3.3.0"
+ flutter: ">=3.3.0"
\ No newline at end of file