Skip to content

Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.

fix: flowy text field bugs

Richard Shiueeaa1cb5a6760
diff --git a/frontend/app_flowy/lib/plugins/grid/presentation/widgets/filter/choicechip/text.dart b/frontend/app_flowy/lib/plugins/grid/presentation/widgets/filter/choicechip/text.dart
index 1f591ef421..74fa8d71ec 100644
--- a/frontend/app_flowy/lib/plugins/grid/presentation/widgets/filter/choicechip/text.dart
+++ b/frontend/app_flowy/lib/plugins/grid/presentation/widgets/filter/choicechip/text.dart
@@ -152,7 +152,7 @@ class _TextFilterEditorState extends State<TextFilterEditor> {
return FlowyTextField(
text: state.filter.content,
hintText: LocaleKeys.grid_settings_typeAValue.tr(),
- autoFucous: false,
+ autoFocus: false,
onSubmitted: (text) {
context
.read<TextFilterEditorBloc>()
diff --git a/frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option_editor.dart b/frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option_editor.dart
index 7ccc49d7b6..9db22f8d88 100644
--- a/frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option_editor.dart
+++ b/frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option_editor.dart
@@ -123,8 +123,9 @@ class _OptionNameTextField extends StatelessWidget {
@override
Widget build(BuildContext context) {
return FlowyTextField(
- autoFucous: autoFocus,
+ autoFocus: autoFocus,
text: name,
+ maxLength: 30,
onSubmitted: (newName) {
if (name != newName) {
context
diff --git a/frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/text_field.dart b/frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/text_field.dart
index 085a719977..13d38e9e7c 100644
--- a/frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/text_field.dart
+++ b/frontend/app_flowy/packages/flowy_infra_ui/lib/style_widget/text_field.dart
@@ -1,6 +1,7 @@
import 'package:flowy_infra/size.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
+import 'package:textstyle_extensions/textstyle_extensions.dart';
class FlowyTextField extends StatefulWidget {
final String hintText;
@@ -8,17 +9,18 @@ class FlowyTextField extends StatefulWidget {
final void Function(String)? onChanged;
final void Function(String)? onSubmitted;
final void Function()? onCanceled;
- final bool autoFucous;
+ final bool autoFocus;
final int? maxLength;
final TextEditingController? controller;
final bool autoClearWhenDone;
+
const FlowyTextField({
this.hintText = "",
this.text = "",
this.onChanged,
this.onSubmitted,
this.onCanceled,
- this.autoFucous = true,
+ this.autoFocus = true,
this.maxLength,
this.controller,
this.autoClearWhenDone = false,
@@ -32,7 +34,6 @@ class FlowyTextField extends StatefulWidget {
class FlowyTextFieldState extends State<FlowyTextField> {
late FocusNode focusNode;
late TextEditingController controller;
- var textLength = 0;
@override
void initState() {
@@ -45,7 +46,7 @@ class FlowyTextFieldState extends State<FlowyTextField> {
controller = TextEditingController();
controller.text = widget.text;
}
- if (widget.autoFucous) {
+ if (widget.autoFocus) {
WidgetsBinding.instance.addPostFrameCallback((_) {
focusNode.requestFocus();
});
@@ -60,6 +61,7 @@ class FlowyTextFieldState extends State<FlowyTextField> {
focusNode: focusNode,
onChanged: (text) {
widget.onChanged?.call(text);
+ setState(() {});
},
onSubmitted: (text) {
widget.onSubmitted?.call(text);
@@ -71,9 +73,10 @@ class FlowyTextFieldState extends State<FlowyTextField> {
maxLines: 1,
maxLength: widget.maxLength,
maxLengthEnforcement: MaxLengthEnforcement.truncateAfterCompositionEnds,
- style: Theme.of(context).textTheme.bodySmall,
+ style: Theme.of(context).textTheme.bodyMedium,
decoration: InputDecoration(
- contentPadding: const EdgeInsets.all(10),
+ contentPadding:
+ const EdgeInsets.symmetric(horizontal: 10, vertical: 13),
enabledBorder: OutlineInputBorder(
borderSide: BorderSide(
color: Theme.of(context).colorScheme.primary,
@@ -83,6 +86,10 @@ class FlowyTextFieldState extends State<FlowyTextField> {
),
isDense: true,
hintText: widget.hintText,
+ hintStyle: Theme.of(context)
+ .textTheme
+ .bodySmall!
+ .textColor(Theme.of(context).hintColor),
suffixText: _suffixText(),
counterText: "",
focusedBorder: OutlineInputBorder(
@@ -115,7 +122,7 @@ class FlowyTextFieldState extends State<FlowyTextField> {
String? _suffixText() {
if (widget.maxLength != null) {
- return '${textLength.toString()}/${widget.maxLength.toString()}';
+ return ' ${controller.text.length}/${widget.maxLength}';
} else {
return null;
}