Skip to content

Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.

fix: multi scrollview warning

appflowyf6263f758f9e
diff --git a/frontend/app_flowy/lib/plugins/board/application/board_bloc.dart b/frontend/app_flowy/lib/plugins/board/application/board_bloc.dart
index 08b519c1a3..09f85df732 100644
--- a/frontend/app_flowy/lib/plugins/board/application/board_bloc.dart
+++ b/frontend/app_flowy/lib/plugins/board/application/board_bloc.dart
@@ -207,3 +207,8 @@ class BoardColumnItem extends AFColumnItem {
@override
String get id => row.id;
}
+
+class CreateCardItem extends AFColumnItem {
+ @override
+ String get id => '$CreateCardItem';
+}
diff --git a/frontend/app_flowy/lib/plugins/board/application/board_data_controller.dart b/frontend/app_flowy/lib/plugins/board/application/board_data_controller.dart
index 4a0333f30b..da4cc54132 100644
--- a/frontend/app_flowy/lib/plugins/board/application/board_data_controller.dart
+++ b/frontend/app_flowy/lib/plugins/board/application/board_data_controller.dart
@@ -89,8 +89,8 @@ class BoardDataController {
);
}
- void createRow() {
- _gridFFIService.createRow();
+ Future<Either<RowPB, FlowyError>> createRow() {
+ return _gridFFIService.createRow();
}
Future<void> dispose() async {
diff --git a/frontend/app_flowy/lib/plugins/board/board.dart b/frontend/app_flowy/lib/plugins/board/board.dart
index 36d181ae3e..2954a7cbf9 100644
--- a/frontend/app_flowy/lib/plugins/board/board.dart
+++ b/frontend/app_flowy/lib/plugins/board/board.dart
@@ -31,7 +31,7 @@ class BoardPluginBuilder implements PluginBuilder {
class BoardPluginConfig implements PluginConfig {
@override
- bool get creatable => true;
+ bool get creatable => false;
}
class BoardPlugin extends Plugin {
diff --git a/frontend/app_flowy/lib/plugins/board/presentation/board_page.dart b/frontend/app_flowy/lib/plugins/board/presentation/board_page.dart
index b373f65604..6dcfe8267c 100644
--- a/frontend/app_flowy/lib/plugins/board/presentation/board_page.dart
+++ b/frontend/app_flowy/lib/plugins/board/presentation/board_page.dart
@@ -54,10 +54,11 @@ class BoardContent extends StatelessWidget {
padding: const EdgeInsets.symmetric(vertical: 10, horizontal: 20),
child: AFBoard(
key: UniqueKey(),
+ scrollController: ScrollController(),
dataController: context.read<BoardBloc>().boardDataController,
headerBuilder: _buildHeader,
footBuilder: _buildFooter,
- cardBuilder: _buildCard,
+ cardBuilder: (_, data) => _buildCard(context, data),
columnConstraints: const BoxConstraints.tightFor(width: 240),
config: AFBoardConfig(
columnBackgroundColor: HexColor.fromHex('#F7F8FC'),
diff --git a/frontend/app_flowy/lib/plugins/board/presentation/card/card.dart b/frontend/app_flowy/lib/plugins/board/presentation/card/card.dart
index 2c17d5e3c8..dfb9ab42d7 100644
--- a/frontend/app_flowy/lib/plugins/board/presentation/card/card.dart
+++ b/frontend/app_flowy/lib/plugins/board/presentation/card/card.dart
@@ -3,6 +3,7 @@ import 'package:app_flowy/plugins/board/application/card/card_data_controller.da
import 'package:app_flowy/plugins/grid/application/cell/cell_service/cell_service.dart';
import 'package:flowy_infra/image.dart';
import 'package:flowy_infra/theme.dart';
+import 'package:flowy_sdk/log.dart';
import 'package:flutter/material.dart';
import 'package:flutter_bloc/flutter_bloc.dart';
import 'card_cell_builder.dart';
@@ -79,6 +80,6 @@ class _CardMoreOption extends StatelessWidget with CardAccessory {
@override
void onTap(BuildContext context) {
- print('show options');
+ Log.debug('show options');
}
}
diff --git a/frontend/app_flowy/packages/appflowy_board/lib/src/widgets/board.dart b/frontend/app_flowy/packages/appflowy_board/lib/src/widgets/board.dart
index 09f1590f3d..f4ce09fc2c 100644
--- a/frontend/app_flowy/packages/appflowy_board/lib/src/widgets/board.dart
+++ b/frontend/app_flowy/packages/appflowy_board/lib/src/widgets/board.dart
@@ -46,6 +46,8 @@ class AFBoard extends StatelessWidget {
///
final BoardPhantomController phantomController;
+ final ScrollController? scrollController;
+
final AFBoardConfig config;
AFBoard({
@@ -54,6 +56,7 @@ class AFBoard extends StatelessWidget {
this.background,
this.footBuilder,
this.headerBuilder,
+ this.scrollController,
this.columnConstraints = const BoxConstraints(maxWidth: 200),
this.config = const AFBoardConfig(),
Key? key,
@@ -69,6 +72,7 @@ class AFBoard extends StatelessWidget {
return BoardContent(
config: config,
dataController: dataController,
+ scrollController: scrollController,
background: background,
delegate: phantomController,
columnConstraints: columnConstraints,