Skip to content

AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.

fix(backend): Make Redis event bus gracefully handle connection failures (#11817)

Zamil Majdy033f58c07563
diff --git a/autogpt_platform/backend/backend/data/event_bus.py b/autogpt_platform/backend/backend/data/event_bus.py
index 48f9df87fa..d8a1c5b729 100644
--- a/autogpt_platform/backend/backend/data/event_bus.py
+++ b/autogpt_platform/backend/backend/data/event_bus.py
@@ -103,8 +103,18 @@ class RedisEventBus(BaseRedisEventBus[M], ABC):
return redis.get_redis()
def publish_event(self, event: M, channel_key: str):
- message, full_channel_name = self._serialize_message(event, channel_key)
- self.connection.publish(full_channel_name, message)
+ """
+ Publish an event to Redis. Gracefully handles connection failures
+ by logging the error instead of raising exceptions.
+ """
+ try:
+ message, full_channel_name = self._serialize_message(event, channel_key)
+ self.connection.publish(full_channel_name, message)
+ except Exception:
+ logger.exception(
+ f"Failed to publish event to Redis channel {channel_key}. "
+ "Event bus operation will continue without Redis connectivity."
+ )
def listen_events(self, channel_key: str) -> Generator[M, None, None]:
pubsub, full_channel_name = self._get_pubsub_channel(
@@ -128,9 +138,19 @@ class AsyncRedisEventBus(BaseRedisEventBus[M], ABC):
return await redis.get_redis_async()
async def publish_event(self, event: M, channel_key: str):
- message, full_channel_name = self._serialize_message(event, channel_key)
- connection = await self.connection
- await connection.publish(full_channel_name, message)
+ """
+ Publish an event to Redis. Gracefully handles connection failures
+ by logging the error instead of raising exceptions.
+ """
+ try:
+ message, full_channel_name = self._serialize_message(event, channel_key)
+ connection = await self.connection
+ await connection.publish(full_channel_name, message)
+ except Exception:
+ logger.exception(
+ f"Failed to publish event to Redis channel {channel_key}. "
+ "Event bus operation will continue without Redis connectivity."
+ )
async def listen_events(self, channel_key: str) -> AsyncGenerator[M, None]:
pubsub, full_channel_name = self._get_pubsub_channel(
diff --git a/autogpt_platform/backend/backend/data/event_bus_test.py b/autogpt_platform/backend/backend/data/event_bus_test.py
new file mode 100644
index 0000000000..93ecc0ba2a
--- /dev/null
+++ b/autogpt_platform/backend/backend/data/event_bus_test.py
@@ -0,0 +1,56 @@
+"""
+Tests for event_bus graceful degradation when Redis is unavailable.
+"""
+
+from unittest.mock import AsyncMock, patch
+
+import pytest
+from pydantic import BaseModel
+
+from backend.data.event_bus import AsyncRedisEventBus
+
+
+class TestEvent(BaseModel):
+ """Test event model."""
+
+ message: str
+
+
+class TestNotificationBus(AsyncRedisEventBus[TestEvent]):
+ """Test implementation of AsyncRedisEventBus."""
+
+ Model = TestEvent
+
+ @property
+ def event_bus_name(self) -> str:
+ return "test_event_bus"
+
+
+async def test_publish_event_handles_connection_failure_gracefully():
+ """Test that publish_event logs exception instead of raising when Redis is unavailable."""
+ bus = TestNotificationBus()
+ event = TestEvent(message="test message")
+
+ # Mock get_redis_async to raise connection error
+ with patch(
+ "backend.data.event_bus.redis.get_redis_async",
+ side_effect=ConnectionError("Authentication required."),
+ ):
+ # Should not raise exception
+ await bus.publish_event(event, "test_channel")
+
+
+async def test_publish_event_works_with_redis_available():
+ """Test that publish_event works normally when Redis is available."""
+ bus = TestNotificationBus()
+ event = TestEvent(message="test message")
+
+ # Mock successful Redis connection
+ mock_redis = AsyncMock()
+ mock_redis.publish = AsyncMock()
+
+ with patch("backend.data.event_bus.redis.get_redis_async", return_value=mock_redis):
+ await bus.publish_event(event, "test_channel")
+ mock_redis.publish.assert_called_once()
diff --git a/autogpt_platform/backend/backend/data/execution.py b/autogpt_platform/backend/backend/data/execution.py
index cee0b82137..3c1fd25c51 100644
--- a/autogpt_platform/backend/backend/data/execution.py
+++ b/autogpt_platform/backend/backend/data/execution.py
@@ -81,6 +81,8 @@ class ExecutionContext(BaseModel):
This includes information needed by blocks, sub-graphs, and execution management.
"""
+ model_config = {"extra": "ignore"}
+
human_in_the_loop_safe_mode: bool = True
sensitive_action_safe_mode: bool = False
user_timezone: str = "UTC"
diff --git a/autogpt_platform/backend/backend/data/graph.py b/autogpt_platform/backend/backend/data/graph.py
index d70bdbdc61..c1f38f81d5 100644
--- a/autogpt_platform/backend/backend/data/graph.py
+++ b/autogpt_platform/backend/backend/data/graph.py
@@ -64,6 +64,8 @@ logger = logging.getLogger(__name__)
class GraphSettings(BaseModel):
# Use Annotated with BeforeValidator to coerce None to default values.
# This handles cases where the database has null values for these fields.
+ model_config = {"extra": "ignore"}
+
human_in_the_loop_safe_mode: Annotated[
bool, BeforeValidator(lambda v: v if v is not None else True)
] = True
diff --git a/autogpt_platform/backend/scripts/generate_block_docs.py b/autogpt_platform/backend/scripts/generate_block_docs.py
index 1a49cc8805..4fa85e9bf0 100644
--- a/autogpt_platform/backend/scripts/generate_block_docs.py
+++ b/autogpt_platform/backend/scripts/generate_block_docs.py
@@ -366,12 +366,12 @@ def generate_block_markdown(
lines.append("")
# What it is (full description)
- lines.append(f"### What it is")
+ lines.append("### What it is")
lines.append(block.description or "No description available.")
lines.append("")
# How it works (manual section)
- lines.append(f"### How it works")
+ lines.append("### How it works")
how_it_works = manual_content.get(
"how_it_works", "_Add technical explanation here._"
)
@@ -383,7 +383,7 @@ def generate_block_markdown(
# Inputs table (auto-generated)
visible_inputs = [f for f in block.inputs if not f.hidden]
if visible_inputs:
- lines.append(f"### Inputs")
+ lines.append("### Inputs")
lines.append("")
lines.append("| Input | Description | Type | Required |")
lines.append("|-------|-------------|------|----------|")
@@ -400,7 +400,7 @@ def generate_block_markdown(
# Outputs table (auto-generated)
visible_outputs = [f for f in block.outputs if not f.hidden]
if visible_outputs:
- lines.append(f"### Outputs")
+ lines.append("### Outputs")
lines.append("")
lines.append("| Output | Description | Type |")
lines.append("|--------|-------------|------|")
@@ -414,7 +414,7 @@ def generate_block_markdown(
lines.append("")
# Possible use case (manual section)
- lines.append(f"### Possible use case")
+ lines.append("### Possible use case")
use_case = manual_content.get("use_case", "_Add practical use case examples here._")
lines.append("<!-- MANUAL: use_case -->")
lines.append(use_case)