AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.
fix(frontend): prevent tooltips from blocking mouse interaction (#14370)
Toran Bruce Richards2a43a7576f33
diff --git a/.github/workflows/platform-frontend-ci.yml b/.github/workflows/platform-frontend-ci.ymlindex 363a1602a4..218f2aa558 100644--- a/.github/workflows/platform-frontend-ci.yml+++ b/.github/workflows/platform-frontend-ci.yml@@ -41,6 +41,32 @@ defaults:working-directory: autogpt_platform/frontendjobs:+ tooltip-browser:+ runs-on: ubuntu-latest+ timeout-minutes: 10+ steps:+ - uses: actions/checkout@v6+ - uses: pnpm/action-setup@v4+ with:+ package_json_file: autogpt_platform/frontend/package.json+ - uses: actions/setup-node@v6+ with:+ node-version: "24.18.0"+ cache: "pnpm"+ cache-dependency-path: autogpt_platform/frontend/pnpm-lock.yaml+ - name: Install dependencies+ run: pnpm install --frozen-lockfile+ - name: Install Chromium+ run: pnpm exec playwright install --with-deps chromium+ - name: Test tooltip browser interactions+ run: pnpm test:tooltip+ - name: Upload browser failure artifacts+ if: failure()+ uses: actions/upload-artifact@v7+ with:+ name: tooltip-browser-failures+ path: autogpt_platform/frontend/test-results/+lint:runs-on: ubuntu-latestdiff --git a/autogpt_platform/frontend/package.json b/autogpt_platform/frontend/package.jsonindex 260f9d7352..d5360f4668 100644--- a/autogpt_platform/frontend/package.json+++ b/autogpt_platform/frontend/package.json@@ -19,6 +19,7 @@"test-ui": "NEXT_PUBLIC_PW_TEST=true next build --turbo && pnpm test:e2e:ui","test:unit": "vitest run --coverage","test:unit:watch": "vitest",+ "test:tooltip": "playwright test --config playwright.tooltip.config.ts","test:e2e": "NEXT_PUBLIC_PW_TEST=true next build --turbo && pnpm test:e2e:no-build","test:e2e:no-build": "playwright test","test:e2e:ui": "playwright test --ui",@@ -180,6 +181,7 @@"storybook": "9.1.5","tailwindcss": "3.4.17","typescript": "5.9.3",+ "vite": "7.3.1","vite-tsconfig-paths": "6.0.4","vitest": "4.1.0"},diff --git a/autogpt_platform/frontend/playwright.tooltip.config.ts b/autogpt_platform/frontend/playwright.tooltip.config.tsnew file mode 100644index 0000000000..a2e4778d99--- /dev/null+++ b/autogpt_platform/frontend/playwright.tooltip.config.ts@@ -0,0 +1,22 @@+import { defineConfig, devices } from "@playwright/test";++export default defineConfig({+ testDir: "./src/playwright",+ testMatch: "tooltip-interaction.browser.spec.ts",+ forbidOnly: true,+ retries: 0,+ timeout: 60000,+ workers: 1,+ reporter: "list",+ use: {+ ...devices["Desktop Chrome"],+ baseURL: "http://127.0.0.1:4175",+ trace: "retain-on-failure",+ },+ webServer: {+ command:+ "node node_modules/vite/bin/vite.js --config vite.tooltip.config.ts --host 127.0.0.1 --port 4175 --strictPort",+ url: "http://127.0.0.1:4175/src/playwright/tooltip/index.html",+ reuseExistingServer: false,+ },+});diff --git a/autogpt_platform/frontend/pnpm-lock.yaml b/autogpt_platform/frontend/pnpm-lock.yamlindex e8952f1b0f..60db4c8314 100644--- a/autogpt_platform/frontend/pnpm-lock.yaml+++ b/autogpt_platform/frontend/pnpm-lock.yaml@@ -440,6 +440,9 @@ importers:typescript:specifier: 5.9.3version: 5.9.3+ vite:+ specifier: 7.3.1vite-tsconfig-paths:specifier: 6.0.4version: 6.0.4([email protected])([email protected](@types/[email protected])([email protected])([email protected])([email protected]))diff --git a/autogpt_platform/frontend/src/components/atoms/Tooltip/BaseTooltip.tsx b/autogpt_platform/frontend/src/components/atoms/Tooltip/BaseTooltip.tsxindex 98dc7f67ab..f0a7d2c4e1 100644--- a/autogpt_platform/frontend/src/components/atoms/Tooltip/BaseTooltip.tsx+++ b/autogpt_platform/frontend/src/components/atoms/Tooltip/BaseTooltip.tsx@@ -5,7 +5,11 @@ import * as TooltipPrimitive from "@radix-ui/react-tooltip";import { cn } from "@/lib/utils";-const TooltipProvider = TooltipPrimitive.Provider;+function TooltipProvider(+ props: React.ComponentProps<typeof TooltipPrimitive.Provider>,+) {+ return <TooltipPrimitive.Provider disableHoverableContent {...props} />;+}interface Props {children: React.ReactNode;@@ -44,7 +48,13 @@ const TooltipContent = React.forwardRef<<TooltipPrimitive.Contentref={ref}sideOffset={sideOffset}- className={cn(tooltipContentClassName, className)}+ className={cn(+ tooltipContentClassName,+ // Important beats Radix's inline pointer style in dialogs; an explicit+ // override must likewise use !pointer-events-auto.+ "!pointer-events-none [[data-radix-popper-content-wrapper]:has(>&)]:pointer-events-none",+ className,+ )}{...props}/>));diff --git a/autogpt_platform/frontend/src/components/atoms/Tooltip/__tests__/BaseTooltip.test.tsx b/autogpt_platform/frontend/src/components/atoms/Tooltip/__tests__/BaseTooltip.test.tsxnew file mode 100644index 0000000000..6adb66ed75--- /dev/null+++ b/autogpt_platform/frontend/src/components/atoms/Tooltip/__tests__/BaseTooltip.test.tsx@@ -0,0 +1,78 @@+import { fireEvent, render, screen } from "@testing-library/react";+import { afterEach, describe, expect, it, vi } from "vitest";+import * as UITooltip from "@/components/ui/tooltip";+import * as AtomTooltip from "../BaseTooltip";++afterEach(() => {+ vi.restoreAllMocks();+});++describe.each([+ ["UI", UITooltip],+ ["atom", AtomTooltip],+] as const)("%s tooltip pointer transit", (_, components) => {+ it("shows the next button's tooltip when moving beneath the previous tooltip", async () => {+ const { TooltipProvider, Tooltip, TooltipTrigger, TooltipContent } =+ components;+ render(+ <TooltipProvider delayDuration={0}>+ <Tooltip delayDuration={0}>+ <TooltipTrigger asChild>+ <button>First action</button>+ </TooltipTrigger>+ <TooltipContent data-testid="first-tooltip">+ First description+ </TooltipContent>+ </Tooltip>+ <Tooltip delayDuration={0}>+ <TooltipTrigger asChild>+ <button>Second action</button>+ </TooltipTrigger>+ <TooltipContent>Second description</TooltipContent>+ </Tooltip>+ </TooltipProvider>,+ );+ const first = screen.getByRole("button", { name: "First action" });+ const second = screen.getByRole("button", { name: "Second action" });+ vi.spyOn(first, "getBoundingClientRect").mockReturnValue(+ new DOMRect(0, 0, 20, 20),+ );+ fireEvent.pointerMove(first, {+ pointerType: "mouse",+ clientX: 10,+ clientY: 10,+ });+ expect(+ await screen.findByRole("tooltip", { name: "First description" }),+ ).toBeDefined();+ const firstTooltip = screen.getByTestId("first-tooltip");+ vi.spyOn(firstTooltip, "getBoundingClientRect").mockReturnValue(+ new DOMRect(24, 0, 60, 20),+ );+ const position = {+ pointerType: "mouse",+ clientX: 21,+ clientY: 10,+ relatedTarget: second,+ };+ fireEvent.pointerOut(first, position);+ fireEvent.pointerLeave(first, position);+ fireEvent.pointerOver(second, {+ pointerType: "mouse",+ clientX: 35,+ clientY: 10,+ relatedTarget: first,+ });+ fireEvent.pointerMove(second, {+ pointerType: "mouse",+ clientX: 35,+ clientY: 10,+ });+ expect(+ await screen.findByRole("tooltip", { name: "Second description" }),+ ).toBeDefined();+ expect(+ screen.queryByRole("tooltip", { name: "First description" }),+ ).toBeNull();+ });+});diff --git a/autogpt_platform/frontend/src/components/molecules/InformationTooltip/InformationTooltip.test.tsx b/autogpt_platform/frontend/src/components/molecules/InformationTooltip/InformationTooltip.test.tsxnew file mode 100644index 0000000000..d5179ff831--- /dev/null+++ b/autogpt_platform/frontend/src/components/molecules/InformationTooltip/InformationTooltip.test.tsx@@ -0,0 +1,24 @@+import { render, screen } from "@testing-library/react";+import userEvent from "@testing-library/user-event";+import { expect, it, vi } from "vitest";+import { InformationTooltip } from "./InformationTooltip";++it("keeps Markdown links available when moving from the trigger to click them", async () => {+ const user = userEvent.setup();+ render(+ <InformationTooltip description="Visit our [documentation](https://docs.example.com) for more details." />,+ );++ await user.hover(screen.getByRole("button", { name: "More information" }));+ const [link] = await screen.findAllByRole("link", { name: "documentation" });+ await user.hover(link);++ expect(link.isConnected).toBe(true);+ expect(link.getAttribute("href")).toBe("https://docs.example.com");+ expect(link.getAttribute("target")).toBe("_blank");++ const onClick = vi.fn((event: Event) => event.preventDefault());+ link.addEventListener("click", onClick);+ await user.click(link);+ expect(onClick).toHaveBeenCalledOnce();+});diff --git a/autogpt_platform/frontend/src/components/molecules/InformationTooltip/InformationTooltip.tsx b/autogpt_platform/frontend/src/components/molecules/InformationTooltip/InformationTooltip.tsxindex ed01d71113..2994fcaae2 100644--- a/autogpt_platform/frontend/src/components/molecules/InformationTooltip/InformationTooltip.tsx+++ b/autogpt_platform/frontend/src/components/molecules/InformationTooltip/InformationTooltip.tsx@@ -16,7 +16,7 @@ export function InformationTooltip({ description, iconSize = 24 }: Props) {if (!description) return null;return (- <TooltipProvider delayDuration={400}>+ <TooltipProvider delayDuration={400} disableHoverableContent={false}><Tooltip><TooltipTrigger asChild>{/* A native button, because an SVG cannot take focus: bound straight@@ -39,7 +39,7 @@ export function InformationTooltip({ description, iconSize = 24 }: Props) {a: ({ node: _, ...props }) => (<atarget="_blank"- className="text-blue-400 underline"+ className="pointer-events-auto text-blue-400 underline"{...props}/>),diff --git a/autogpt_platform/frontend/src/components/ui/tooltip.tsx b/autogpt_platform/frontend/src/components/ui/tooltip.tsxindex 837912603a..c17c3ff2b7 100644--- a/autogpt_platform/frontend/src/components/ui/tooltip.tsx+++ b/autogpt_platform/frontend/src/components/ui/tooltip.tsx@@ -6,7 +6,11 @@ import * as TooltipPrimitive from "@radix-ui/react-tooltip";import { tooltipContentClassName } from "@/components/atoms/Tooltip/BaseTooltip";import { cn } from "@/lib/utils";-const TooltipProvider = TooltipPrimitive.Provider;+function TooltipProvider(+ props: React.ComponentProps<typeof TooltipPrimitive.Provider>,+) {+ return <TooltipPrimitive.Provider disableHoverableContent {...props} />;+}const Tooltip = TooltipPrimitive.Root;@@ -20,7 +24,13 @@ const TooltipContent = React.forwardRef<<TooltipPrimitive.Contentref={ref}sideOffset={sideOffset}- className={cn(tooltipContentClassName, className)}+ className={cn(+ tooltipContentClassName,+ // Important beats Radix's inline pointer style in dialogs; an explicit+ // override must likewise use !pointer-events-auto.+ "!pointer-events-none [[data-radix-popper-content-wrapper]:has(>&)]:pointer-events-none",+ className,+ )}{...props}/></TooltipPrimitive.Portal>diff --git a/autogpt_platform/frontend/src/playwright/tooltip-interaction.browser.spec.ts b/autogpt_platform/frontend/src/playwright/tooltip-interaction.browser.spec.tsnew file mode 100644index 0000000000..e02ab173f0--- /dev/null+++ b/autogpt_platform/frontend/src/playwright/tooltip-interaction.browser.spec.ts@@ -0,0 +1,99 @@+import { expect, test, type Locator, type Page } from "@playwright/test";++async function overlapControl(+ page: Page,+ target: Locator,+ wrapperEdge = false,+) {+ await page.locator("body").evaluate(async (body) => {+ await Promise.all(+ body+ .getAnimations({ subtree: true })+ .map((animation) => animation.finished.catch(() => undefined)),+ );+ });+ const box = await target.boundingBox();+ expect(box).not.toBeNull();+ const point = {+ x: box!.x + (wrapperEdge ? 2 : box!.width / 2),+ y: box!.y + box!.height / 2,+ };+ await page.getByTestId("underlying").evaluate((button, position) => {+ Object.assign(button.style, {+ position: "fixed",+ width: "20px",+ height: "20px",+ margin: "0",+ zIndex: "1",+ });+ const bounds = button.getBoundingClientRect();+ const style = getComputedStyle(button);+ button.style.left = `${parseFloat(style.left) + position.x - 10 - bounds.x}px`;+ button.style.top = `${parseFloat(style.top) + position.y - 10 - bounds.y}px`;+ }, point);+ return point;+}++for (const modal of [false, true]) {+ test.describe(modal ? "inside a modal" : "outside a modal", () => {+ for (const variant of ["ui", "atom", "atom-portal"]) {+ test(`${variant}: open tooltip content and wrapper pass clicks through`, async ({+ page,+ }) => {+ await page.goto(+ `/src/playwright/tooltip/index.html?variant=${variant}${modal ? "&modal" : ""}`,+ );+ const tooltip = page.locator(+ "[data-radix-popper-content-wrapper] > [data-state]",+ );+ await expect(tooltip).toBeVisible();+ const wrapper = tooltip.locator("..");+ await wrapper.evaluate((element) => {+ element.style.padding = "8px";+ });+ for (const [index, target] of [tooltip, wrapper].entries()) {+ const point = await overlapControl(page, target, index === 1);+ await expect(tooltip).toBeVisible();+ await page.mouse.click(point.x, point.y);+ await expect(+ page.getByRole("status", { name: "Underlying clicks" }),+ ).toHaveText(String(index + 1));+ }+ });+ }++ test("Markdown link stays reachable and receives a native click", async ({+ page,+ context,+ }) => {+ await context.route("**/tooltip-link-destination", (route) =>+ route.fulfill({ body: "Setup guide" }),+ );+ await page.goto(+ `/src/playwright/tooltip/index.html?variant=information${modal ? "&modal" : ""}`,+ );+ await page.getByRole("button", { name: "More information" }).hover();+ const tooltip = page.locator(+ "[data-radix-popper-content-wrapper] > [data-state]",+ );+ await expect(tooltip).toBeVisible();+ const link = tooltip+ .locator(":scope > p")+ .getByRole("link", { name: "setup guide" });+ const point = await overlapControl(page, link);+ await page.mouse.move(point.x, point.y, { steps: 12 });+ await expect(tooltip).toBeVisible();+ const popupPromise = page.waitForEvent("popup", { timeout: 5000 });+ await page.mouse.click(point.x, point.y);+ const popup = await popupPromise;+ try {+ await expect(popup).toHaveURL(/\/tooltip-link-destination$/);+ await expect(+ page.getByRole("status", { name: "Underlying clicks" }),+ ).toHaveText("0");+ } finally {+ await popup.close();+ }+ });+ });+}diff --git a/autogpt_platform/frontend/src/playwright/tooltip/index.html b/autogpt_platform/frontend/src/playwright/tooltip/index.htmlnew file mode 100644index 0000000000..5dea59a96d--- /dev/null+++ b/autogpt_platform/frontend/src/playwright/tooltip/index.html@@ -0,0 +1,11 @@+<!doctype html>+<html lang="en">+ <head>+ <meta charset="UTF-8" />+ <title>Tooltip interaction fixture</title>+ </head>+ <body>+ <div id="root"></div>+ <script type="module" src="./main.tsx"></script>+ </body>+</html>diff --git a/autogpt_platform/frontend/src/playwright/tooltip/main.tsx b/autogpt_platform/frontend/src/playwright/tooltip/main.tsxnew file mode 100644index 0000000000..60f06d7824--- /dev/null+++ b/autogpt_platform/frontend/src/playwright/tooltip/main.tsx@@ -0,0 +1,60 @@+import { useState } from "react";+import { createRoot } from "react-dom/client";+import * as Atom from "@/components/atoms/Tooltip/BaseTooltip";+import * as UI from "@/components/ui/tooltip";+import { InformationTooltip } from "@/components/molecules/InformationTooltip/InformationTooltip";+import { Dialog } from "@/components/molecules/Dialog/Dialog";+import "@/app/globals.css";++function TooltipFixture({ variant }: { variant: string }) {+ if (variant === "information") {+ return (+ <InformationTooltip description="Read the [setup guide](/tooltip-link-destination) before continuing." />+ );+ }+ const { TooltipProvider, Tooltip, TooltipTrigger, TooltipContent } =+ variant === "ui" ? UI : Atom;+ const content = (+ <TooltipContent side="bottom">An overlapping tooltip</TooltipContent>+ );+ return (+ <TooltipProvider>+ <Tooltip open>+ <TooltipTrigger>Tooltip trigger</TooltipTrigger>+ {variant === "atom-portal" ? (+ <Atom.TooltipPortal>{content}</Atom.TooltipPortal>+ ) : (+ content+ )}+ </Tooltip>+ </TooltipProvider>+ );+}++function Fixture() {+ const params = new URLSearchParams(location.search);+ const [clicks, setClicks] = useState(0);+ const content = (+ <div className="relative mx-auto mt-40 w-96">+ <button+ type="button"+ data-testid="underlying"+ className="fixed left-0 top-0"+ onClick={() => setClicks(clicks + 1)}+ >+ Underlying control+ </button>+ <output aria-label="Underlying clicks">{clicks}</output>+ <TooltipFixture variant={params.get("variant") ?? "ui"} />+ </div>+ );+ return params.has("modal") ? (+ <Dialog title="Tooltip regression" forceOpen>+ <Dialog.Content>{content}</Dialog.Content>+ </Dialog>+ ) : (+ content+ );+}++createRoot(document.getElementById("root")!).render(<Fixture />);diff --git a/autogpt_platform/frontend/vite.tooltip.config.ts b/autogpt_platform/frontend/vite.tooltip.config.tsnew file mode 100644index 0000000000..d617889652--- /dev/null+++ b/autogpt_platform/frontend/vite.tooltip.config.ts@@ -0,0 +1,9 @@+import { defineConfig } from "vite";+import react from "@vitejs/plugin-react";+import path from "node:path";++export default defineConfig({+ plugins: [react()],+ define: { "process.env": {} },+ resolve: { alias: { "@": path.resolve(__dirname, "src") } },+});