AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.
fix(frontend): keep the memory inspector's dream result after the job ends (#15575)
Nicholas Tindle36f07b8a79ac
diff --git a/autogpt_platform/frontend/src/app/(platform)/admin/memory/__tests__/memory-visualizer.test.tsx b/autogpt_platform/frontend/src/app/(platform)/admin/memory/__tests__/memory-visualizer.test.tsxindex 21831c74e3..c63e0ca8a3 100644--- a/autogpt_platform/frontend/src/app/(platform)/admin/memory/__tests__/memory-visualizer.test.tsx+++ b/autogpt_platform/frontend/src/app/(platform)/admin/memory/__tests__/memory-visualizer.test.tsx@@ -9,6 +9,7 @@ import {render,screen,waitFor,+ within,} from "@/tests/integrations/test-utils";import { server } from "@/mocks/mock-server";import {@@ -170,6 +171,43 @@ function MemoryVisualizerWithRefetch() {);}+function completedDreamStatus(jobID: string) {+ return {+ ...getGetV2GetDreamPassStatusResponseMock200(),+ job_id: jobID,+ kind: "dream_pass",+ state: "complete",+ current_phase: null,+ error: null,+ result: {+ pass_id: "pass-5792380f",+ operations: {+ writes: [],+ proposals: [],+ demotions: [],+ entity_invalidations: [],+ },+ usage: {+ phases: [],+ total_input_tokens: 9264,+ total_output_tokens: 3344,+ total_cache_read_tokens: 0,+ total_cache_creation_tokens: 0,+ total_cost_usd: 0.064624,+ discount_applied: 0,+ },+ },+ };+}++async function waitForIdleDreamButton() {+ await waitFor(() =>+ expect(+ screen.getByRole("button", { name: /dream pass/i }).textContent?.trim(),+ ).toBe("Dream pass"),+ );+}+const PERSISTENT_GRAPH_PARAMS = {include_episodes: true,include_communities: true,@@ -811,6 +849,81 @@ describe("MemoryVisualizer — 202 + polling contract", () => {});});+ test("a finished dream pass keeps its result panel until the admin dismisses it", async () => {+ setupBaseHandlers();+ server.use(+ getPostV2TriggerDreamPassMockHandler202({+ ...getPostV2TriggerDreamPassResponseMock202(),+ job_id: "job-dream-done",+ state: "queued",+ }),+ http.get("*/api/admin/memory/:userId/dream/:jobId", () =>+ HttpResponse.json(completedDreamStatus("job-dream-done")),+ ),+ );+ render(<MemoryVisualizer />);++ await userEvent.click(+ await screen.findByRole("button", { name: /dream pass/i }),+ );+ await screen.findByTestId("dream-result-panel");++ // The job has ended and stopped polling; its record stays on screen.+ await waitForIdleDreamButton();+ const panel = screen.getByTestId("dream-result-panel");+ expect(within(panel).getByText("Operations")).toBeDefined();+ expect(within(panel).getByText("Token usage")).toBeDefined();+ expect(within(panel).getByText(/pass-5792380f/)).toBeDefined();++ await userEvent.click(+ within(panel).getByRole("button", { name: "Dismiss" }),+ );+ expect(screen.queryByTestId("dream-result-panel")).toBeNull();+ });++ test("starting another dream pass clears the previous result", async () => {+ setupBaseHandlers();+ let triggers = 0;+ server.use(+ http.post("*/api/admin/memory/:userId/dream", () => {+ triggers += 1;+ return HttpResponse.json(+ {+ ...getPostV2TriggerDreamPassResponseMock202(),+ job_id: `job-dream-${triggers}`,+ state: "queued",+ },+ { status: 202 },+ );+ }),+ http.get("*/api/admin/memory/:userId/dream/:jobId", ({ params }) =>+ HttpResponse.json(+ params.jobId === "job-dream-1"+ ? completedDreamStatus("job-dream-1")+ : {+ ...getGetV2GetDreamPassStatusResponseMock200(),+ job_id: String(params.jobId),+ kind: "dream_pass",+ state: "running",+ current_phase: "consolidate",+ },+ ),+ ),+ );+ render(<MemoryVisualizer />);++ await userEvent.click(+ await screen.findByRole("button", { name: /dream pass/i }),+ );+ await screen.findByTestId("dream-result-panel");+ await waitForIdleDreamButton();+ expect(screen.getByTestId("dream-result-panel")).toBeDefined();++ await userEvent.click(screen.getByRole("button", { name: /dream pass/i }));+ await screen.findByRole("button", { name: /consolidate…/i });+ expect(screen.queryByTestId("dream-result-panel")).toBeNull();+ });+test("job completion refreshes every Otto cache without invalidating expert memory", async () => {setupBaseHandlers([makeExpert("expert-ada", "Ada")]);const graphRequests = new Map<string, number>();diff --git a/autogpt_platform/frontend/src/app/(platform)/admin/memory/components/MemoryVisualizer.tsx b/autogpt_platform/frontend/src/app/(platform)/admin/memory/components/MemoryVisualizer.tsxindex 09f005b50f..6d36841db1 100644--- a/autogpt_platform/frontend/src/app/(platform)/admin/memory/components/MemoryVisualizer.tsx+++ b/autogpt_platform/frontend/src/app/(platform)/admin/memory/components/MemoryVisualizer.tsx@@ -1,6 +1,8 @@"use client";import { useEffect, useMemo, useState } from "react";+import { Button } from "@/components/atoms/Button/Button";+import { Text } from "@/components/atoms/Text/Text";import { GraphCanvas } from "./GraphCanvas";import { useMemoryVisualizer } from "./useMemoryVisualizer";import { DreamOperationsView } from "./DreamOperationsView/DreamOperationsView";@@ -8,6 +10,7 @@ import { DreamUsageSummary } from "./DreamUsageSummary/DreamUsageSummary";import { MemoryScopeSelector } from "./MemoryScopeSelector";import { MaintenanceControls } from "./MaintenanceControls";import { useMemoryScope } from "./useMemoryScope";+import type { DreamResult } from "./helpers";import type { AnyJobStatus } from "./memoryJobStatus";export function MemoryVisualizer() {@@ -50,6 +53,8 @@ function MemoryScopeView({ expertID }: MemoryScopeViewProps) {ratification,triggerRatification,triggerNightly,+ dreamResult,+ dismissDreamResult,force,setForce,includeEpisodes,@@ -148,7 +153,9 @@ function MemoryScopeView({ expertID }: MemoryScopeViewProps) {edgeCount={edges.length}/>- {readOnly ? null : <DreamResultPanel status={dreamStatusData} />}+ {readOnly || !dreamResult ? null : (+ <DreamResultPanel result={dreamResult} onDismiss={dismissDreamResult} />+ )}<div className="grid grid-cols-12 gap-4"><Sidebar@@ -484,31 +491,26 @@ interface DetailPanelProps {}interface DreamResultPanelProps {- status: AnyJobStatus | undefined;+ result: DreamResult;+ onDismiss: () => void;}-function DreamResultPanel({ status }: DreamResultPanelProps) {- if (!status || status.state !== "complete") return null;- const result = status.result as Record<string, unknown> | null | undefined;- if (!result) return null;- // Only the sync_baseline path puts operations + usage on the result.- // For the anthropic_batch path the callback writes a smaller summary- // (pass_id + stats), so we just hide the panel — the graph itself- // refreshes via cache invalidation when the job completes.- const operations = result.operations as- | Parameters<typeof DreamOperationsView>[0]["operations"]- | undefined;- const usage = result.usage as- | Parameters<typeof DreamUsageSummary>[0]["usage"]- | undefined;- if (!operations || !usage) return null;+function DreamResultPanel({ result, onDismiss }: DreamResultPanelProps) {return (- <div- className="grid grid-cols-1 gap-3 lg:grid-cols-2"- data-testid="dream-result-panel"- >- <DreamOperationsView operations={operations} />- <DreamUsageSummary usage={usage} />+ <div className="space-y-2" data-testid="dream-result-panel">+ <div className="flex items-center justify-between gap-2">+ <Text variant="small-medium" as="span" className="text-gray-700">+ Last dream pass{" "}+ <span className="font-mono text-gray-500">{result.passID}</span>+ </Text>+ <Button variant="ghost" size="small" onClick={onDismiss}>+ Dismiss+ </Button>+ </div>+ <div className="grid grid-cols-1 gap-3 lg:grid-cols-2">+ <DreamOperationsView operations={result.operations} />+ <DreamUsageSummary usage={result.usage} />+ </div></div>);}diff --git a/autogpt_platform/frontend/src/app/(platform)/admin/memory/components/helpers.ts b/autogpt_platform/frontend/src/app/(platform)/admin/memory/components/helpers.tsnew file mode 100644index 0000000000..f25064170c--- /dev/null+++ b/autogpt_platform/frontend/src/app/(platform)/admin/memory/components/helpers.ts@@ -0,0 +1,26 @@+import type { DreamOperationsSnapshot } from "@/app/api/__generated__/models/dreamOperationsSnapshot";+import type { DreamPassResult } from "@/app/api/__generated__/models/dreamPassResult";+import type { DreamPassUsage } from "@/app/api/__generated__/models/dreamPassUsage";+import type { AnyJobStatus } from "./memoryJobStatus";++export interface DreamResult {+ passID: string;+ operations: DreamOperationsSnapshot;+ usage: DreamPassUsage;+}++// Only the sync_baseline path puts operations + usage on the result. The+// anthropic_batch callback writes a smaller summary (pass_id + stats), so+// there is no record to show for it.+export function getDreamResult(+ status: AnyJobStatus | undefined,+): DreamResult | undefined {+ if (status?.state !== "complete") return undefined;+ const result = status.result as DreamPassResult | null | undefined;+ if (!result?.operations || !result.usage) return undefined;+ return {+ passID: result.pass_id,+ operations: result.operations,+ usage: result.usage,+ };+}diff --git a/autogpt_platform/frontend/src/app/(platform)/admin/memory/components/useMemoryVisualizer.ts b/autogpt_platform/frontend/src/app/(platform)/admin/memory/components/useMemoryVisualizer.tsindex 00fece3530..c6167c7c2e 100644--- a/autogpt_platform/frontend/src/app/(platform)/admin/memory/components/useMemoryVisualizer.ts+++ b/autogpt_platform/frontend/src/app/(platform)/admin/memory/components/useMemoryVisualizer.ts@@ -26,6 +26,7 @@ import type { JobTriggerResponse } from "@/app/api/__generated__/models/jobTriggimport type { MemoryOverview } from "@/app/api/__generated__/models/memoryOverview";import type { RatificationResult } from "@/app/api/__generated__/models/ratificationResult";import { useToast } from "@/components/molecules/Toast/use-toast";+import { getDreamResult } from "./helpers";import type { AnyJobStatus } from "./memoryJobStatus";// The state enum is identical across all three concrete envelopes@@ -80,6 +81,11 @@ export function useMemoryVisualizer(expertID?: string) {const [activeRebuildJobId, setActiveRebuildJobId] = useState<string | undefined>();+ // The last dream job that finished. Ending a job clears its active id,+ // which also drops its polled status, so the result panel reads this.+ const [finishedDreamStatus, setFinishedDreamStatus] = useState<+ AnyJobStatus | undefined+ >();const baseGraphParams = {include_episodes: includeEpisodes,@@ -133,6 +139,7 @@ export function useMemoryVisualizer(expertID?: string) {mutation: {onSuccess: (res) => {const result = res.data as JobTriggerResponse;+ setFinishedDreamStatus(undefined);setActiveDreamJobId(result.job_id);},onError: (error: Error) => {@@ -241,7 +248,8 @@ export function useMemoryVisualizer(expertID?: string) {activeDreamJobId,dreamStatus.data?.data as AnyJobStatus | undefined,dreamStatus.error,- () => {+ (finishedStatus) => {+ setFinishedDreamStatus(finishedStatus);setActiveDreamJobId(undefined);queryClient.invalidateQueries({queryKey: getGetV2GetDreamPassStatusQueryKey(USER_ID, activeDreamJobId),@@ -309,6 +317,10 @@ export function useMemoryVisualizer(expertID?: string) {nightly.mutate({ userId: USER_ID });}+ function dismissDreamResult() {+ setFinishedDreamStatus(undefined);+ }+// --- Scope tripwire -----------------------------------------------------//// Overview + graph responses echo the expert_id they were computed@@ -376,6 +388,8 @@ export function useMemoryVisualizer(expertID?: string) {triggerDream,triggerRatification,triggerNightly,+ dreamResult: getDreamResult(finishedDreamStatus),+ dismissDreamResult,force,setForce,includeEpisodes,@@ -405,7 +419,7 @@ function useTerminalEffect(activeJobId: string | undefined,status: AnyJobStatus | undefined,queryError: unknown,- onTerminal: () => void,+ onTerminal: (finishedStatus?: AnyJobStatus) => void,toast: ReturnType<typeof useToast>["toast"],) {// Reacts to ``status`` transitioning to a terminal state OR the@@ -447,7 +461,7 @@ function useTerminalEffect(variant: "destructive",});}- onTerminal();+ onTerminal(status);// ``onTerminal`` and ``toast`` are intentionally omitted — they// change on every render and would cause infinite re-runs. The// job_id + state transition + query error are what we want to