Skip to content

AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.

feat: Avoid Rest & DatabaseManager service serving traffic when the db is not yet connected (#10522)

Zamil Majdy4283798dc28c
diff --git a/autogpt_platform/backend/backend/data/db.py b/autogpt_platform/backend/backend/data/db.py
index 4d30fa0f7b..c3adc39b5a 100644
--- a/autogpt_platform/backend/backend/data/db.py
+++ b/autogpt_platform/backend/backend/data/db.py
@@ -50,6 +50,10 @@ prisma = Prisma(
logger = logging.getLogger(__name__)
+def is_connected():
+ return prisma.is_connected()
+
+
@conn_retry("Prisma", "Acquiring connection")
async def connect():
if prisma.is_connected():
diff --git a/autogpt_platform/backend/backend/executor/database.py b/autogpt_platform/backend/backend/executor/database.py
index 499dd014ee..f36a94f82d 100644
--- a/autogpt_platform/backend/backend/executor/database.py
+++ b/autogpt_platform/backend/backend/executor/database.py
@@ -77,6 +77,11 @@ class DatabaseManager(AppService):
logger.info(f"[{self.service_name}] ⏳ Disconnecting Database...")
self.run_and_wait(db.disconnect())
+ def health_check(self) -> str:
+ if not db.is_connected():
+ raise RuntimeError("Database is not connected")
+ return super().health_check()
+
@classmethod
def get_port(cls) -> int:
return config.database_api_port
diff --git a/autogpt_platform/backend/backend/executor/scheduler.py b/autogpt_platform/backend/backend/executor/scheduler.py
index e20d37e88b..2e5ccd00f4 100644
--- a/autogpt_platform/backend/backend/executor/scheduler.py
+++ b/autogpt_platform/backend/backend/executor/scheduler.py
@@ -167,6 +167,11 @@ class Scheduler(AppService):
def db_pool_size(cls) -> int:
return config.scheduler_db_pool_size
+ def health_check(self) -> str:
+ if not self.scheduler.running:
+ raise RuntimeError("Scheduler is not running")
+ return super().health_check()
+
def run_service(self):
load_dotenv()
db_schema, db_url = _extract_schema_from_url(os.getenv("DIRECT_URL"))
diff --git a/autogpt_platform/backend/backend/server/rest_api.py b/autogpt_platform/backend/backend/server/rest_api.py
index 2b376ca269..7f8df55031 100644
--- a/autogpt_platform/backend/backend/server/rest_api.py
+++ b/autogpt_platform/backend/backend/server/rest_api.py
@@ -224,6 +224,8 @@ app.mount("/external-api", external_app)
@app.get(path="/health", tags=["health"], dependencies=[])
async def health():
+ if not backend.data.db.is_connected():
+ raise RuntimeError("Database is not connected")
return {"status": "healthy"}
diff --git a/autogpt_platform/backend/backend/util/process.py b/autogpt_platform/backend/backend/util/process.py
index 1b145c8ba7..3f61e999f5 100644
--- a/autogpt_platform/backend/backend/util/process.py
+++ b/autogpt_platform/backend/backend/util/process.py
@@ -61,12 +61,6 @@ class AppProcess(ABC):
"""
pass
- def health_check(self) -> str:
- """
- A method to check the health of the process.
- """
- return "OK"
-
def execute_run_command(self, silent):
signal.signal(signal.SIGTERM, self._self_terminate)
signal.signal(signal.SIGINT, self._self_terminate)
@@ -123,7 +117,6 @@ class AppProcess(ABC):
**proc_args,
)
self.process.start()
- self.health_check()
logger.info(f"[{self.service_name}] started with PID {self.process.pid}")
return self.process.pid or 0
diff --git a/autogpt_platform/backend/backend/util/service.py b/autogpt_platform/backend/backend/util/service.py
index c725a76700..800dece8cd 100644
--- a/autogpt_platform/backend/backend/util/service.py
+++ b/autogpt_platform/backend/backend/util/service.py
@@ -211,6 +211,12 @@ class AppService(BaseAppService, ABC):
)
self.shared_event_loop.run_until_complete(server.serve())
+ def health_check(self) -> str:
+ """
+ A method to check the health of the process.
+ """
+ return "OK"
+
def run(self):
sentry_init()
super().run()