Skip to content

AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.

fix(frontend/builder): remove benign console.warn from credential input (#13166)

seer-by-sentry[bot]47b1562e8de8
diff --git a/autogpt_platform/frontend/src/components/renderers/InputRenderer/custom/CredentialField/__tests__/helpers.test.ts b/autogpt_platform/frontend/src/components/renderers/InputRenderer/custom/CredentialField/__tests__/helpers.test.ts
index d08434e61e..bcc5ac09cb 100644
--- a/autogpt_platform/frontend/src/components/renderers/InputRenderer/custom/CredentialField/__tests__/helpers.test.ts
+++ b/autogpt_platform/frontend/src/components/renderers/InputRenderer/custom/CredentialField/__tests__/helpers.test.ts
@@ -1,4 +1,4 @@
-import { describe, expect, it } from "vitest";
+import { afterEach, describe, expect, it, vi } from "vitest";
import type { BlockIOCredentialsSubSchema } from "@/lib/autogpt-server-api";
import {
credentialNotApplicable,
@@ -25,6 +25,38 @@ const githubSchema: BlockIOCredentialsSubSchema = {
};
describe("getCredentialProviderFromSchema", () => {
+ afterEach(() => vi.restoreAllMocks());
+
+ const multiProviderSchema: BlockIOCredentialsSubSchema = {
+ type: "object",
+ properties: {},
+ credentials_provider: ["openai", "anthropic"],
+ credentials_types: ["api_key"],
+ discriminator: "model",
+ discriminator_mapping: { "model-a": "openai", "model-b": "anthropic" },
+ };
+
+ it("quietly hides credentials before a provider choice is made", () => {
+ const warn = vi.spyOn(console, "warn").mockImplementation(() => {});
+ expect(getCredentialProviderFromSchema({}, multiProviderSchema)).toBeNull();
+ expect(warn).not.toHaveBeenCalled();
+ expect(
+ getCredentialProviderFromSchema(
+ { model: "model-a" },
+ multiProviderSchema,
+ ),
+ ).toBe("openai");
+ });
+
+ it("still rejects a multi-provider schema with no discriminator", () => {
+ expect(() =>
+ getCredentialProviderFromSchema(
+ {},
+ { ...multiProviderSchema, discriminator: undefined },
+ ),
+ ).toThrow("Multi-provider credential input requires discriminator");
+ });
+
it("hides the input when a single-provider field's value is unmapped", () => {
// Regression: this returned "codex" regardless of the transport, so
// selecting `platform` still rendered — and auto-selected — a ChatGPT
diff --git a/autogpt_platform/frontend/src/components/renderers/InputRenderer/custom/CredentialField/helpers.ts b/autogpt_platform/frontend/src/components/renderers/InputRenderer/custom/CredentialField/helpers.ts
index 08a3ca0dc0..f59526b88e 100644
--- a/autogpt_platform/frontend/src/components/renderers/InputRenderer/custom/CredentialField/helpers.ts
+++ b/autogpt_platform/frontend/src/components/renderers/InputRenderer/custom/CredentialField/helpers.ts
@@ -179,10 +179,6 @@ export const getCredentialProviderFromSchema = (
);
}
if (!discriminatedProvider) {
- console.warn(
- `Missing discriminator value from '${discriminator}': ` +
- "hiding credentials input until it is set.",
- );
return null;
}
return discriminatedProvider;