Skip to content

AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.

fix(frontend): prevent Select.Item crash on empty-string enum values (#12495)

AutoGPT62d3c4d8fd59
diff --git a/autogpt_platform/frontend/src/components/renderers/InputRenderer/base/standard/widgets/SelectInput/SelectWidget.tsx b/autogpt_platform/frontend/src/components/renderers/InputRenderer/base/standard/widgets/SelectInput/SelectWidget.tsx
index c4f04c0ed2..3029eb98f4 100644
--- a/autogpt_platform/frontend/src/components/renderers/InputRenderer/base/standard/widgets/SelectInput/SelectWidget.tsx
+++ b/autogpt_platform/frontend/src/components/renderers/InputRenderer/base/standard/widgets/SelectInput/SelectWidget.tsx
@@ -1,8 +1,8 @@
import {
enumOptionsIndexForValue,
enumOptionsValueForIndex,
- WidgetProps,
} from "@rjsf/utils";
+import type { EnumOptionsType, WidgetProps } from "@rjsf/utils";
import {
InputType,
mapJsonSchemaTypeToInputType,
@@ -28,7 +28,18 @@ export function SelectWidget(props: WidgetProps) {
id,
formContext,
} = props;
- const enumOptions = options.enumOptions || [];
+ const rawEnumOptions: EnumOptionsType[] = options.enumOptions || [];
+ const enumOptions = rawEnumOptions.filter((option) => option.value !== "");
+ const droppedEmptyOptionCount = rawEnumOptions.length - enumOptions.length;
+ if (process.env.NODE_ENV === "development" && droppedEmptyOptionCount > 0) {
+ console.warn(
+ "[SelectWidget] Dropped enum option(s) with empty-string value. Radix Select.Item disallows empty values.",
+ {
+ schema: props.schema,
+ dropped: droppedEmptyOptionCount,
+ },
+ );
+ }
const type = mapJsonSchemaTypeToInputType(props.schema);
const { size = "small" } = formContext || {};
const selectedIndexes = enumOptionsIndexForValue(
diff --git a/autogpt_platform/frontend/src/components/renderers/InputRenderer/base/standard/widgets/SelectInput/__tests__/SelectWidget.test.tsx b/autogpt_platform/frontend/src/components/renderers/InputRenderer/base/standard/widgets/SelectInput/__tests__/SelectWidget.test.tsx
new file mode 100644
index 0000000000..de8afc86f5
--- /dev/null
+++ b/autogpt_platform/frontend/src/components/renderers/InputRenderer/base/standard/widgets/SelectInput/__tests__/SelectWidget.test.tsx
@@ -0,0 +1,306 @@
+import type { WidgetProps } from "@rjsf/utils";
+import type { ReactNode } from "react";
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { render, screen } from "@/tests/integrations/test-utils";
+import { SelectWidget } from "../SelectWidget";
+
+interface SelectMockProps {
+ onValueChange?: (value: string) => void;
+ options?: unknown;
+ value?: string;
+}
+
+interface MultiSelectorMockProps {
+ children: ReactNode;
+ onValuesChange: (values: string[]) => void;
+ values: string[];
+}
+
+const selectSpy = vi.fn();
+const multiSelectorSpy = vi.fn();
+
+function SelectMock(props: SelectMockProps) {
+ selectSpy(props);
+ return <div data-testid="select-widget-select" />;
+}
+
+function MultiSelectorMock(props: MultiSelectorMockProps) {
+ multiSelectorSpy(props);
+ return <div data-testid="multi-selector">{props.children}</div>;
+}
+
+function MultiSelectorContentMock({ children }: { children: ReactNode }) {
+ return <div>{children}</div>;
+}
+
+function MultiSelectorInputMock({ placeholder }: { placeholder?: string }) {
+ return <input data-testid="multi-selector-input" placeholder={placeholder} />;
+}
+
+function MultiSelectorItemMock({
+ children,
+ value,
+}: {
+ children: ReactNode;
+ value: string;
+}) {
+ return (
+ <div data-testid="multi-selector-item" data-value={value}>
+ {children}
+ </div>
+ );
+}
+
+function MultiSelectorListMock({ children }: { children: ReactNode }) {
+ return <div>{children}</div>;
+}
+
+function MultiSelectorTriggerMock({ children }: { children: ReactNode }) {
+ return <div>{children}</div>;
+}
+
+vi.mock("@/components/atoms/Select/Select", () => ({
+ Select: SelectMock,
+}));
+
+vi.mock("@/components/__legacy__/ui/multiselect", () => ({
+ MultiSelector: MultiSelectorMock,
+ MultiSelectorContent: MultiSelectorContentMock,
+ MultiSelectorInput: MultiSelectorInputMock,
+ MultiSelectorItem: MultiSelectorItemMock,
+ MultiSelectorList: MultiSelectorListMock,
+ MultiSelectorTrigger: MultiSelectorTriggerMock,
+}));
+
+afterEach(() => {
+ selectSpy.mockClear();
+ multiSelectorSpy.mockClear();
+ vi.unstubAllEnvs();
+ vi.restoreAllMocks();
+});
+
+function createProps(overrides: Partial<WidgetProps> = {}): WidgetProps {
+ return {
+ id: "color",
+ name: "color",
+ schema: { type: "string" },
+ uiSchema: {},
+ value: undefined,
+ required: false,
+ disabled: false,
+ readonly: false,
+ hideError: false,
+ autofocus: false,
+ label: "",
+ options: { enumOptions: [] },
+ formContext: {},
+ onChange: vi.fn(),
+ onBlur: vi.fn(),
+ onFocus: vi.fn(),
+ rawErrors: [],
+ registry: {} as WidgetProps["registry"],
+ ...overrides,
+ };
+}
+
+describe("SelectWidget", () => {
+ it("passes an empty selected value to Select when the current value is an empty string", () => {
+ render(
+ <SelectWidget
+ {...createProps({
+ value: "",
+ options: {
+ enumOptions: [{ value: "red", label: "Red" }],
+ },
+ })}
+ />,
+ );
+
+ expect(selectSpy).toHaveBeenCalledOnce();
+ expect(selectSpy.mock.calls[0][0]).toMatchObject({
+ value: "",
+ options: [{ value: "0", label: "Red" }],
+ });
+ });
+
+ it("preserves falsy non-empty values like 0", () => {
+ render(
+ <SelectWidget
+ {...createProps({
+ value: 0,
+ options: {
+ enumOptions: [
+ { value: 0, label: "Zero" },
+ { value: 1, label: "One" },
+ ],
+ },
+ })}
+ />,
+ );
+
+ expect(selectSpy).toHaveBeenCalledOnce();
+ expect(selectSpy.mock.calls[0][0]).toMatchObject({
+ value: "0",
+ options: [
+ { value: "0", label: "Zero" },
+ { value: "1", label: "One" },
+ ],
+ });
+ });
+
+ it("preserves falsy non-empty values like false", () => {
+ render(
+ <SelectWidget
+ {...createProps({
+ schema: { type: "boolean" },
+ value: false,
+ options: {
+ enumOptions: [
+ { value: false, label: "Disabled" },
+ { value: true, label: "Enabled" },
+ ],
+ },
+ })}
+ />,
+ );
+
+ expect(selectSpy).toHaveBeenCalledOnce();
+ expect(selectSpy.mock.calls[0][0]).toMatchObject({
+ value: "0",
+ options: [
+ { value: "0", label: "Disabled" },
+ { value: "1", label: "Enabled" },
+ ],
+ });
+ });
+
+ it("falls back to an empty option list when enumOptions are missing", () => {
+ render(
+ <SelectWidget
+ {...createProps({
+ options: {} as WidgetProps["options"],
+ })}
+ />,
+ );
+
+ expect(selectSpy).toHaveBeenCalledOnce();
+ expect(selectSpy.mock.calls[0][0]).toMatchObject({
+ options: [],
+ });
+ });
+
+ it("warns in development when empty-string enum options are dropped", () => {
+ vi.stubEnv("NODE_ENV", "development");
+ const warnSpy = vi.spyOn(console, "warn").mockImplementation(() => {});
+
+ render(
+ <SelectWidget
+ {...createProps({
+ options: {
+ enumOptions: [
+ { value: "", label: "Empty" },
+ { value: "red", label: "Red" },
+ ],
+ },
+ })}
+ />,
+ );
+
+ expect(warnSpy).toHaveBeenCalledWith(
+ "[SelectWidget] Dropped enum option(s) with empty-string value. Radix Select.Item disallows empty values.",
+ {
+ schema: { type: "string" },
+ dropped: 1,
+ },
+ );
+ expect(selectSpy.mock.calls[0][0]).toMatchObject({
+ options: [{ value: "0", label: "Red" }],
+ });
+ });
+
+ it("maps selected indexes back to enum option values for single-select changes", () => {
+ const onChange = vi.fn();
+
+ render(
+ <SelectWidget
+ {...createProps({
+ onChange,
+ options: {
+ enumOptions: [
+ { value: "red", label: "Red" },
+ { value: "green", label: "Green" },
+ ],
+ },
+ })}
+ />,
+ );
+
+ const selectProps = selectSpy.mock.calls[0][0] as SelectMockProps;
+ selectProps.onValueChange?.("1");
+
+ expect(onChange).toHaveBeenCalledWith("green");
+ });
+
+ it("maps multi-select labels back to enum option values", () => {
+ const onChange = vi.fn();
+
+ render(
+ <SelectWidget
+ {...createProps({
+ schema: {
+ type: "array",
+ items: {
+ type: "string",
+ enum: ["red", "green"],
+ },
+ },
+ value: ["red"],
+ onChange,
+ options: {
+ enumOptions: [
+ { value: "red", label: "Red" },
+ { value: "green", label: "Green" },
+ ],
+ },
+ })}
+ />,
+ );
+
+ expect(multiSelectorSpy).toHaveBeenCalledOnce();
+ const multiSelectorProps = multiSelectorSpy.mock
+ .calls[0][0] as MultiSelectorMockProps;
+ expect(multiSelectorProps.values).toEqual(["Red"]);
+
+ multiSelectorProps.onValuesChange(["Red", "Green", "Unknown"]);
+
+ expect(onChange).toHaveBeenCalledWith(["red", "green"]);
+ });
+
+ it("filters empty-string enum options for the multi-select path", () => {
+ render(
+ <SelectWidget
+ {...createProps({
+ schema: {
+ type: "array",
+ items: {
+ type: "string",
+ enum: ["", "red"],
+ },
+ },
+ value: [],
+ options: {
+ enumOptions: [
+ { value: "", label: "Empty" },
+ { value: "red", label: "Red" },
+ ],
+ },
+ })}
+ />,
+ );
+
+ const items = screen.getAllByTestId("multi-selector-item");
+ expect(items).toHaveLength(1);
+ expect(items[0].getAttribute("data-value")).toBe("Red");
+ expect(items[0].textContent).toContain("Red");
+ });
+});
diff --git a/autogpt_platform/frontend/src/components/renderers/InputRenderer/stories/PrimitiveFields.stories.tsx b/autogpt_platform/frontend/src/components/renderers/InputRenderer/stories/PrimitiveFields.stories.tsx
index 2b88575ae8..d1cdfd7db0 100644
--- a/autogpt_platform/frontend/src/components/renderers/InputRenderer/stories/PrimitiveFields.stories.tsx
+++ b/autogpt_platform/frontend/src/components/renderers/InputRenderer/stories/PrimitiveFields.stories.tsx
@@ -141,6 +141,27 @@ export const EnumField: Story = {
),
};
+function EnumWithEmptyStringValueRender() {
+ return (
+ <FormRendererStory
+ jsonSchema={{
+ type: "object",
+ properties: {
+ color: {
+ type: "string",
+ title: "Color",
+ enum: ["", "red", "green", "blue"],
+ },
+ },
+ }}
+ />
+ );
+}
+
+export const EnumWithEmptyStringValue: Story = {
+ render: EnumWithEmptyStringValueRender,
+};
+
export const EnumWithDefault: Story = {
render: () => (
<FormRendererStory