Skip to content

AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.

fix(backend/copilot): a delegated Expert chat starts on the mode its parent chat's gate enforces (#15643)

Reinier van der Leer6d793e53d878
diff --git a/autogpt_platform/backend/backend/copilot/gate/__init__.py b/autogpt_platform/backend/backend/copilot/gate/__init__.py
index 5d99fd86ef..b846126a19 100644
--- a/autogpt_platform/backend/backend/copilot/gate/__init__.py
+++ b/autogpt_platform/backend/backend/copilot/gate/__init__.py
@@ -38,6 +38,7 @@ from .policy import (
Verdict,
effect_for,
estimate_for,
+ strictest_mode,
verdict_for_effect,
)
from .subject import Subject
@@ -124,6 +125,16 @@ async def active_mode(
return resolve_mode(session) if await gate_active(user_id, session) else None
+def child_autopilot_mode(
+ parent: ChatSession, expert_default: AutopilotMode | None
+) -> AutopilotMode:
+ """The mode a delegated or handed-off thread starts on: what the parent's
+ gate enforces, not what the parent stored, tightened by the expert's own
+ default where that is stricter."""
+ mode = resolve_mode(parent)
+ return mode if expert_default is None else strictest_mode(mode, expert_default)
+
+
async def check_action(
tool_name: str,
args: dict[str, Any],
@@ -354,6 +365,7 @@ __all__ = [
"LINKED_CHAT_PLATFORMS",
"active_mode",
"check_action",
+ "child_autopilot_mode",
"gate_active",
"refusal_message",
"resolve_mode",
diff --git a/autogpt_platform/backend/backend/copilot/gate/gate_test.py b/autogpt_platform/backend/backend/copilot/gate/gate_test.py
index 4eb99b3a86..8f485772c5 100644
--- a/autogpt_platform/backend/backend/copilot/gate/gate_test.py
+++ b/autogpt_platform/backend/backend/copilot/gate/gate_test.py
@@ -13,10 +13,12 @@ import pytest
from prisma.enums import ReviewStatus
from backend.copilot.gate import (
+ LINKED_CHAT_PLATFORMS,
RUN_FILES_KEY,
active_mode,
chat_rules,
check_action,
+ child_autopilot_mode,
gate_active,
held,
)
@@ -140,6 +142,28 @@ async def test_the_default_mode_is_auto(gate_on):
assert await active_mode("u", _session()) == "auto"
+def test_a_delegated_thread_follows_its_parent_when_the_expert_has_no_default():
+ assert child_autopilot_mode(_session("ask_first"), None) == "ask_first"
+ assert child_autopilot_mode(_session("unsupervised"), None) == "unsupervised"
+ assert child_autopilot_mode(_session(), None) == "auto"
+
+
+def test_a_delegated_thread_is_never_looser_than_its_parent():
+ assert child_autopilot_mode(_session("ask_first"), "unsupervised") == "ask_first"
+ # A parent on the platform default cannot hand out an unsupervised thread.
+ assert child_autopilot_mode(_session(), "unsupervised") == "auto"
+ assert child_autopilot_mode(_session("unsupervised"), "ask_first") == "ask_first"
+ assert child_autopilot_mode(_session("auto"), "auto") == "auto"
+
+
[email protected]("platform", sorted(LINKED_CHAT_PLATFORMS))
+def test_a_linked_chat_hands_its_thread_the_mode_its_gate_enforces(platform):
+ """A linked chat runs on Auto whatever it has stored."""
+ parent = _session("unsupervised", source_platform=platform)
+ assert child_autopilot_mode(parent, None) == "auto"
+ assert child_autopilot_mode(parent, "ask_first") == "ask_first"
+
+
async def test_an_approval_is_consulted_before_the_effect(gate_on, clean_session_state):
"""Otherwise an approved outward call would park a second card forever."""
with (
diff --git a/autogpt_platform/backend/backend/copilot/gate/policy.py b/autogpt_platform/backend/backend/copilot/gate/policy.py
index 191d2019a1..80db962bfb 100644
--- a/autogpt_platform/backend/backend/copilot/gate/policy.py
+++ b/autogpt_platform/backend/backend/copilot/gate/policy.py
@@ -19,20 +19,6 @@ def strictest_mode(*modes: AutopilotMode) -> AutopilotMode:
return min(modes, key=_MODES_BY_STRICTNESS.index)
-def child_autopilot_mode(
- parent: AutopilotMode | None, expert_default: AutopilotMode | None
-) -> AutopilotMode | None:
- """The mode a delegated thread starts on.
-
- An expert with no default follows the chat that delegated to it. One with
- a default never gets a looser thread than that chat: a parent in
- ``ask_first`` cannot farm work out to an unsupervised teammate.
- """
- if expert_default is None:
- return parent
- return strictest_mode(parent or DEFAULT_MODE, expert_default)
-
-
class Effect(str, Enum):
READ = "read"
WORKSPACE = "workspace"
diff --git a/autogpt_platform/backend/backend/copilot/gate/policy_test.py b/autogpt_platform/backend/backend/copilot/gate/policy_test.py
index ccc4526c5d..8824328375 100644
--- a/autogpt_platform/backend/backend/copilot/gate/policy_test.py
+++ b/autogpt_platform/backend/backend/copilot/gate/policy_test.py
@@ -7,7 +7,6 @@ from backend.copilot.gate.policy import (
MCP_FILE_WRITE_TOOLS,
Effect,
Verdict,
- child_autopilot_mode,
classified_tools,
effect_for,
strictest_mode,
@@ -81,17 +80,3 @@ def test_the_strictest_mode_is_the_one_that_asks_most():
assert strictest_mode("auto", "ask_first") == "ask_first"
assert strictest_mode("unsupervised", "auto") == "auto"
assert strictest_mode("unsupervised") == "unsupervised"
-
-
-def test_a_delegated_thread_follows_its_parent_when_the_expert_has_no_default():
- assert child_autopilot_mode("ask_first", None) == "ask_first"
- assert child_autopilot_mode("unsupervised", None) == "unsupervised"
- assert child_autopilot_mode(None, None) is None
-
-
-def test_a_delegated_thread_is_never_looser_than_its_parent():
- assert child_autopilot_mode("ask_first", "unsupervised") == "ask_first"
- # A parent on the platform default cannot hand out an unsupervised thread.
- assert child_autopilot_mode(None, "unsupervised") == "auto"
- assert child_autopilot_mode("unsupervised", "ask_first") == "ask_first"
- assert child_autopilot_mode("auto", "auto") == "auto"
diff --git a/autogpt_platform/backend/backend/copilot/model.py b/autogpt_platform/backend/backend/copilot/model.py
index 16c0d802c5..0f6d9561d4 100644
--- a/autogpt_platform/backend/backend/copilot/model.py
+++ b/autogpt_platform/backend/backend/copilot/model.py
@@ -1417,7 +1417,7 @@ async def create_chat_session(
is off, like the per-thread override.
inherited_autopilot_mode: The mode a delegated thread must start on,
already decided by the caller from the parent chat and the
- target expert (``gate.policy.child_autopilot_mode``). Stored
+ target expert (``gate.child_autopilot_mode``). Stored
as-is: it is a constraint rather than a pick, so the flag does
not drop it and the expert is not read a second time.
diff --git a/autogpt_platform/backend/backend/copilot/tools/delegate_to_expert.py b/autogpt_platform/backend/backend/copilot/tools/delegate_to_expert.py
index c31f5e58f8..e5ac0d7a76 100644
--- a/autogpt_platform/backend/backend/copilot/tools/delegate_to_expert.py
+++ b/autogpt_platform/backend/backend/copilot/tools/delegate_to_expert.py
@@ -36,7 +36,7 @@ from backend.api.features.experts.models import Expert
from backend.copilot.active_turns import spawn_limit_message
from backend.copilot.budget_signal import build_spawn_state_note
from backend.copilot.context import get_current_permissions
-from backend.copilot.gate.policy import DEFAULT_MODE, child_autopilot_mode
+from backend.copilot.gate import child_autopilot_mode
from backend.copilot.model import (
ChatSession,
child_session_origin,
@@ -309,9 +309,8 @@ class DelegateToExpertTool(BaseTool):
# Decided here, from the expert row already in hand, so the
# thread cannot pick up a looser default written in between.
inherited_autopilot_mode=child_autopilot_mode(
- session.metadata.autopilot_mode, target.autopilot_mode
- )
- or DEFAULT_MODE,
+ session, target.autopilot_mode
+ ),
)
return new_session.session_id
diff --git a/autogpt_platform/backend/backend/copilot/tools/delegate_to_expert_test.py b/autogpt_platform/backend/backend/copilot/tools/delegate_to_expert_test.py
index e849e75db1..858eedd842 100644
--- a/autogpt_platform/backend/backend/copilot/tools/delegate_to_expert_test.py
+++ b/autogpt_platform/backend/backend/copilot/tools/delegate_to_expert_test.py
@@ -27,6 +27,7 @@ def _session(
session_id: str = "s1",
expert_id: str | None = "expert-a",
origin: str | None = "interactive",
+ source_platform: str | None = None,
) -> MagicMock:
sess = MagicMock()
sess.session_id = session_id
@@ -38,6 +39,7 @@ def _session(
sess.metadata.llm_credential_id = None
sess.metadata.delegated_by_session_id = None
sess.metadata.autopilot_mode = None
+ sess.metadata.source_platform = source_platform
# Set explicitly: a bare MagicMock attribute is truthy, so an origin
# assertion would pass even if the kwarg were dropped.
sess.metadata.origin = origin
@@ -238,6 +240,23 @@ class TestDelegatedSessionMode:
)
assert mock_sessions[0].metadata.autopilot_mode == "auto"
+ @pytest.mark.asyncio
+ @pytest.mark.parametrize(
+ "expert_default, expected",
+ [(None, "auto"), ("unsupervised", "auto"), ("ask_first", "ask_first")],
+ )
+ async def test_a_linked_chat_hands_out_the_mode_its_gate_enforces(
+ self, roster, mock_turn, mock_sessions, expert_default, expected
+ ):
+ """A Slack chat runs on Auto whatever it has stored, so its thread does too."""
+ roster["expert-b"].autopilot_mode = expert_default
+ parent = _session(source_platform="slack")
+ parent.metadata.autopilot_mode = "unsupervised"
+ await DelegateToExpertTool()._execute(
+ user_id="alice", session=parent, expert_id="expert-b", prompt="hi"
+ )
+ assert mock_sessions[0].metadata.autopilot_mode == expected
+
class TestValidation:
@pytest.mark.asyncio
diff --git a/autogpt_platform/backend/backend/copilot/tools/handoff_to_expert.py b/autogpt_platform/backend/backend/copilot/tools/handoff_to_expert.py
index c34f0e7a3a..220dbf59c6 100644
--- a/autogpt_platform/backend/backend/copilot/tools/handoff_to_expert.py
+++ b/autogpt_platform/backend/backend/copilot/tools/handoff_to_expert.py
@@ -28,7 +28,7 @@ from backend.api.features.experts.models import Expert
from backend.copilot.active_turns import spawn_limit_message
from backend.copilot.budget_signal import build_spawn_state_note
from backend.copilot.context import get_current_permissions
-from backend.copilot.gate.policy import DEFAULT_MODE, child_autopilot_mode
+from backend.copilot.gate import child_autopilot_mode
from backend.copilot.model import (
ChatSession,
child_session_origin,
@@ -186,9 +186,8 @@ class HandoffToExpertTool(BaseTool):
# Same cap delegation applies: an Ask-first chat cannot hand its
# work to a thread that runs it unsupervised.
inherited_autopilot_mode=child_autopilot_mode(
- session.metadata.autopilot_mode, target.autopilot_mode
- )
- or DEFAULT_MODE,
+ session, target.autopilot_mode
+ ),
)
outcome, result = await self._queue_task(
user_id, session, inner.session_id, prompt, context
diff --git a/autogpt_platform/backend/backend/copilot/tools/handoff_to_expert_test.py b/autogpt_platform/backend/backend/copilot/tools/handoff_to_expert_test.py
index 750524908e..5633dec4a3 100644
--- a/autogpt_platform/backend/backend/copilot/tools/handoff_to_expert_test.py
+++ b/autogpt_platform/backend/backend/copilot/tools/handoff_to_expert_test.py
@@ -35,6 +35,7 @@ def _session(
session_id: str = "s1",
expert_id: str | None = "expert-a",
origin: str | None = "interactive",
+ source_platform: str | None = None,
) -> MagicMock:
sess = MagicMock()
sess.session_id = session_id
@@ -48,6 +49,7 @@ def _session(
sess.metadata.origin = origin
sess.metadata.delegated_by_session_id = None
sess.metadata.autopilot_mode = None
+ sess.metadata.source_platform = source_platform
sess.expert_id = expert_id
return sess
@@ -579,6 +581,23 @@ class TestHandedOffSessionMode:
)
assert mock_sessions[0].metadata.autopilot_mode == "auto"
+ @pytest.mark.asyncio
+ @pytest.mark.parametrize(
+ "expert_default, expected",
+ [(None, "auto"), ("unsupervised", "auto"), ("ask_first", "ask_first")],
+ )
+ async def test_a_linked_chat_hands_out_the_mode_its_gate_enforces(
+ self, roster, mock_turn, mock_sessions, expert_default, expected
+ ):
+ """A Slack chat runs on Auto whatever it has stored, so its thread does too."""
+ roster["expert-b"].autopilot_mode = expert_default
+ parent = _session(expert_id="expert-a", source_platform="slack")
+ parent.metadata.autopilot_mode = "unsupervised"
+ await HandoffToExpertTool()._execute(
+ user_id="alice", session=parent, expert_id="expert-b", prompt="own it"
+ )
+ assert mock_sessions[0].metadata.autopilot_mode == expected
+
class TestTerminalResponse:
"""A handoff is terminal for the caller: it names the new owner, links the