AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.
fix(frontend/marketplace): prevent agent page crash on 404 (#14453)
seer-by-sentry[bot]8af60ca5b45d
diff --git a/autogpt_platform/frontend/src/app/(platform)/marketplace/agent/[creator]/[slug]/__tests__/generateMetadata.test.ts b/autogpt_platform/frontend/src/app/(platform)/marketplace/agent/[creator]/[slug]/__tests__/generateMetadata.test.tsindex 5bfe7434e5..506e30e06b 100644--- a/autogpt_platform/frontend/src/app/(platform)/marketplace/agent/[creator]/[slug]/__tests__/generateMetadata.test.ts+++ b/autogpt_platform/frontend/src/app/(platform)/marketplace/agent/[creator]/[slug]/__tests__/generateMetadata.test.ts@@ -1,6 +1,15 @@+import { ApiError } from "@/lib/autogpt-server-api/helpers";import { beforeEach, describe, expect, test, vi } from "vitest";const mockGetSpecificAgent = vi.hoisted(() => vi.fn());+const mockNotFound = vi.hoisted(() =>+ vi.fn(() => {+ throw new Error("NEXT_NOT_FOUND");+ }),+);+const mockGetServerUser = vi.hoisted(() => vi.fn());+const mockPrefetchLibrary = vi.hoisted(() => vi.fn());+vi.mock("next/navigation", () => ({ notFound: mockNotFound }));vi.mock("@/app/api/__generated__/endpoints/store/store", () => ({getV2GetSpecificAgent: mockGetSpecificAgent,@@ -9,24 +18,74 @@ vi.mock("@/app/api/__generated__/endpoints/store/store", () => ({}));vi.mock("@/app/api/__generated__/endpoints/library/library", () => ({- prefetchGetV2GetAgentByStoreIdQuery: vi.fn(),+ prefetchGetV2GetAgentByStoreIdQuery: mockPrefetchLibrary,}));vi.mock("@/lib/auth/server/getServerUser", () => ({- getServerUser: vi.fn(),+ getServerUser: mockGetServerUser,}));vi.mock("../../../../components/MainAgentPage/MainAgentPage", () => ({MainAgentPage: () => null,}));-import { generateMetadata } from "../page";+import MarketplaceAgentPage, { generateMetadata } from "../page";const params = { creator: "pwuts", slug: "an-agent" };describe("generateMetadata", () => {beforeEach(() => {mockGetSpecificAgent.mockReset();+ mockGetServerUser.mockResolvedValue({ user: null });+ mockNotFound.mockClear();+ mockPrefetchLibrary.mockClear();+ });++ describe.each([+ ["metadata", generateMetadata],+ ["page", MarketplaceAgentPage],+ ])("%s error handling", (_name, load) => {+ test("renders not-found for a missing listing", async () => {+ mockGetSpecificAgent.mockRejectedValue(+ new ApiError("Not Found", 404, null),+ );+ await expect(load({ params: Promise.resolve(params) })).rejects.toThrow(+ "NEXT_NOT_FOUND",+ );+ expect(mockNotFound).toHaveBeenCalledOnce();+ });++ test("preserves server errors", async () => {+ const error = new ApiError("Internal Server Error", 500, null);+ mockGetSpecificAgent.mockRejectedValue(error);+ await expect(load({ params: Promise.resolve(params) })).rejects.toBe(+ error,+ );+ expect(mockNotFound).not.toHaveBeenCalled();+ });++ test("preserves network errors", async () => {+ const error = new Error("fetch failed");+ mockGetSpecificAgent.mockRejectedValue(error);+ await expect(load({ params: Promise.resolve(params) })).rejects.toBe(+ error,+ );+ expect(mockNotFound).not.toHaveBeenCalled();+ });+ });++ test("prefetches the signed-in user's library entry for an existing listing", async () => {+ mockGetServerUser.mockResolvedValue({ user: { id: "user-1" } });+ mockGetSpecificAgent.mockResolvedValue({+ status: 200,+ data: { active_version_id: "version-1" },+ });+ await MarketplaceAgentPage({ params: Promise.resolve(params) });+ expect(mockPrefetchLibrary).toHaveBeenCalledWith(+ expect.anything(),+ "version-1",+ { query: { enabled: true } },+ );});test("previews the agent's own name, description and image", async () => {diff --git a/autogpt_platform/frontend/src/app/(platform)/marketplace/agent/[creator]/[slug]/page.tsx b/autogpt_platform/frontend/src/app/(platform)/marketplace/agent/[creator]/[slug]/page.tsxindex 0f69b77e7e..b96a37eddf 100644--- a/autogpt_platform/frontend/src/app/(platform)/marketplace/agent/[creator]/[slug]/page.tsx+++ b/autogpt_platform/frontend/src/app/(platform)/marketplace/agent/[creator]/[slug]/page.tsx@@ -1,3 +1,5 @@+import { ApiError } from "@/lib/autogpt-server-api/helpers";+import { notFound } from "next/navigation";import { prefetchGetV2GetAgentByStoreIdQuery } from "@/app/api/__generated__/endpoints/library/library";import {getV2GetSpecificAgent,@@ -22,7 +24,7 @@ export async function generateMetadata({params: Promise<MarketplaceAgentPageParams>;}): Promise<Metadata> {const params = await _params;- const { data } = await getV2GetSpecificAgent(params.creator, params.slug);+ const { data } = await getAgentOrNotFound(params.creator, params.slug);const agent = data as StoreAgentDetails;return buildPageMetadata({@@ -54,7 +56,7 @@ export default async function MarketplaceAgentPage({]);const { user } = await getServerUser();- const { data: creator_agent, status } = await getV2GetSpecificAgent(+ const { data: creator_agent, status } = await getAgentOrNotFound(creator_lower,params.slug,); // Already cached in above prefetch@@ -76,3 +78,14 @@ export default async function MarketplaceAgentPage({</HydrationBoundary>);}++async function getAgentOrNotFound(creator: string, slug: string) {+ try {+ return await getV2GetSpecificAgent(creator, slug);+ } catch (error) {+ if (error instanceof ApiError && error.status === 404) {+ notFound();+ }+ throw error;+ }+}