Skip to content

AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.

fix(blocks): SendWebRequestBlock to properly handle HTTP error responses (#9655)

Toran Bruce Richards93238dc78c23
diff --git a/autogpt_platform/backend/backend/blocks/http.py b/autogpt_platform/backend/backend/blocks/http.py
index 099e2c3c1e..0ec498a5bc 100644
--- a/autogpt_platform/backend/backend/blocks/http.py
+++ b/autogpt_platform/backend/backend/blocks/http.py
@@ -1,11 +1,16 @@
import json
+import logging
from enum import Enum
from typing import Any
+from requests.exceptions import HTTPError, RequestException
+
from backend.data.block import Block, BlockCategory, BlockOutput, BlockSchema
from backend.data.model import SchemaField
from backend.util.request import requests
+logger = logging.getLogger(name=__name__)
+
class HttpMethod(Enum):
GET = "GET"
@@ -43,8 +48,9 @@ class SendWebRequestBlock(Block):
class Output(BlockSchema):
response: object = SchemaField(description="The response from the server")
- client_error: object = SchemaField(description="The error on 4xx status codes")
- server_error: object = SchemaField(description="The error on 5xx status codes")
+ client_error: object = SchemaField(description="Errors on 4xx status codes")
+ server_error: object = SchemaField(description="Errors on 5xx status codes")
+ error: str = SchemaField(description="Errors for all other exceptions")
def __init__(self):
super().__init__(
@@ -68,20 +74,40 @@ class SendWebRequestBlock(Block):
# we should send it as plain text instead
input_data.json_format = False
- response = requests.request(
- input_data.method.value,
- input_data.url,
- headers=input_data.headers,
- json=body if input_data.json_format else None,
- data=body if not input_data.json_format else None,
- )
- result = response.json() if input_data.json_format else response.text
-
- if response.status_code // 100 == 2:
+ try:
+ response = requests.request(
+ input_data.method.value,
+ input_data.url,
+ headers=input_data.headers,
+ json=body if input_data.json_format else None,
+ data=body if not input_data.json_format else None,
+ )
+ result = response.json() if input_data.json_format else response.text
yield "response", result
- elif response.status_code // 100 == 4:
- yield "client_error", result
- elif response.status_code // 100 == 5:
- yield "server_error", result
- else:
- raise ValueError(f"Unexpected status code: {response.status_code}")
+
+ except HTTPError as e:
+ # Handle error responses
+ try:
+ result = e.response.json() if input_data.json_format else str(e)
+ except json.JSONDecodeError:
+ result = str(e)
+
+ if 400 <= e.response.status_code < 500:
+ yield "client_error", result
+ elif 500 <= e.response.status_code < 600:
+ yield "server_error", result
+ else:
+ error_msg = (
+ "Unexpected status code "
+ f"{e.response.status_code} '{e.response.reason}'"
+ )
+ logger.warning(error_msg)
+ yield "error", error_msg
+
+ except RequestException as e:
+ # Handle other request-related exceptions
+ yield "error", str(e)
+
+ except Exception as e:
+ # Catch any other unexpected exceptions
+ yield "error", str(e)