AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.
fix(backend): load the block registry when the database manager starts (#15884)
Reinier van der Leer9fb184c0f49a
diff --git a/autogpt_platform/backend/backend/data/db_manager.py b/autogpt_platform/backend/backend/data/db_manager.pyindex 7fb5eb532f..bde7955226 100644--- a/autogpt_platform/backend/backend/data/db_manager.py+++ b/autogpt_platform/backend/backend/data/db_manager.py@@ -1,4 +1,5 @@import logging+import timefrom contextlib import asynccontextmanagerfrom typing import TYPE_CHECKING, Callable, Concatenate, ParamSpec, TypeVar, cast@@ -59,6 +60,7 @@ from backend.api.features.store.db import (get_store_agents,)from backend.api.features.store.embeddings import backfill_missing_embeddings+from backend.blocks import get_blocksfrom backend.copilot import db as chat_dbfrom backend.copilot.scheduled_chats.forget import forget_scheduled_chatfrom backend.copilot.scheduled_chats.service import record_scheduled_run@@ -329,6 +331,15 @@ class DatabaseManager(AppService):logger.info(f"[{self.service_name}] ⏳ Connecting to Database...")await db.connect()+ # Load the block registry before serving. The first RPC that needs a+ # block loads it otherwise, on this event loop, and every RPC waits.+ load_started = time.monotonic()+ block_count = len(get_blocks())+ logger.info(+ f"[{self.service_name}] Loaded {block_count} blocks in "+ f"{time.monotonic() - load_started:.1f}s"+ )+logger.info(f"[{self.service_name}] ✅ Ready")yielddiff --git a/autogpt_platform/backend/backend/data/db_manager_block_warmup_test.py b/autogpt_platform/backend/backend/data/db_manager_block_warmup_test.pynew file mode 100644index 0000000000..0ce74ca26c--- /dev/null+++ b/autogpt_platform/backend/backend/data/db_manager_block_warmup_test.py@@ -0,0 +1,32 @@+"""The database manager must load the block registry before it serves any RPC."""++from unittest.mock import AsyncMock++from backend.data import db_manager+from backend.data.db_manager import DatabaseManager+++async def test_startup_loads_blocks_before_freezing_the_heap_and_serving(mocker):+ """Otherwise the first RPC that needs a block imports them all on the+ service's one event loop, and every other RPC waits seconds behind it."""+ order: list[str] = []++ def load_blocks() -> dict:+ order.append("load_blocks")+ return {}++ mocker.patch("backend.util.service.redis_client.get_redis_async", AsyncMock())+ mocker.patch("backend.util.service.redis_client.disconnect_async", AsyncMock())+ mocker.patch.object(db_manager.db, "connect", AsyncMock())+ mocker.patch.object(db_manager.db, "disconnect", AsyncMock())+ mocker.patch.object(db_manager, "get_blocks", side_effect=load_blocks)+ mocker.patch(+ "backend.util.service.freeze_startup_heap",+ lambda: order.append("freeze_heap"),+ )+ app = DatabaseManager().build_fastapi_app()++ async with app.router.lifespan_context(app):+ order.append("serving")++ assert order == ["load_blocks", "freeze_heap", "serving"]