Skip to content

AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.

fix(logging): remove uvicorn log config to prevent startup deadlock (#10638)

Zamil Majdyaf7d56612d33
diff --git a/autogpt_platform/autogpt_libs/autogpt_libs/logging/utils.py b/autogpt_platform/autogpt_libs/autogpt_libs/logging/utils.py
index 8abf04c226..0b92e2967d 100644
--- a/autogpt_platform/autogpt_libs/autogpt_libs/logging/utils.py
+++ b/autogpt_platform/autogpt_libs/autogpt_libs/logging/utils.py
@@ -1,39 +1,5 @@
-import logging
import re
-from typing import Any
-
-import uvicorn.config
-from colorama import Fore
def remove_color_codes(s: str) -> str:
return re.sub(r"\x1B(?:[@-Z\\-_]|\[[0-?]*[ -/]*[@-~])", "", s)
-
-
-def fmt_kwargs(kwargs: dict) -> str:
- return ", ".join(f"{n}={repr(v)}" for n, v in kwargs.items())
-
-
-def print_attribute(
- title: str, value: Any, title_color: str = Fore.GREEN, value_color: str = ""
-) -> None:
- logger = logging.getLogger()
- logger.info(
- str(value),
- extra={
- "title": f"{title.rstrip(':')}:",
- "title_color": title_color,
- "color": value_color,
- },
- )
-
-
-def generate_uvicorn_config():
- """
- Generates a uvicorn logging config that silences uvicorn's default logging and tells it to use the native logging module.
- """
- log_config = dict(uvicorn.config.LOGGING_CONFIG)
- log_config["loggers"]["uvicorn"] = {"handlers": []}
- log_config["loggers"]["uvicorn.error"] = {"handlers": []}
- log_config["loggers"]["uvicorn.access"] = {"handlers": []}
- return log_config
diff --git a/autogpt_platform/backend/backend/server/rest_api.py b/autogpt_platform/backend/backend/server/rest_api.py
index b414bd4207..6f0ce0b3d1 100644
--- a/autogpt_platform/backend/backend/server/rest_api.py
+++ b/autogpt_platform/backend/backend/server/rest_api.py
@@ -9,7 +9,6 @@ import fastapi.responses
import pydantic
import starlette.middleware.cors
import uvicorn
-from autogpt_libs.logging.utils import generate_uvicorn_config
from fastapi.exceptions import RequestValidationError
from fastapi.routing import APIRoute
@@ -247,7 +246,7 @@ class AgentServer(backend.util.service.AppProcess):
server_app,
host=backend.util.settings.Config().agent_api_host,
port=backend.util.settings.Config().agent_api_port,
- log_config=generate_uvicorn_config(),
+ log_config=None,
)
def cleanup(self):
diff --git a/autogpt_platform/backend/backend/server/ws_api.py b/autogpt_platform/backend/backend/server/ws_api.py
index 38dd26dc15..65b747c8b2 100644
--- a/autogpt_platform/backend/backend/server/ws_api.py
+++ b/autogpt_platform/backend/backend/server/ws_api.py
@@ -6,7 +6,6 @@ from typing import Protocol
import pydantic
import uvicorn
from autogpt_libs.auth import parse_jwt_token
-from autogpt_libs.logging.utils import generate_uvicorn_config
from fastapi import Depends, FastAPI, WebSocket, WebSocketDisconnect
from starlette.middleware.cors import CORSMiddleware
@@ -309,7 +308,7 @@ class WebsocketServer(AppProcess):
server_app,
host=Config().websocket_server_host,
port=Config().websocket_server_port,
- log_config=generate_uvicorn_config(),
+ log_config=None,
)
def cleanup(self):
diff --git a/autogpt_platform/backend/backend/util/service.py b/autogpt_platform/backend/backend/util/service.py
index 028f0e5fea..58d037a60e 100644
--- a/autogpt_platform/backend/backend/util/service.py
+++ b/autogpt_platform/backend/backend/util/service.py
@@ -24,7 +24,6 @@ from typing import (
import httpx
import uvicorn
-from autogpt_libs.logging.utils import generate_uvicorn_config
from fastapi import FastAPI, Request, responses
from pydantic import BaseModel, TypeAdapter, create_model
@@ -266,7 +265,7 @@ class AppService(BaseAppService, ABC):
self.fastapi_app,
host=api_host,
port=self.get_port(),
- log_config=generate_uvicorn_config(),
+ log_config=None, # Explicitly None to avoid uvicorn replacing the logger.
log_level=self.log_level,
)
)