AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.
fix(frontend): integer input no longer produces NaN on paste (#13146)
Krzysztof Czerwinskib41559fe63ae
diff --git a/autogpt_platform/frontend/src/components/renderers/InputRenderer/base/standard/widgets/TextInput/TextWidget.tsx b/autogpt_platform/frontend/src/components/renderers/InputRenderer/base/standard/widgets/TextInput/TextWidget.tsxindex 33a55581c7..34b0103114 100644--- a/autogpt_platform/frontend/src/components/renderers/InputRenderer/base/standard/widgets/TextInput/TextWidget.tsx+++ b/autogpt_platform/frontend/src/components/renderers/InputRenderer/base/standard/widgets/TextInput/TextWidget.tsx@@ -45,12 +45,20 @@ export default function TextWidget(props: WidgetProps) {[InputType.NUMBER]: {htmlType: "number",placeholder: "Enter number value...",- handleChange: (v: string) => (v === "" ? undefined : Number(v)),+ handleChange: (v: string) => {+ if (v === "") return undefined;+ const n = Number(v);+ return Number.isFinite(n) ? n : undefined;+ },},[InputType.INTEGER]: {- htmlType: "account",+ htmlType: "number",placeholder: "Enter integer value...",- handleChange: (v: string) => (v === "" ? undefined : Number(v)),+ handleChange: (v: string) => {+ if (v === "") return undefined;+ const n = Number(v);+ return Number.isFinite(n) ? Math.trunc(n) : undefined;+ },},};@@ -62,6 +70,11 @@ export default function TextWidget(props: WidgetProps) {const config = (mapped && inputConfig[mapped]) || defaultConfig;+ const displayValue =+ typeof props.value === "number" && !Number.isFinite(props.value)+ ? ""+ : (props.value ?? "");+const handleChange = (e: React.ChangeEvent<HTMLInputElement | HTMLTextAreaElement>,) => {@@ -97,7 +110,7 @@ export default function TextWidget(props: WidgetProps) {label={""}size="small"wrapperClassName="mb-0"- value={props.value ?? ""}+ value={displayValue}className="!h-[230px] resize-none rounded-none border-none bg-transparent p-0 placeholder:text-black/60 focus:ring-0"onChange={handleChange}placeholder={"Write your note here..."}@@ -117,7 +130,7 @@ export default function TextWidget(props: WidgetProps) {label={""}size={inputSize as any}wrapperClassName="mb-0 flex-1"- value={props.value ?? ""}+ value={displayValue}onChange={handleChange}placeholder={placeholder || config.placeholder}required={props.required}@@ -148,7 +161,7 @@ export default function TextWidget(props: WidgetProps) {onSave={handleModalSave}title={schema.title || "Edit value"}description={schema.description || ""}- defaultValue={props.value ?? ""}+ defaultValue={displayValue}placeholder={placeholder || config.placeholder}/></>diff --git a/autogpt_platform/frontend/src/components/renderers/InputRenderer/base/standard/widgets/TextInput/__tests__/TextWidget.test.tsx b/autogpt_platform/frontend/src/components/renderers/InputRenderer/base/standard/widgets/TextInput/__tests__/TextWidget.test.tsxnew file mode 100644index 0000000000..86bc497fc5--- /dev/null+++ b/autogpt_platform/frontend/src/components/renderers/InputRenderer/base/standard/widgets/TextInput/__tests__/TextWidget.test.tsx@@ -0,0 +1,246 @@+import { fireEvent, screen } from "@testing-library/react";+import { WidgetProps } from "@rjsf/utils";+import { describe, expect, it, vi } from "vitest";++import { BlockUIType } from "@/app/(platform)/build/components/types";+import { render } from "@/tests/integrations/test-utils";++import TextWidget from "../TextWidget";++function makeProps(overrides: Partial<WidgetProps> = {}): WidgetProps {+ const defaults = {+ id: "test-input",+ name: "test-input",+ label: "Test",+ value: undefined,+ onChange: vi.fn(),+ onBlur: vi.fn(),+ onFocus: vi.fn(),+ schema: { type: "string" },+ options: {},+ required: false,+ disabled: false,+ readonly: false,+ registry: {+ formContext: {+ size: "small",+ uiType: BlockUIType.STANDARD,+ },+ },+ };++ return {+ ...defaults,+ ...overrides,+ registry: {+ ...defaults.registry,+ ...(overrides.registry ?? {}),+ },+ } as unknown as WidgetProps;+}++describe("TextWidget", () => {+ describe("integer input", () => {+ it("parses plain integer strings", () => {+ const onChange = vi.fn();+ const props = makeProps({+ schema: { type: "integer" },+ onChange,+ });++ render(<TextWidget {...props} />);++ fireEvent.change(screen.getByRole("spinbutton"), {+ target: { value: "123" },+ });++ expect(onChange).toHaveBeenLastCalledWith(123);+ });++ it("returns undefined for empty string", () => {+ const onChange = vi.fn();+ const props = makeProps({+ schema: { type: "integer" },+ value: 5,+ onChange,+ });++ render(<TextWidget {...props} />);++ fireEvent.change(screen.getByRole("spinbutton"), {+ target: { value: "" },+ });++ expect(onChange).toHaveBeenLastCalledWith(undefined);+ });++ it("returns undefined for non-numeric value rather than NaN", () => {+ const onChange = vi.fn();+ const props = makeProps({+ schema: { type: "integer" },+ onChange,+ });++ render(<TextWidget {...props} />);++ fireEvent.change(screen.getByRole("spinbutton"), {+ target: { value: "1,234" },+ });++ expect(onChange).toHaveBeenLastCalledWith(undefined);+ expect(onChange).not.toHaveBeenCalledWith(NaN);+ });++ it("truncates fractional values to integer", () => {+ const onChange = vi.fn();+ const props = makeProps({+ schema: { type: "integer" },+ onChange,+ });++ render(<TextWidget {...props} />);++ fireEvent.change(screen.getByRole("spinbutton"), {+ target: { value: "1.7" },+ });++ expect(onChange).toHaveBeenLastCalledWith(1);+ });++ it("correctly handles scientific notation", () => {+ const onChange = vi.fn();+ const props = makeProps({+ schema: { type: "integer" },+ onChange,+ });++ render(<TextWidget {...props} />);++ fireEvent.change(screen.getByRole("spinbutton"), {+ target: { value: "1e5" },+ });++ expect(onChange).toHaveBeenLastCalledWith(100000);+ });++ it("rejects non-finite values like 1e309", () => {+ const onChange = vi.fn();+ const props = makeProps({+ schema: { type: "integer" },+ value: 1,+ onChange,+ });++ render(<TextWidget {...props} />);++ fireEvent.change(screen.getByRole("spinbutton"), {+ target: { value: "1e309" },+ });++ expect(onChange).toHaveBeenLastCalledWith(undefined);+ });++ it("uses HTML number input type", () => {+ const props = makeProps({ schema: { type: "integer" } });+ render(<TextWidget {...props} />);+ expect(screen.getByRole("spinbutton").getAttribute("type")).toBe(+ "number",+ );+ });++ it("displays empty string when value is NaN", () => {+ const props = makeProps({+ schema: { type: "integer" },+ value: NaN,+ });++ render(<TextWidget {...props} />);++ const input = screen.getByRole("spinbutton") as HTMLInputElement;+ expect(input.value).toBe("");+ });++ it("displays empty string when value is Infinity", () => {+ const props = makeProps({+ schema: { type: "integer" },+ value: Infinity,+ });++ render(<TextWidget {...props} />);++ const input = screen.getByRole("spinbutton") as HTMLInputElement;+ expect(input.value).toBe("");+ });+ });++ describe("number input", () => {+ it("parses decimal values", () => {+ const onChange = vi.fn();+ const props = makeProps({+ schema: { type: "number" },+ onChange,+ });++ render(<TextWidget {...props} />);++ fireEvent.change(screen.getByRole("spinbutton"), {+ target: { value: "1.5" },+ });++ expect(onChange).toHaveBeenLastCalledWith(1.5);+ });++ it("returns undefined for non-numeric value rather than NaN", () => {+ const onChange = vi.fn();+ const props = makeProps({+ schema: { type: "number" },+ value: 1,+ onChange,+ });++ render(<TextWidget {...props} />);++ fireEvent.change(screen.getByRole("spinbutton"), {+ target: { value: "abc" },+ });++ expect(onChange).toHaveBeenLastCalledWith(undefined);+ expect(onChange).not.toHaveBeenCalledWith(NaN);+ });+ });++ describe("string input", () => {+ it("passes value through unchanged", () => {+ const onChange = vi.fn();+ const props = makeProps({+ schema: { type: "string" },+ onChange,+ });++ render(<TextWidget {...props} />);++ fireEvent.change(screen.getByRole("textbox"), {+ target: { value: "hello" },+ });++ expect(onChange).toHaveBeenLastCalledWith("hello");+ });++ it("returns undefined for empty string", () => {+ const onChange = vi.fn();+ const props = makeProps({+ schema: { type: "string" },+ value: "abc",+ onChange,+ });++ render(<TextWidget {...props} />);++ fireEvent.change(screen.getByRole("textbox"), {+ target: { value: "" },+ });++ expect(onChange).toHaveBeenLastCalledWith(undefined);+ });+ });+});