Skip to content

AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.

fix(platform): address reviewer feedback on subscription endpoint

Zamil Majdybfb82b624699
diff --git a/autogpt_platform/backend/backend/api/features/v1.py b/autogpt_platform/backend/backend/api/features/v1.py
index c263cb3fc8..b93d9e767b 100644
--- a/autogpt_platform/backend/backend/api/features/v1.py
+++ b/autogpt_platform/backend/backend/api/features/v1.py
@@ -736,6 +736,14 @@ async def update_subscription_tier(
# Pydantic validates tier is one of FREE/PRO/BUSINESS via Literal type.
tier = SubscriptionTier(request.tier)
+ # ENTERPRISE tier is admin-managed — block self-service changes from ENTERPRISE users.
+ user = await get_user_by_id(user_id)
+ if (user.subscription_tier or SubscriptionTier.FREE) == SubscriptionTier.ENTERPRISE:
+ raise HTTPException(
+ status_code=403,
+ detail="ENTERPRISE subscription changes must be managed by an administrator",
+ )
+
payment_enabled = await is_feature_enabled(
Flag.ENABLE_PLATFORM_PAYMENT, user_id, default=False
)
diff --git a/autogpt_platform/backend/backend/data/credit.py b/autogpt_platform/backend/backend/data/credit.py
index b5dd4c1fb8..0959c15d34 100644
--- a/autogpt_platform/backend/backend/data/credit.py
+++ b/autogpt_platform/backend/backend/data/credit.py
@@ -1348,16 +1348,16 @@ async def sync_subscription_from_stripe(stripe_subscription: dict) -> None:
elif price_id and biz_price and price_id == biz_price:
tier = SubscriptionTier.BUSINESS
else:
- # Unknown or unconfigured price ID — log a warning and default to FREE
- # to avoid leaving a paying user stuck on a stale tier if LD flags are
- # misconfigured or the price ID has changed.
+ # Unknown or unconfigured price ID — preserve the user's current tier
+ # rather than defaulting to FREE. This prevents accidental downgrades
+ # during a price migration or when LD flags are not yet configured.
logger.warning(
"sync_subscription_from_stripe: unknown price %s for customer %s,"
- " defaulting to FREE",
+ " preserving current tier",
price_id,
customer_id,
)
- tier = SubscriptionTier.FREE
+ return
else:
tier = SubscriptionTier.FREE
await set_subscription_tier(user.id, tier)
diff --git a/autogpt_platform/backend/backend/data/credit_subscription_test.py b/autogpt_platform/backend/backend/data/credit_subscription_test.py
index 0085cca26b..34ba19b83c 100644
--- a/autogpt_platform/backend/backend/data/credit_subscription_test.py
+++ b/autogpt_platform/backend/backend/data/credit_subscription_test.py
@@ -229,8 +229,8 @@ async def test_sync_subscription_from_stripe_unknown_price_defaults_to_free():
) as mock_set,
):
await sync_subscription_from_stripe(stripe_sub)
- # Unknown price → default to FREE, do not return early
- mock_set.assert_awaited_once_with("user-1", SubscriptionTier.FREE)
+ # Unknown price → preserve current tier (early return, no DB write)
+ mock_set.assert_not_awaited()
@pytest.mark.asyncio
@@ -259,8 +259,8 @@ async def test_sync_subscription_from_stripe_none_ld_price_defaults_to_free():
) as mock_set,
):
await sync_subscription_from_stripe(stripe_sub)
- # None from LD → comparison guards prevent match → default to FREE
- mock_set.assert_awaited_once_with("user-1", SubscriptionTier.FREE)
+ # None from LD → comparison guards prevent match → preserve current tier
+ mock_set.assert_not_awaited()
@pytest.mark.asyncio
diff --git a/autogpt_platform/frontend/src/app/(platform)/profile/(user)/credits/components/SubscriptionTierSection/useSubscriptionTierSection.ts b/autogpt_platform/frontend/src/app/(platform)/profile/(user)/credits/components/SubscriptionTierSection/useSubscriptionTierSection.ts
index b0ee8217e5..b0fe635b72 100644
--- a/autogpt_platform/frontend/src/app/(platform)/profile/(user)/credits/components/SubscriptionTierSection/useSubscriptionTierSection.ts
+++ b/autogpt_platform/frontend/src/app/(platform)/profile/(user)/credits/components/SubscriptionTierSection/useSubscriptionTierSection.ts
@@ -4,7 +4,6 @@ import {
} from "@/app/api/__generated__/endpoints/credits/credits";
import type { SubscriptionStatusResponse } from "@/app/api/__generated__/models/subscriptionStatusResponse";
import type { SubscriptionTierRequestTier } from "@/app/api/__generated__/models/subscriptionTierRequestTier";
-import { useCallback } from "react";
export type SubscriptionStatus = SubscriptionStatusResponse;
@@ -22,32 +21,29 @@ export function useSubscriptionTierSection() {
const { mutateAsync: doUpdateTier, isPending } = useUpdateSubscriptionTier();
- const changeTier = useCallback(
- async (tier: string): Promise<string | null> => {
- try {
- const successUrl = `${window.location.origin}${window.location.pathname}?subscription=success`;
- const cancelUrl = `${window.location.origin}${window.location.pathname}?subscription=cancelled`;
- const result = await doUpdateTier({
- data: {
- tier: tier as SubscriptionTierRequestTier,
- success_url: successUrl,
- cancel_url: cancelUrl,
- },
- });
- if (result.status === 200 && result.data.url) {
- window.location.href = result.data.url;
- return null;
- }
- await refetch();
+ async function changeTier(tier: string): Promise<string | null> {
+ try {
+ const successUrl = `${window.location.origin}${window.location.pathname}?subscription=success`;
+ const cancelUrl = `${window.location.origin}${window.location.pathname}?subscription=cancelled`;
+ const result = await doUpdateTier({
+ data: {
+ tier: tier as SubscriptionTierRequestTier,
+ success_url: successUrl,
+ cancel_url: cancelUrl,
+ },
+ });
+ if (result.status === 200 && result.data.url) {
+ window.location.href = result.data.url;
return null;
- } catch (e: unknown) {
- const msg =
- e instanceof Error ? e.message : "Failed to change subscription tier";
- return msg;
}
- },
- [doUpdateTier, refetch],
- );
+ await refetch();
+ return null;
+ } catch (e: unknown) {
+ const msg =
+ e instanceof Error ? e.message : "Failed to change subscription tier";
+ return msg;
+ }
+ }
return {
subscription: subscription ?? null,