Skip to content

AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.

dx(backend): test fixture users are written to a fresh database even while their cached lookup is warm (#15371)

Reinier van der Leerd707e1d79b06
diff --git a/autogpt_platform/backend/backend/conftest.py b/autogpt_platform/backend/backend/conftest.py
index 281ed6949a..97fd5ca8fb 100644
--- a/autogpt_platform/backend/backend/conftest.py
+++ b/autogpt_platform/backend/backend/conftest.py
@@ -219,16 +219,19 @@ async def _create_user_with_loop_retry(user_data: dict) -> None:
bound to a now-closed test function loop. The first session-loop DB
call after that surfaces as ``RuntimeError: Event loop is closed``;
the pool re-establishes itself on the retry.
+
+ Uncached on purpose: the cached lookup is shared through Redis for five
+ minutes, so on a fresh database it can return a user without writing the row.
"""
- from backend.data.user import get_or_create_user
+ from backend.data.user import get_or_create_user_with_status
from backend.util.exceptions import DatabaseError
try:
- await get_or_create_user(user_data)
+ await get_or_create_user_with_status(user_data)
except DatabaseError as e:
if "Event loop is closed" not in str(e):
raise
- await get_or_create_user(user_data)
+ await get_or_create_user_with_status(user_data)
@pytest.fixture
diff --git a/autogpt_platform/backend/scripts/test_server_fixture.py b/autogpt_platform/backend/scripts/test_server_fixture.py
index 02bf0b5882..e9967d5f54 100644
--- a/autogpt_platform/backend/scripts/test_server_fixture.py
+++ b/autogpt_platform/backend/scripts/test_server_fixture.py
@@ -1,11 +1,12 @@
import subprocess
import sys
from pathlib import Path
-from unittest.mock import Mock, patch
+from unittest.mock import AsyncMock, Mock, patch
import pytest
from backend import conftest as fixtures
+from backend.util.exceptions import DatabaseError
pytest_plugins = ["pytester"]
@@ -170,3 +171,10 @@ assert gc.get_freeze_count() > 0
],
check=True,
)
+
+
+async def test_a_fixture_user_is_retried_once_through_the_uncached_lookup():
+ create = AsyncMock(side_effect=[DatabaseError("Event loop is closed"), None])
+ with patch("backend.data.user.get_or_create_user_with_status", create):
+ await fixtures._create_user_with_loop_retry({"sub": "user"})
+ assert create.await_count == 2