AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.
fix(platform): reduce Sentry alert spam for expected errors (#11872)
Zamil Majdyd855f79874ae
diff --git a/autogpt_platform/backend/backend/api/features/library/db.py b/autogpt_platform/backend/backend/api/features/library/db.pyindex 18d535d896..872fe66b28 100644--- a/autogpt_platform/backend/backend/api/features/library/db.py+++ b/autogpt_platform/backend/backend/api/features/library/db.py@@ -21,7 +21,7 @@ from backend.data.model import CredentialsMetaInputfrom backend.integrations.creds_manager import IntegrationCredentialsManagerfrom backend.integrations.webhooks.graph_lifecycle_hooks import on_graph_activatefrom backend.util.clients import get_scheduler_client-from backend.util.exceptions import DatabaseError, NotFoundError+from backend.util.exceptions import DatabaseError, InvalidInputError, NotFoundErrorfrom backend.util.json import SafeJsonfrom backend.util.models import Paginationfrom backend.util.settings import Config@@ -64,11 +64,11 @@ async def list_library_agents(if page < 1 or page_size < 1:logger.warning(f"Invalid pagination: page={page}, page_size={page_size}")- raise DatabaseError("Invalid pagination input")+ raise InvalidInputError("Invalid pagination input")if search_term and len(search_term.strip()) > 100:logger.warning(f"Search term too long: {repr(search_term)}")- raise DatabaseError("Search term is too long")+ raise InvalidInputError("Search term is too long")where_clause: prisma.types.LibraryAgentWhereInput = {"userId": user_id,@@ -175,7 +175,7 @@ async def list_favorite_library_agents(if page < 1 or page_size < 1:logger.warning(f"Invalid pagination: page={page}, page_size={page_size}")- raise DatabaseError("Invalid pagination input")+ raise InvalidInputError("Invalid pagination input")where_clause: prisma.types.LibraryAgentWhereInput = {"userId": user_id,diff --git a/autogpt_platform/backend/backend/api/features/library/routes/agents.py b/autogpt_platform/backend/backend/api/features/library/routes/agents.pyindex 38c34dd3b8..fa3d1a0f0c 100644--- a/autogpt_platform/backend/backend/api/features/library/routes/agents.py+++ b/autogpt_platform/backend/backend/api/features/library/routes/agents.py@@ -1,4 +1,3 @@-import loggingfrom typing import Literal, Optionalimport autogpt_libs.auth as autogpt_auth_lib@@ -6,15 +5,11 @@ from fastapi import APIRouter, Body, HTTPException, Query, Security, statusfrom fastapi.responses import Responsefrom prisma.enums import OnboardingStep-import backend.api.features.store.exceptions as store_exceptionsfrom backend.data.onboarding import complete_onboarding_step-from backend.util.exceptions import DatabaseError, NotFoundErrorfrom .. import db as library_dbfrom .. import model as library_model-logger = logging.getLogger(__name__)-router = APIRouter(prefix="/agents",tags=["library", "private"],@@ -26,10 +21,6 @@ router = APIRouter("",summary="List Library Agents",response_model=library_model.LibraryAgentResponse,- responses={- 200: {"description": "List of library agents"},- 500: {"description": "Server error", "content": {"application/json": {}}},- },)async def list_library_agents(user_id: str = Security(autogpt_auth_lib.get_user_id),@@ -53,43 +44,19 @@ async def list_library_agents() -> library_model.LibraryAgentResponse:"""Get all agents in the user's library (both created and saved).-- Args:- user_id: ID of the authenticated user.- search_term: Optional search term to filter agents by name/description.- filter_by: List of filters to apply (favorites, created by user).- sort_by: List of sorting criteria (created date, updated date).- page: Page number to retrieve.- page_size: Number of agents per page.-- Returns:- A LibraryAgentResponse containing agents and pagination metadata.-- Raises:- HTTPException: If a server/database error occurs."""- try:- return await library_db.list_library_agents(- user_id=user_id,- search_term=search_term,- sort_by=sort_by,- page=page,- page_size=page_size,- )- except Exception as e:- logger.error(f"Could not list library agents for user #{user_id}: {e}")- raise HTTPException(- status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,- detail=str(e),- ) from e+ return await library_db.list_library_agents(+ user_id=user_id,+ search_term=search_term,+ sort_by=sort_by,+ page=page,+ page_size=page_size,+ )@router.get("/favorites",summary="List Favorite Library Agents",- responses={- 500: {"description": "Server error", "content": {"application/json": {}}},- },)async def list_favorite_library_agents(user_id: str = Security(autogpt_auth_lib.get_user_id),@@ -106,30 +73,12 @@ async def list_favorite_library_agents() -> library_model.LibraryAgentResponse:"""Get all favorite agents in the user's library.-- Args:- user_id: ID of the authenticated user.- page: Page number to retrieve.- page_size: Number of agents per page.-- Returns:- A LibraryAgentResponse containing favorite agents and pagination metadata.-- Raises:- HTTPException: If a server/database error occurs."""- try:- return await library_db.list_favorite_library_agents(- user_id=user_id,- page=page,- page_size=page_size,- )- except Exception as e:- logger.error(f"Could not list favorite library agents for user #{user_id}: {e}")- raise HTTPException(- status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,- detail=str(e),- ) from e+ return await library_db.list_favorite_library_agents(+ user_id=user_id,+ page=page,+ page_size=page_size,+ )@router.get("/{library_agent_id}", summary="Get Library Agent")@@ -162,10 +111,6 @@ async def get_library_agent_by_graph_id(summary="Get Agent By Store ID",tags=["store", "library"],response_model=library_model.LibraryAgent | None,- responses={- 200: {"description": "Library agent found"},- 404: {"description": "Agent not found"},- },)async def get_library_agent_by_store_listing_version_id(store_listing_version_id: str,@@ -174,32 +119,15 @@ async def get_library_agent_by_store_listing_version_id("""Get Library Agent from Store Listing Version ID."""- try:- return await library_db.get_library_agent_by_store_version_id(- store_listing_version_id, user_id- )- except NotFoundError as e:- raise HTTPException(- status_code=status.HTTP_404_NOT_FOUND,- detail=str(e),- )- except Exception as e:- logger.error(f"Could not fetch library agent from store version ID: {e}")- raise HTTPException(- status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,- detail=str(e),- ) from e+ return await library_db.get_library_agent_by_store_version_id(+ store_listing_version_id, user_id+ )@router.post("",summary="Add Marketplace Agent",status_code=status.HTTP_201_CREATED,- responses={- 201: {"description": "Agent added successfully"},- 404: {"description": "Store listing version not found"},- 500: {"description": "Server error"},- },)async def add_marketplace_agent_to_library(store_listing_version_id: str = Body(embed=True),@@ -210,59 +138,19 @@ async def add_marketplace_agent_to_library() -> library_model.LibraryAgent:"""Add an agent from the marketplace to the user's library.-- Args:- store_listing_version_id: ID of the store listing version to add.- user_id: ID of the authenticated user.-- Returns:- library_model.LibraryAgent: Agent added to the library-- Raises:- HTTPException(404): If the listing version is not found.- HTTPException(500): If a server/database error occurs."""- try:- agent = await library_db.add_store_agent_to_library(- store_listing_version_id=store_listing_version_id,- user_id=user_id,- )- if source != "onboarding":- await complete_onboarding_step(- user_id, OnboardingStep.MARKETPLACE_ADD_AGENT- )- return agent-- except store_exceptions.AgentNotFoundError as e:- logger.warning(- f"Could not find store listing version {store_listing_version_id} "- "to add to library"- )- raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=str(e))- except DatabaseError as e:- logger.error(f"Database error while adding agent to library: {e}", e)- raise HTTPException(- status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,- detail={"message": str(e), "hint": "Inspect DB logs for details."},- ) from e- except Exception as e:- logger.error(f"Unexpected error while adding agent to library: {e}")- raise HTTPException(- status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,- detail={- "message": str(e),- "hint": "Check server logs for more information.",- },- ) from e+ agent = await library_db.add_store_agent_to_library(+ store_listing_version_id=store_listing_version_id,+ user_id=user_id,+ )+ if source != "onboarding":+ await complete_onboarding_step(user_id, OnboardingStep.MARKETPLACE_ADD_AGENT)+ return agent@router.patch("/{library_agent_id}",summary="Update Library Agent",- responses={- 200: {"description": "Agent updated successfully"},- 500: {"description": "Server error"},- },)async def update_library_agent(library_agent_id: str,@@ -271,52 +159,21 @@ async def update_library_agent() -> library_model.LibraryAgent:"""Update the library agent with the given fields.-- Args:- library_agent_id: ID of the library agent to update.- payload: Fields to update (auto_update_version, is_favorite, etc.).- user_id: ID of the authenticated user.-- Raises:- HTTPException(500): If a server/database error occurs."""- try:- return await library_db.update_library_agent(- library_agent_id=library_agent_id,- user_id=user_id,- auto_update_version=payload.auto_update_version,- graph_version=payload.graph_version,- is_favorite=payload.is_favorite,- is_archived=payload.is_archived,- settings=payload.settings,- )- except NotFoundError as e:- raise HTTPException(- status_code=status.HTTP_404_NOT_FOUND,- detail=str(e),- ) from e- except DatabaseError as e:- logger.error(f"Database error while updating library agent: {e}")- raise HTTPException(- status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,- detail={"message": str(e), "hint": "Verify DB connection."},- ) from e- except Exception as e:- logger.error(f"Unexpected error while updating library agent: {e}")- raise HTTPException(- status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,- detail={"message": str(e), "hint": "Check server logs."},- ) from e+ return await library_db.update_library_agent(+ library_agent_id=library_agent_id,+ user_id=user_id,+ auto_update_version=payload.auto_update_version,+ graph_version=payload.graph_version,+ is_favorite=payload.is_favorite,+ is_archived=payload.is_archived,+ settings=payload.settings,+ )@router.delete("/{library_agent_id}",summary="Delete Library Agent",- responses={- 204: {"description": "Agent deleted successfully"},- 404: {"description": "Agent not found"},- 500: {"description": "Server error"},- },)async def delete_library_agent(library_agent_id: str,@@ -324,28 +181,11 @@ async def delete_library_agent() -> Response:"""Soft-delete the specified library agent.-- Args:- library_agent_id: ID of the library agent to delete.- user_id: ID of the authenticated user.-- Returns:- 204 No Content if successful.-- Raises:- HTTPException(404): If the agent does not exist.- HTTPException(500): If a server/database error occurs."""- try:- await library_db.delete_library_agent(- library_agent_id=library_agent_id, user_id=user_id- )- return Response(status_code=status.HTTP_204_NO_CONTENT)- except NotFoundError as e:- raise HTTPException(- status_code=status.HTTP_404_NOT_FOUND,- detail=str(e),- ) from e+ await library_db.delete_library_agent(+ library_agent_id=library_agent_id, user_id=user_id+ )+ return Response(status_code=status.HTTP_204_NO_CONTENT)@router.post("/{library_agent_id}/fork", summary="Fork Library Agent")diff --git a/autogpt_platform/backend/backend/api/features/library/routes_test.py b/autogpt_platform/backend/backend/api/features/library/routes_test.pyindex ca604af760..4d83812891 100644--- a/autogpt_platform/backend/backend/api/features/library/routes_test.py+++ b/autogpt_platform/backend/backend/api/features/library/routes_test.py@@ -118,21 +118,6 @@ async def test_get_library_agents_success()-def test_get_library_agents_error(mocker: pytest_mock.MockFixture, test_user_id: str):- mock_db_call = mocker.patch("backend.api.features.library.db.list_library_agents")- mock_db_call.side_effect = Exception("Test error")-- response = client.get("/agents?search_term=test")- assert response.status_code == 500- mock_db_call.assert_called_once_with(- user_id=test_user_id,- search_term="test",- sort_by=library_model.LibraryAgentSort.UPDATED_AT,- page=1,- page_size=15,- )--@pytest.mark.asyncioasync def test_get_favorite_library_agents_success(mocker: pytest_mock.MockFixture,@@ -190,23 +175,6 @@ async def test_get_favorite_library_agents_success()-def test_get_favorite_library_agents_error(- mocker: pytest_mock.MockFixture, test_user_id: str-):- mock_db_call = mocker.patch(- "backend.api.features.library.db.list_favorite_library_agents"- )- mock_db_call.side_effect = Exception("Test error")-- response = client.get("/agents/favorites")- assert response.status_code == 500- mock_db_call.assert_called_once_with(- user_id=test_user_id,- page=1,- page_size=15,- )--def test_add_agent_to_library_success(mocker: pytest_mock.MockFixture, test_user_id: str):@@ -258,19 +226,3 @@ def test_add_agent_to_library_success(store_listing_version_id="test-version-id", user_id=test_user_id)mock_complete_onboarding.assert_awaited_once()---def test_add_agent_to_library_error(mocker: pytest_mock.MockFixture, test_user_id: str):- mock_db_call = mocker.patch(- "backend.api.features.library.db.add_store_agent_to_library"- )- mock_db_call.side_effect = Exception("Test error")-- response = client.post(- "/agents", json={"store_listing_version_id": "test-version-id"}- )- assert response.status_code == 500- assert "detail" in response.json() # Verify error response structure- mock_db_call.assert_called_once_with(- store_listing_version_id="test-version-id", user_id=test_user_id- )diff --git a/autogpt_platform/backend/backend/api/features/store/embeddings.py b/autogpt_platform/backend/backend/api/features/store/embeddings.pyindex 79a9a4e219..434f2fe2ce 100644--- a/autogpt_platform/backend/backend/api/features/store/embeddings.py+++ b/autogpt_platform/backend/backend/api/features/store/embeddings.py@@ -454,6 +454,7 @@ async def backfill_all_content_types(batch_size: int = 10) -> dict[str, Any]:total_processed = 0total_success = 0total_failed = 0+ all_errors: dict[str, int] = {} # Aggregate errors across all content types# Process content types in explicit orderprocessing_order = [@@ -499,23 +500,12 @@ async def backfill_all_content_types(batch_size: int = 10) -> dict[str, Any]:success = sum(1 for result in results if result is True)failed = len(results) - success- # Aggregate unique errors to avoid Sentry spam+ # Aggregate errors across all content typesif failed > 0:- # Group errors by type and message- error_summary: dict[str, int] = {}for result in results:if isinstance(result, Exception):error_key = f"{type(result).__name__}: {str(result)}"- error_summary[error_key] = error_summary.get(error_key, 0) + 1-- # Log aggregated error summary- error_details = ", ".join(- f"{error} ({count}x)" for error, count in error_summary.items()- )- logger.error(- f"{content_type.value}: {failed}/{len(results)} embeddings failed. "- f"Errors: {error_details}"- )+ all_errors[error_key] = all_errors.get(error_key, 0) + 1results_by_type[content_type.value] = {"processed": len(missing_items),@@ -542,6 +532,13 @@ async def backfill_all_content_types(batch_size: int = 10) -> dict[str, Any]:"error": str(e),}+ # Log aggregated errors once at the end+ if all_errors:+ error_details = ", ".join(+ f"{error} ({count}x)" for error, count in all_errors.items()+ )+ logger.error(f"Embedding backfill errors: {error_details}")+return {"by_type": results_by_type,"totals": {diff --git a/autogpt_platform/backend/backend/util/exceptions.py b/autogpt_platform/backend/backend/util/exceptions.pyindex 6d0192c0e5..ffda783873 100644--- a/autogpt_platform/backend/backend/util/exceptions.py+++ b/autogpt_platform/backend/backend/util/exceptions.py@@ -135,6 +135,12 @@ class GraphValidationError(ValueError):)+class InvalidInputError(ValueError):+ """Raised when user input validation fails (e.g., search term too long)"""++ pass++class DatabaseError(Exception):"""Raised when there is an error interacting with the database"""diff --git a/autogpt_platform/frontend/src/app/api/openapi.json b/autogpt_platform/frontend/src/app/api/openapi.jsonindex d1ecd91702..a6fdded27f 100644--- a/autogpt_platform/frontend/src/app/api/openapi.json+++ b/autogpt_platform/frontend/src/app/api/openapi.json@@ -3339,7 +3339,7 @@"get": {"tags": ["v2", "library", "private"],"summary": "List Library Agents",- "description": "Get all agents in the user's library (both created and saved).\n\nArgs:\n user_id: ID of the authenticated user.\n search_term: Optional search term to filter agents by name/description.\n filter_by: List of filters to apply (favorites, created by user).\n sort_by: List of sorting criteria (created date, updated date).\n page: Page number to retrieve.\n page_size: Number of agents per page.\n\nReturns:\n A LibraryAgentResponse containing agents and pagination metadata.\n\nRaises:\n HTTPException: If a server/database error occurs.",+ "description": "Get all agents in the user's library (both created and saved).","operationId": "getV2List library agents","security": [{ "HTTPBearerJWT": [] }],"parameters": [@@ -3394,7 +3394,7 @@],"responses": {"200": {- "description": "List of library agents",+ "description": "Successful Response","content": {"application/json": {"schema": {@@ -3413,17 +3413,13 @@"schema": { "$ref": "#/components/schemas/HTTPValidationError" }}}- },- "500": {- "description": "Server error",- "content": { "application/json": {} }}}},"post": {"tags": ["v2", "library", "private"],"summary": "Add Marketplace Agent",- "description": "Add an agent from the marketplace to the user's library.\n\nArgs:\n store_listing_version_id: ID of the store listing version to add.\n user_id: ID of the authenticated user.\n\nReturns:\n library_model.LibraryAgent: Agent added to the library\n\nRaises:\n HTTPException(404): If the listing version is not found.\n HTTPException(500): If a server/database error occurs.",+ "description": "Add an agent from the marketplace to the user's library.","operationId": "postV2Add marketplace agent","security": [{ "HTTPBearerJWT": [] }],"requestBody": {@@ -3438,7 +3434,7 @@},"responses": {"201": {- "description": "Agent added successfully",+ "description": "Successful Response","content": {"application/json": {"schema": { "$ref": "#/components/schemas/LibraryAgent" }@@ -3448,7 +3444,6 @@"401": {"$ref": "#/components/responses/HTTP401NotAuthenticatedError"},- "404": { "description": "Store listing version not found" },"422": {"description": "Validation Error","content": {@@ -3456,8 +3451,7 @@"schema": { "$ref": "#/components/schemas/HTTPValidationError" }}}- },- "500": { "description": "Server error" }+ }}}},@@ -3511,7 +3505,7 @@"get": {"tags": ["v2", "library", "private"],"summary": "List Favorite Library Agents",- "description": "Get all favorite agents in the user's library.\n\nArgs:\n user_id: ID of the authenticated user.\n page: Page number to retrieve.\n page_size: Number of agents per page.\n\nReturns:\n A LibraryAgentResponse containing favorite agents and pagination metadata.\n\nRaises:\n HTTPException: If a server/database error occurs.",+ "description": "Get all favorite agents in the user's library.","operationId": "getV2List favorite library agents","security": [{ "HTTPBearerJWT": [] }],"parameters": [@@ -3563,10 +3557,6 @@"schema": { "$ref": "#/components/schemas/HTTPValidationError" }}}- },- "500": {- "description": "Server error",- "content": { "application/json": {} }}}}@@ -3588,7 +3578,7 @@],"responses": {"200": {- "description": "Library agent found",+ "description": "Successful Response","content": {"application/json": {"schema": {@@ -3604,7 +3594,6 @@"401": {"$ref": "#/components/responses/HTTP401NotAuthenticatedError"},- "404": { "description": "Agent not found" },"422": {"description": "Validation Error","content": {@@ -3620,7 +3609,7 @@"delete": {"tags": ["v2", "library", "private"],"summary": "Delete Library Agent",- "description": "Soft-delete the specified library agent.\n\nArgs:\n library_agent_id: ID of the library agent to delete.\n user_id: ID of the authenticated user.\n\nReturns:\n 204 No Content if successful.\n\nRaises:\n HTTPException(404): If the agent does not exist.\n HTTPException(500): If a server/database error occurs.",+ "description": "Soft-delete the specified library agent.","operationId": "deleteV2Delete library agent","security": [{ "HTTPBearerJWT": [] }],"parameters": [@@ -3636,11 +3625,9 @@"description": "Successful Response","content": { "application/json": { "schema": {} } }},- "204": { "description": "Agent deleted successfully" },"401": {"$ref": "#/components/responses/HTTP401NotAuthenticatedError"},- "404": { "description": "Agent not found" },"422": {"description": "Validation Error","content": {@@ -3648,8 +3635,7 @@"schema": { "$ref": "#/components/schemas/HTTPValidationError" }}}- },- "500": { "description": "Server error" }+ }}},"get": {@@ -3690,7 +3676,7 @@"patch": {"tags": ["v2", "library", "private"],"summary": "Update Library Agent",- "description": "Update the library agent with the given fields.\n\nArgs:\n library_agent_id: ID of the library agent to update.\n payload: Fields to update (auto_update_version, is_favorite, etc.).\n user_id: ID of the authenticated user.\n\nRaises:\n HTTPException(500): If a server/database error occurs.",+ "description": "Update the library agent with the given fields.","operationId": "patchV2Update library agent","security": [{ "HTTPBearerJWT": [] }],"parameters": [@@ -3713,7 +3699,7 @@},"responses": {"200": {- "description": "Agent updated successfully",+ "description": "Successful Response","content": {"application/json": {"schema": { "$ref": "#/components/schemas/LibraryAgent" }@@ -3730,8 +3716,7 @@"schema": { "$ref": "#/components/schemas/HTTPValidationError" }}}- },- "500": { "description": "Server error" }+ }}}},