AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.
fix(backend): convert AttributeError to ValueError in _generate_schema (#12714)
Zamil Majdyef477ae4b9ea
diff --git a/autogpt_platform/backend/backend/data/graph.py b/autogpt_platform/backend/backend/data/graph.pyindex 48ccb03051..584a929e13 100644--- a/autogpt_platform/backend/backend/data/graph.py+++ b/autogpt_platform/backend/backend/data/graph.py@@ -333,26 +333,29 @@ class BaseGraph(GraphBaseMeta):except Exception as e:logger.error(f"Invalid {type_class}: {input_default}, {e}")- return {- "type": "object",- "properties": {- p.name: {- **{- k: v- for k, v in p.generate_schema().items()- if k not in ["description", "default"]- },- "secret": p.secret,- # Default value has to be set for advanced fields.- "advanced": p.advanced and p.value is not None,- "title": p.title or p.name,- **({"description": p.description} if p.description else {}),- **({"default": p.value} if p.value is not None else {}),- }- for p in schema_fields- },- "required": [p.name for p in schema_fields if p.value is None],- }+ try:+ return {+ "type": "object",+ "properties": {+ p.name: {+ **{+ k: v+ for k, v in p.generate_schema().items()+ if k not in ["description", "default"]+ },+ "secret": p.secret,+ # Default value has to be set for advanced fields.+ "advanced": p.advanced and p.value is not None,+ "title": p.title or p.name,+ **({"description": p.description} if p.description else {}),+ **({"default": p.value} if p.value is not None else {}),+ }+ for p in schema_fields+ },+ "required": [p.name for p in schema_fields if p.value is None],+ }+ except AttributeError as e:+ raise ValueError(str(e)) from eclass GraphTriggerInfo(BaseModel):diff --git a/autogpt_platform/backend/backend/data/graph_test.py b/autogpt_platform/backend/backend/data/graph_test.pyindex 08d43c4a5a..3c4ad15c2b 100644--- a/autogpt_platform/backend/backend/data/graph_test.py+++ b/autogpt_platform/backend/backend/data/graph_test.py@@ -15,6 +15,7 @@ from backend.blocks.basic import StoreValueBlockfrom backend.blocks.io import AgentInputBlock, AgentOutputBlockfrom backend.data.graph import (Graph,+ GraphModel,Link,Node,get_graph,@@ -1460,3 +1461,21 @@ async def test_validate_graph_execution_permissions_library_wrong_version_deniedmock_is_published.assert_awaited_once_with(graph_id, graph_version)lib_where = mock_lib_prisma.return_value.find_first.call_args.kwargs["where"]assert lib_where["agentGraphVersion"] == graph_version+++# ============================================================================+# Tests for _generate_schema AttributeError → ValueError conversion+# ============================================================================+++def test_generate_schema_raises_value_error_when_name_missing():+ """AgentInputBlock.Input constructed without 'name' should raise ValueError.++ model_construct() skips validation, so the Input object is created without+ a 'name' attribute. The dict comprehension in _generate_schema then hits an+ AttributeError when it accesses p.name. That AttributeError must be caught+ and re-raised as ValueError so the existing 400 handler in rest_api.py fires+ instead of falling through to the 500 catch-all.+ """+ with pytest.raises(ValueError):+ GraphModel._generate_schema((AgentInputBlock.Input, {}))