Skip to content

AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.

fix(frontend): prevent using mock feature flags (#10792)

Ubbef669db4a1029
diff --git a/.github/workflows/platform-frontend-ci.yml b/.github/workflows/platform-frontend-ci.yml
index e9d720a4fb..dc33d3bb5e 100644
--- a/.github/workflows/platform-frontend-ci.yml
+++ b/.github/workflows/platform-frontend-ci.yml
@@ -160,7 +160,7 @@ jobs:
- name: Run docker compose
run: |
- docker compose -f ../docker-compose.yml up -d
+ NEXT_PUBLIC_PW_TEST=true docker compose -f ../docker-compose.yml up -d
env:
DOCKER_BUILDKIT: 1
BUILDX_CACHE_FROM: type=local,src=/tmp/.buildx-cache
diff --git a/autogpt_platform/docker-compose.platform.yml b/autogpt_platform/docker-compose.platform.yml
index c4e9a14e7b..4c09c76209 100644
--- a/autogpt_platform/docker-compose.platform.yml
+++ b/autogpt_platform/docker-compose.platform.yml
@@ -50,7 +50,11 @@ services:
- app-network
restart: on-failure
healthcheck:
- test: ["CMD-SHELL", "poetry run prisma migrate status | grep -q 'No pending migrations' || exit 1"]
+ test:
+ [
+ "CMD-SHELL",
+ "poetry run prisma migrate status | grep -q 'No pending migrations' || exit 1",
+ ]
interval: 30s
timeout: 10s
retries: 3
@@ -284,6 +288,8 @@ services:
context: ../
dockerfile: autogpt_platform/frontend/Dockerfile
target: prod
+ args:
+ NEXT_PUBLIC_PW_TEST: ${NEXT_PUBLIC_PW_TEST:-false}
depends_on:
db:
condition: service_healthy
diff --git a/autogpt_platform/frontend/.env.default b/autogpt_platform/frontend/.env.default
index 175567c5b2..aec40c6a46 100644
--- a/autogpt_platform/frontend/.env.default
+++ b/autogpt_platform/frontend/.env.default
@@ -16,5 +16,4 @@
NEXT_PUBLIC_REACT_QUERY_DEVTOOL=true
NEXT_PUBLIC_GA_MEASUREMENT_ID=G-FH2XK2W4GN
- NEXT_PUBLIC_PW_TEST=true
\ No newline at end of file
diff --git a/autogpt_platform/frontend/Dockerfile b/autogpt_platform/frontend/Dockerfile
index 0b6fe4491b..311b4e4a26 100644
--- a/autogpt_platform/frontend/Dockerfile
+++ b/autogpt_platform/frontend/Dockerfile
@@ -9,13 +9,17 @@ RUN --mount=type=cache,target=/root/.local/share/pnpm pnpm install --frozen-lock
FROM base AS build
COPY autogpt_platform/frontend/ .
+# Allow CI to opt-in to Playwright test build-time flags
+ARG NEXT_PUBLIC_PW_TEST="false"
+ENV NEXT_PUBLIC_PW_TEST=$NEXT_PUBLIC_PW_TEST
RUN if [ -f .env ]; then \
cat .env.default .env > .env.merged && mv .env.merged .env; \
else \
cp .env.default .env; \
fi
RUN pnpm run generate:api
-RUN pnpm build
+# In CI, we want NEXT_PUBLIC_PW_TEST=true during build so Next.js inlines it
+RUN if [ "$NEXT_PUBLIC_PW_TEST" = "true" ]; then NEXT_PUBLIC_PW_TEST=true pnpm build; else pnpm build; fi
# Prod stage - based on NextJS reference Dockerfile https://github.com/vercel/next.js/blob/64271354533ed16da51be5dce85f0dbd15f17517/examples/with-docker/Dockerfile
FROM node:21-alpine AS prod
diff --git a/autogpt_platform/frontend/package.json b/autogpt_platform/frontend/package.json
index 814ce3d9ca..78bdf98083 100644
--- a/autogpt_platform/frontend/package.json
+++ b/autogpt_platform/frontend/package.json
@@ -10,8 +10,8 @@
"lint": "next lint && prettier --check .",
"format": "next lint --fix; prettier --write .",
"types": "tsc --noEmit",
- "test": "next build --turbo && playwright test",
- "test-ui": "next build --turbo && playwright test --ui",
+ "test": "NEXT_PUBLIC_PW_TEST=true next build --turbo && playwright test",
+ "test-ui": "NEXT_PUBLIC_PW_TEST=true next build --turbo && playwright test --ui",
"test:no-build": "playwright test",
"gentests": "playwright codegen http://localhost:3000",
"storybook": "storybook dev -p 6006",
diff --git a/autogpt_platform/frontend/src/services/feature-flags/use-get-flag.ts b/autogpt_platform/frontend/src/services/feature-flags/use-get-flag.ts
index 3fb759c148..bd44c63349 100644
--- a/autogpt_platform/frontend/src/services/feature-flags/use-get-flag.ts
+++ b/autogpt_platform/frontend/src/services/feature-flags/use-get-flag.ts
@@ -1,5 +1,6 @@
"use client";
+import { BehaveAs, getBehaveAs } from "@/lib/utils";
import { useFlags } from "launchdarkly-react-client-sdk";
export enum Flag {
@@ -18,7 +19,7 @@ export type FlagValues = {
[Flag.GRAPH_SEARCH]: boolean;
};
-const isTest = process.env.NEXT_PUBLIC_PW_TEST === "true";
+const isPwMockEnabled = process.env.NEXT_PUBLIC_PW_TEST === "true";
const mockFlags = {
[Flag.BETA_BLOCKS]: [],
@@ -31,9 +32,9 @@ const mockFlags = {
export function useGetFlag<T extends Flag>(flag: T): FlagValues[T] | null {
const currentFlags = useFlags<FlagValues>();
const flagValue = currentFlags[flag];
+ const isCloud = getBehaveAs() === BehaveAs.CLOUD;
- if (isTest) return mockFlags[flag];
- if (!flagValue) return null;
+ if (isPwMockEnabled && !isCloud) return mockFlags[flag];
return flagValue;
}