Skip to content

Your favorite shift management application!

fix(ui): stop shift-menu clicks from reopening the edit dialog (#200)

panteL1bc287e97812
diff --git a/components/day-detail.tsx b/components/day-detail.tsx
index f077d36..4cd889b 100644
--- a/components/day-detail.tsx
+++ b/components/day-detail.tsx
@@ -195,12 +195,20 @@ export function ShiftDetailRow({
<Ellipsis className="size-4" />
</DropdownMenuTrigger>
<DropdownMenuContent align="end">
- <DropdownMenuItem onClick={() => onEdit(shift)}>
+ <DropdownMenuItem
+ onClick={(e) => {
+ e.stopPropagation();
+ onEdit(shift);
+ }}
+ >
<Pencil className="mr-2 size-4" />
{t("shift.edit")}
</DropdownMenuItem>
<DropdownMenuItem
- onClick={() => onDelete(shift)}
+ onClick={(e) => {
+ e.stopPropagation();
+ onDelete(shift);
+ }}
className="text-danger focus:text-danger"
>
<Trash2 className="mr-2 size-4" />