NOW MANAGED ON CODEBERG
Exports: Added rate limits for UI exports
Dan Brown1ff28266787b
diff --git a/app/App/Providers/RouteServiceProvider.php b/app/App/Providers/RouteServiceProvider.phpindex d7c1cb737..97c3e7c77 100644--- a/app/App/Providers/RouteServiceProvider.php+++ b/app/App/Providers/RouteServiceProvider.php@@ -85,5 +85,12 @@ class RouteServiceProvider extends ServiceProviderRateLimiter::for('public', function (Request $request) {return Limit::perMinute(10)->by($request->ip());});++ RateLimiter::for('exports', function (Request $request) {+ $user = user();+ $attempts = $user->isGuest() ? 4 : 10;+ $key = $user->isGuest() ? $request->ip() : $user->id;+ return Limit::perMinute($attempts)->by($key);+ });}}diff --git a/app/Exports/Controllers/BookExportController.php b/app/Exports/Controllers/BookExportController.phpindex 184f7c235..b6b1006bd 100644--- a/app/Exports/Controllers/BookExportController.php+++ b/app/Exports/Controllers/BookExportController.php@@ -16,6 +16,7 @@ class BookExportController extends Controllerprotected ExportFormatter $exportFormatter,) {$this->middleware('can:content-export');+ $this->middleware('throttle:exports');}/**diff --git a/app/Exports/Controllers/ChapterExportController.php b/app/Exports/Controllers/ChapterExportController.phpindex 4748ca6a8..de2385bb1 100644--- a/app/Exports/Controllers/ChapterExportController.php+++ b/app/Exports/Controllers/ChapterExportController.php@@ -16,6 +16,7 @@ class ChapterExportController extends Controllerprotected ExportFormatter $exportFormatter,) {$this->middleware('can:content-export');+ $this->middleware('throttle:exports');}/**diff --git a/app/Exports/Controllers/PageExportController.php b/app/Exports/Controllers/PageExportController.phpindex 203495fe9..d7145411e 100644--- a/app/Exports/Controllers/PageExportController.php+++ b/app/Exports/Controllers/PageExportController.php@@ -17,6 +17,7 @@ class PageExportController extends Controllerprotected ExportFormatter $exportFormatter,) {$this->middleware('can:content-export');+ $this->middleware('throttle:exports');}/**diff --git a/tests/Exports/ZipExportTest.php b/tests/Exports/ZipExportTest.phpindex 0e17bc0e0..1434c013f 100644--- a/tests/Exports/ZipExportTest.php+++ b/tests/Exports/ZipExportTest.php@@ -423,6 +423,28 @@ class ZipExportTest extends TestCase$this->assertStringContainsString("[Link to chapter]([[bsexport:chapter:{$chapter->id}]])", $pageData['markdown']);}+ public function test_exports_rate_limited_low_for_guest_viewers()+ {+ $this->setSettings(['app-public' => 'true']);++ $page = $this->entities->page();+ for ($i = 0; $i < 4; $i++) {+ $this->get($page->getUrl("/export/zip"))->assertOk();+ }+ $this->get($page->getUrl("/export/zip"))->assertStatus(429);+ }++ public function test_exports_rate_limited_higher_for_logged_in_viewers()+ {+ $this->asAdmin();++ $page = $this->entities->page();+ for ($i = 0; $i < 10; $i++) {+ $this->get($page->getUrl("/export/zip"))->assertOk();+ }+ $this->get($page->getUrl("/export/zip"))->assertStatus(429);+ }+protected function extractZipResponse(TestResponse $response): ZipResultData{$zipData = $response->streamedContent();