NOW MANAGED ON CODEBERG
Page nav: Fixed nbsp being represented as nothing
Dan Brown77f125208ed2
diff --git a/app/Entities/Tools/PageContent.php b/app/Entities/Tools/PageContent.phpindex 4f68b828f..d2f5de65c 100644--- a/app/Entities/Tools/PageContent.php+++ b/app/Entities/Tools/PageContent.php@@ -379,7 +379,7 @@ class PageContentprotected function headerNodesToLevelList(DOMNodeList $nodeList): array{$tree = collect($nodeList)->map(function (DOMElement $header) {- $text = trim(str_replace("\xc2\xa0", '', $header->nodeValue));+ $text = trim(str_replace("\xc2\xa0", ' ', $header->nodeValue));$text = mb_substr($text, 0, 100);return [diff --git a/tests/Entity/PageContentTest.php b/tests/Entity/PageContentTest.phpindex 28897c14d..23a38b573 100644--- a/tests/Entity/PageContentTest.php+++ b/tests/Entity/PageContentTest.php@@ -469,6 +469,20 @@ class PageContentTest extends TestCase], $navMap[2]);}+ public function test_get_page_nav_respects_non_breaking_spaces()+ {+ $content = '<h1 id="testa">Hello There</h1>';+ $pageContent = new PageContent(new Page(['html' => $content]));+ $navMap = $pageContent->getNavigation($content);++ $this->assertEquals([+ 'nodeName' => 'h1',+ 'link' => '#testa',+ 'text' => 'Hello There',+ 'level' => 1,+ ], $navMap[0]);+ }+public function test_page_text_decodes_html_entities(){$page = $this->entities->page();