Skip to content

NOW MANAGED ON CODEBERG

Perms: Removed entity perm regen on general update

Dan Brownadd091305c0e
diff --git a/app/Entities/Repos/BaseRepo.php b/app/Entities/Repos/BaseRepo.php
index 151d5b055..ac5a44e67 100644
--- a/app/Entities/Repos/BaseRepo.php
+++ b/app/Entities/Repos/BaseRepo.php
@@ -77,7 +77,6 @@ class BaseRepo
$entity->touch();
}
- $entity->rebuildPermissions();
$entity->indexForSearch();
$this->referenceStore->updateForEntity($entity);
@@ -139,7 +138,7 @@ class BaseRepo
/**
* Sort the parent of the given entity, if any auto sort actions are set for it.
- * Typical ran during create/update/insert events.
+ * Typically ran during create/update/insert events.
*/
public function sortParent(Entity $entity): void
{
diff --git a/app/Entities/Repos/PageRepo.php b/app/Entities/Repos/PageRepo.php
index c3be6d826..f081b33dc 100644
--- a/app/Entities/Repos/PageRepo.php
+++ b/app/Entities/Repos/PageRepo.php
@@ -77,6 +77,7 @@ class PageRepo
$draft->priority = $this->getNewPriority($draft);
$this->updateTemplateStatusAndContentFromInput($draft, $input);
$this->baseRepo->update($draft, $input);
+ $draft->rebuildPermissions();
$summary = trim($input['summary'] ?? '') ?: trans('entities.pages_initial_revision');
$this->revisionRepo->storeNewForPage($draft, $summary);
@@ -91,7 +92,7 @@ class PageRepo
/**
* Directly update the content for the given page from the provided input.
* Used for direct content access in a way that performs required changes
- * (Search index & reference regen) without performing an official update.
+ * (Search index and reference regen) without performing an official update.
*/
public function setContentFromInput(Page $page, array $input): void
{
diff --git a/app/Sorting/BookSorter.php b/app/Sorting/BookSorter.php
index 6710f070a..cf41a6a94 100644
--- a/app/Sorting/BookSorter.php
+++ b/app/Sorting/BookSorter.php
@@ -2,7 +2,6 @@
namespace BookStack\Sorting;
-use BookStack\App\Model;
use BookStack\Entities\Models\Book;
use BookStack\Entities\Models\BookChild;
use BookStack\Entities\Models\Chapter;