Skip to content

Free fork of NotProton: Windows Steam games in Mac Steam, on CodeWeavers' Wine and Apple's Game Porting Toolkit

test: fallback with an uncatalogued string; count alerts, not osascript

raymondchins5e883636610b
diff --git a/app/Tests/BridgeplayAppTests/LocalizationTests.swift b/app/Tests/BridgeplayAppTests/LocalizationTests.swift
index 68b8ca6..0b3ae91 100644
--- a/app/Tests/BridgeplayAppTests/LocalizationTests.swift
+++ b/app/Tests/BridgeplayAppTests/LocalizationTests.swift
@@ -32,12 +32,14 @@ struct LocalizationTests {
== "Aperto Wine Configuration in Zuma Deluxe.")
}
- @Test("A string not yet translated into one language shows English there")
- func pendingTranslationFallsBack() throws {
+ // l10ncheck keeps every catalogued string translated, so the fallback is shown with a
+ // string the catalog does not have.
+ @Test("A string without a translation shows English")
+ func missingTranslationFallsBack() throws {
let zh = try #require(chinese)
let it = try #require(italian)
- #expect(String(localized: "The trial version is not supported.", bundle: zh)
- == "The trial version is not supported.")
+ #expect(String(localized: "Not in the string catalog", bundle: zh) == "Not in the string catalog")
+ #expect(String(localized: "The trial version is not supported.", bundle: zh) == "不支持试用版。")
#expect(String(localized: "The trial version is not supported.", bundle: it)
== "La versione di prova non è supportata.")
}
diff --git a/app/Tests/BridgeplayAppTests/PrefixToolsTests.swift b/app/Tests/BridgeplayAppTests/PrefixToolsTests.swift
index 54cfbbd..b70f8c0 100644
--- a/app/Tests/BridgeplayAppTests/PrefixToolsTests.swift
+++ b/app/Tests/BridgeplayAppTests/PrefixToolsTests.swift
@@ -411,7 +411,8 @@ struct PrefixToolsTests {
#expect(helper.upperBound == gate.lowerBound)
#expect(gate.upperBound < alert.lowerBound)
- #expect(source.ranges(of: "osascript").count == 1, "an alert bypasses show_alert")
+ // The first-launch notice uses osascript too, but as a notification, not an alert.
+ #expect(source.ranges(of: "display alert").count == 1, "an alert bypasses show_alert")
let calls = source.ranges(of: " show_alert \"")
#expect(!calls.isEmpty)