Skip to content

Free fork of NotProton: Windows Steam games in Mac Steam, on CodeWeavers' Wine and Apple's Game Porting Toolkit

Skip deprecated signatures in the fallback check, fix the match_offset comment

NotProtonNotc09e0c441151
diff --git a/dylib/resolver/sigdb.h b/dylib/resolver/sigdb.h
index d9a2c3b..f94a687 100644
--- a/dylib/resolver/sigdb.h
+++ b/dylib/resolver/sigdb.h
@@ -14,7 +14,7 @@ typedef struct {
char aob_hex[4096];
uintptr_t func_addr_this_build;
int deprecated;
- int32_t match_offset; // signed delta from the pattern hit to the entry point
+ int32_t match_offset; // site = hit - match_offset; the site is not always an entry
np_anchor_t anchor;
} np_sig_entry_t;
diff --git a/dylib/tests/anchorcheck.c b/dylib/tests/anchorcheck.c
index 305e33c..e7a44c7 100644
--- a/dylib/tests/anchorcheck.c
+++ b/dylib/tests/anchorcheck.c
@@ -278,7 +278,7 @@ static int check_aob_fallback(const char *path) {
for (int i = 0; i < db.sig_count; i++) {
np_sig_entry_t *sig = &db.signatures[i];
if (strcmp(sig->module, g_images[m].module) != 0) continue;
- if (!sig->aob_hex[0] || !sig->func_addr_this_build) continue;
+ if (sig->deprecated || !sig->aob_hex[0] || !sig->func_addr_this_build) continue;
uintptr_t got = np_lookup_address(&res, sig->name);
uintptr_t want = sig->func_addr_this_build + (uintptr_t)g_images[m].slide;