Skip to content

"CLI-Anything: Making ALL Software Agent-Native" -- CLI-Hub: https://clianything.cc/

Python

fix: require an anchor for block insert

hito4a06d2046e85
diff --git a/siyuan/agent-harness/cli_anything/siyuan/siyuan_cli.py b/siyuan/agent-harness/cli_anything/siyuan/siyuan_cli.py
index 7f84577a8..106944c59 100644
--- a/siyuan/agent-harness/cli_anything/siyuan/siyuan_cli.py
+++ b/siyuan/agent-harness/cli_anything/siyuan/siyuan_cli.py
@@ -285,7 +285,10 @@ def _handle_repl_command(skin: Any, cmd: str) -> None:
skin.error("Usage: block <insert|prepend|append|update|delete|get|child>")
return
sub = parts[1]
- if sub == "insert" and len(parts) >= 4:
+ if sub == "insert":
+ if len(parts) < 4:
+ skin.error("Usage: block insert <parent_id> <data>")
+ return
result = client.insert_block("markdown", parts[3], parent_id=parts[2])
if json_mode:
click.echo(json.dumps(result, ensure_ascii=False))
@@ -522,13 +525,14 @@ def block():
@click.argument("data")
@click.option("--previous", default="", help="Previous block ID")
@click.option("--parent", default="", help="Parent block ID")
[email protected]("--next", "next_", default="", help="Next block ID")
@click.option("--data-type", default="markdown", help="Data type (markdown/dom)")
@click.pass_obj
-def block_insert(ctx: SiYuanContext, data: str, previous: str, parent: str, data_type: str):
+def block_insert(ctx: SiYuanContext, data: str, previous: str, parent: str, next_: str, data_type: str):
"""Insert a block."""
- if not parent and not previous:
- raise click.UsageError("Either --parent or --previous is required for block insert")
- result = ctx.client.insert_block(data_type, data, parent_id=parent, previous_id=previous)
+ if not parent and not previous and not next_:
+ raise click.UsageError("An anchor is required: --parent, --previous, or --next")
+ result = ctx.client.insert_block(data_type, data, parent_id=parent, previous_id=previous, next_id=next_)
if ctx.json_output:
click.echo(json.dumps(result, ensure_ascii=False))
else:
diff --git a/siyuan/agent-harness/cli_anything/siyuan/tests/test_cli_commands.py b/siyuan/agent-harness/cli_anything/siyuan/tests/test_cli_commands.py
index 65aa748c2..6452ece99 100644
--- a/siyuan/agent-harness/cli_anything/siyuan/tests/test_cli_commands.py
+++ b/siyuan/agent-harness/cli_anything/siyuan/tests/test_cli_commands.py
@@ -252,6 +252,62 @@ class TestStatusCommand:
assert "Connected" in result.output or "connected" in result.output.lower()
+# ── Block insert command ────────────────────────────────────────────────
+
+
+class TestBlockInsertCommand:
+ def test_block_insert_with_parent(self, runner, mock_ctx):
+ """block insert with --parent succeeds."""
+ mock_ctx.client.insert_block.return_value = [{"id": "new-block"}]
+ with patch("cli_anything.siyuan.siyuan_cli.SiYuanContext", return_value=mock_ctx):
+ result = runner.invoke(cli, ["block", "insert", "hello", "--parent", "pid"])
+ assert result.exit_code == 0
+ assert "Block inserted" in result.output
+ mock_ctx.client.insert_block.assert_called_once_with(
+ "markdown", "hello", parent_id="pid", previous_id="", next_id=""
+ )
+
+ def test_block_insert_with_previous(self, runner, mock_ctx):
+ """block insert with --previous succeeds."""
+ mock_ctx.client.insert_block.return_value = [{"id": "new-block"}]
+ with patch("cli_anything.siyuan.siyuan_cli.SiYuanContext", return_value=mock_ctx):
+ result = runner.invoke(cli, ["block", "insert", "hello", "--previous", "prev"])
+ assert result.exit_code == 0
+ assert "Block inserted" in result.output
+ mock_ctx.client.insert_block.assert_called_once_with(
+ "markdown", "hello", parent_id="", previous_id="prev", next_id=""
+ )
+
+ def test_block_insert_with_next(self, runner, mock_ctx):
+ """block insert with --next succeeds."""
+ mock_ctx.client.insert_block.return_value = [{"id": "new-block"}]
+ with patch("cli_anything.siyuan.siyuan_cli.SiYuanContext", return_value=mock_ctx):
+ result = runner.invoke(cli, ["block", "insert", "hello", "--next", "nid"])
+ assert result.exit_code == 0
+ assert "Block inserted" in result.output
+ mock_ctx.client.insert_block.assert_called_once_with(
+ "markdown", "hello", parent_id="", previous_id="", next_id="nid"
+ )
+
+ def test_block_insert_without_anchor_errors(self, runner, mock_ctx):
+ """block insert without any anchor raises UsageError."""
+ mock_ctx.client.insert_block.return_value = [{"id": "new-block"}]
+ with patch("cli_anything.siyuan.siyuan_cli.SiYuanContext", return_value=mock_ctx):
+ result = runner.invoke(cli, ["block", "insert", "hello"])
+ assert result.exit_code == 2
+ assert "anchor" in result.output.lower() or "Error" in result.output
+
+ def test_block_insert_json_output(self, runner, mock_ctx):
+ """--json block insert returns raw data."""
+ mock_ctx.json_output = True
+ mock_ctx.client.insert_block.return_value = [{"id": "new-block"}]
+ with patch("cli_anything.siyuan.siyuan_cli.SiYuanContext", return_value=mock_ctx):
+ result = runner.invoke(cli, ["--json", "block", "insert", "hello", "--parent", "pid"])
+ assert result.exit_code == 0
+ data = json.loads(result.output)
+ assert data[0]["id"] == "new-block"
+
+
# ── Doc get command ────────────────────────────────────────────────────