Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

ci(verify): upload crash reports when fixture prep crashes and tolerate find errors

Richie McIlroy058056743858
diff --git a/.github/workflows/engine-verify-os.yml b/.github/workflows/engine-verify-os.yml
index bedfc01c2..a6cd1398c 100644
--- a/.github/workflows/engine-verify-os.yml
+++ b/.github/workflows/engine-verify-os.yml
@@ -225,6 +225,7 @@ jobs:
"$CAP_VERIFY_REPORT_DIR" >> "$GITHUB_STEP_SUMMARY"
- name: Collect macOS crash reports
+ id: crash-reports
if: failure() && inputs.platform == 'macos'
continue-on-error: true
shell: bash
@@ -232,15 +233,18 @@ jobs:
dest="$RUNNER_TEMP/verify-report/crash-reports"
for dir in "$HOME/Library/Logs/DiagnosticReports" /Library/Logs/DiagnosticReports; do
[[ -d "$dir" ]] || continue
- find "$dir" -type f \( -name '*.ips' -o -name '*.crash' \) -newer "$RUNNER_TEMP/crash-reports-since" -print0 2>/dev/null |
+ { find "$dir" -type f \( -name '*.ips' -o -name '*.crash' \) -newer "$RUNNER_TEMP/crash-reports-since" -print0 2>/dev/null || true; } |
while IFS= read -r -d '' report; do
mkdir -p "$dest"
cp "$report" "$dest/" && echo "collected $report" || echo "could not copy $report"
done
done
+ if [[ -n "$(ls -A "$dest" 2>/dev/null)" ]]; then
+ echo "collected=true" >> "$GITHUB_OUTPUT"
+ fi
- name: Upload report
- if: always() && steps.test.outcome != 'skipped'
+ if: always() && (steps.test.outcome != 'skipped' || steps.crash-reports.outputs.collected == 'true')
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: verify-report-${{ inputs.platform }}-${{ inputs.tier }}-${{ matrix.shard }}