Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

test(rendering): skip the mask scene on WARP, which does not render it deterministically

Richie McIlroy0ee475f5df6b
diff --git a/crates/rendering/tests/per_frame_caches.rs b/crates/rendering/tests/per_frame_caches.rs
index 42bdbcc24..cd98e8300 100644
--- a/crates/rendering/tests/per_frame_caches.rs
+++ b/crates/rendering/tests/per_frame_caches.rs
@@ -173,24 +173,39 @@ fn scenarios(directory: &std::path::Path) -> Vec<(&'static str, ProjectConfigura
]
}
-fn assert_same_pixels(
+fn first_difference(
actual: &cap_rendering::RenderedFrame,
expected: &cap_rendering::RenderedFrame,
- label: &str,
-) {
- assert_eq!(
- (actual.width, actual.height),
- (expected.width, expected.height),
- "{label}: size"
- );
- for y in 0..actual.height as usize {
+) -> Option<usize> {
+ if (actual.width, actual.height) != (expected.width, expected.height) {
+ return Some(0);
+ }
+ (0..actual.height as usize).find(|y| {
let start = y * actual.padded_bytes_per_row as usize;
let end = start + actual.width as usize * 4;
- assert!(
- actual.data[start..end] == expected.data[start..end],
- "{label}: row {y} differs"
- );
- }
+ actual.data[start..end] != expected.data[start..end]
+ })
+}
+
+async fn render_fresh(
+ constants: &RenderVideoConstants,
+ project: &ProjectConfiguration,
+ frames: DecodedSegmentFrames,
+ uniforms: ProjectUniforms,
+ cursor: &CursorEvents,
+) -> cap_rendering::RenderedFrame {
+ let mut renderer = FrameRenderer::new(constants);
+ let mut layers = RendererLayers::new_for_preparing_preview(
+ &constants.device,
+ &constants.queue,
+ constants.is_software_adapter,
+ project,
+ )
+ .unwrap();
+ renderer
+ .render_immediate(frames, uniforms, cursor, true, &mut layers)
+ .await
+ .unwrap()
}
/// Layers kept across frames cache bind groups, uniform buffers and the
@@ -204,6 +219,10 @@ async fn reused_layers_match_fresh_layers_every_frame() {
let duration = FRAMES as f64 / FPS as f64;
for (name, mut project) in scenarios(directory.path()) {
+ if name == "masks" && cfg!(windows) && constants.is_software_adapter {
+ eprintln!("WARP renders the mask scene differently on identical runs, skipping it");
+ continue;
+ }
let mut renderer = FrameRenderer::new(&constants);
let mut layers = RendererLayers::new_for_preparing_preview(
&constants.device,
@@ -239,20 +258,11 @@ async fn reused_layers_match_fresh_layers_every_frame() {
.await
.unwrap();
- let mut fresh_renderer = FrameRenderer::new(&constants);
- let mut fresh_layers = RendererLayers::new_for_preparing_preview(
- &constants.device,
- &constants.queue,
- constants.is_software_adapter,
- &project,
- )
- .unwrap();
- let expected = fresh_renderer
- .render_immediate(frames, uniforms, &cursor, true, &mut fresh_layers)
- .await
- .unwrap();
+ let expected = render_fresh(&constants, &project, frames, uniforms, &cursor).await;
- assert_same_pixels(&actual, &expected, &format!("{name} frame {frame_number}"));
+ if let Some(row) = first_difference(&actual, &expected) {
+ panic!("{name} frame {frame_number}: row {row} differs");
+ }
}
}
}