Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

Merge commit 'fccb031ac58d77bf66daf31a0bbe751533f16601' into perf/mf-pipelined-readback

Marcos Daniel Rivera Gonzalez1abc92589ac1
diff --cc scripts/test-capbench.py
index b9b3c8fe6,2c97965c9..0eedaabf9
--- a/scripts/test-capbench.py
+++ b/scripts/test-capbench.py
@@@ -166,15 -166,15 +166,24 @@@ class CapbenchTests(unittest.TestCase)
self.assertEqual(metrics["frames"], 100.0)
self.assertAlmostEqual(metrics["steady_fps"], 50.0)
+ def test_export_problem_rejects_broken_exports(self):
+ good = {"out_frames": 1850.0, "out_width": 1664.0, "out_height": 1080.0}
+ self.assertIsNone(capbench.export_problem(good, 1850.0, "1920x1080"))
+ self.assertIsNotNone(capbench.export_problem({}, 1850.0, "1920x1080"))
+ self.assertIsNotNone(capbench.export_problem({**good, "out_frames": 0.0}, None, "1920x1080"))
+ self.assertIsNotNone(capbench.export_problem({**good, "out_frames": 1849.0}, 1850.0, "1920x1080"))
+ self.assertIsNotNone(capbench.export_problem({**good, "out_width": 0.0}, 1850.0, "1920x1080"))
+ self.assertIsNotNone(capbench.export_problem({**good, "out_height": 2160.0}, 1850.0, "1920x1080"))
+
+ def test_exports_ffprobe_cannot_read_are_invalid(self):
+ if not capbench.shutil.which("ffprobe"):
+ self.skipTest("ffprobe is not on PATH")
+ post = capbench.BENCHES["export-1080p60"]["post"]
+ with tempfile.TemporaryDirectory() as tmp:
+ (Path(tmp) / "export.mp4").write_bytes(b"not an mp4")
+ with self.assertRaisesRegex(capbench.InvalidRun, "ffprobe"):
+ post(None, Path(tmp), {"frames": 100.0, "wall_s": 2.0})
+
def test_compare_flags_only_separated_changes(self):
def results(values):
return {"benches": {"b": {"runs": [{"wall_s": v} for v in values], "better": {"wall_s": "lower"}}}}