Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

chore(comments): clarify comments to be clearer about what I did

BestCodes1ae349647390
diff --git a/crates/rendering/src/shaders/yuv420p_to_rgba.wgsl b/crates/rendering/src/shaders/yuv420p_to_rgba.wgsl
index 65f746ab7..5cb3fe842 100644
--- a/crates/rendering/src/shaders/yuv420p_to_rgba.wgsl
+++ b/crates/rendering/src/shaders/yuv420p_to_rgba.wgsl
@@ -3,7 +3,6 @@
@group(0) @binding(2) var v_plane: texture_2d<f32>;
@group(0) @binding(3) var output: texture_storage_2d<rgba8unorm, write>;
-// One invocation per pixel.
@compute @workgroup_size(8, 8)
fn main(@builtin(global_invocation_id) global_id: vec3<u32>) {
let coords = global_id.xy;
diff --git a/crates/rendering/src/yuv_converter.rs b/crates/rendering/src/yuv_converter.rs
index 167991374..f0e7fe848 100644
--- a/crates/rendering/src/yuv_converter.rs
+++ b/crates/rendering/src/yuv_converter.rs
@@ -107,7 +107,7 @@ const INITIAL_TEXTURE_HEIGHT: u32 = 1080;
const TEXTURE_SIZE_PADDING: u32 = 64;
-// The 2x2 block kernel only pays off on Linux; on Apple GPUs it measured slower than one invocation per pixel.
+// The 2x2 block kernel was only measured as a win on Linux; Apple GPUs were slower and Windows is untested.
#[cfg(target_os = "linux")]
const YUV420P_ENTRY_POINT: &str = "main_block";
#[cfg(target_os = "linux")]