Open source Loom alternative. Beautiful, shareable screen recordings.
Rust appcapcossloommacnextjsnextjs15open-sourceossreactrecordrustscreen-capturescreen-recorderscreenshotsolidjstauritauri-apptypescriptvite
fix(media-server): ignore a source track's creation_time in the recording packet proof
Richie McIlroy20f76782ca2b
diff --git a/apps/media-server/src/__tests__/lib/recording-verification.integration.test.ts b/apps/media-server/src/__tests__/lib/recording-verification.integration.test.tsindex b1f11f815..d30f14b0d 100644--- a/apps/media-server/src/__tests__/lib/recording-verification.integration.test.ts+++ b/apps/media-server/src/__tests__/lib/recording-verification.integration.test.ts@@ -607,6 +607,34 @@ describe("encoded recording preservation", () => {expect(verified.audio).toEqual(source.audio);expect(verified.video).toEqual(source.video);});+ test("preserves a recording whose source track carries a creation time", async () => {+ const input = join(directory, "creation-time-source.mp4");+ const output = join(directory, "creation-time-remux.mp4");+ await run([+ "ffmpeg",+ "-v",+ "error",+ "-i",+ silent,+ "-map",+ "0",+ "-c",+ "copy",+ "-video_track_timescale",+ "600",+ "-movflags",+ "frag_keyframe+empty_moov+default_base_moof",+ "-metadata",+ "creation_time=2026-09-17T10:29:10.000000Z",+ input,+ ]);+ await muxMediaTracksToMp4(input, input, output);+ const verified = await verifyRemuxedRecording(input, input, output, {+ requireAudio: true,+ });+ expect(verified.sourcePreserved).toBe(true);+ expect(verified.integrity).toBeUndefined();+ });test("refuses identical corrupt packets rather than treating preservation as decodability", async () => {await expect(verifyRemuxedRecording(corruptTail, corruptTail, corruptTail, {diff --git a/apps/media-server/src/lib/recording-packet-proof.ts b/apps/media-server/src/lib/recording-packet-proof.tsindex 0bfb8e67b..b933b7f11 100644--- a/apps/media-server/src/lib/recording-packet-proof.ts+++ b/apps/media-server/src/lib/recording-packet-proof.ts@@ -424,9 +424,17 @@ async function readTrack(!/^SHA256:[a-f0-9]{64}$/.test(stream.extradata_hash))throw new Error("Recording codec configuration is incomplete");- const { index, time_base: base, start_pts: startPts, ...rest } = stream;+ const { index, time_base: base, start_pts: startPts, tags, ...rest } = stream;+ // Remuxing a fragmented source into a regular MP4 drops its track creation_time, which is+ // container metadata rather than anything in the encoded stream.+ const { creation_time: _creationTime, ...keptTags } =+ tags && typeof tags === "object" ? (tags as Record<string, unknown>) : {};const start = time(String(startPts), base);- const configuration = { ...rest, start };+ const configuration = {+ ...rest,+ ...(Object.keys(keptTags).length > 0 ? { tags: keptTags } : {}),+ start,+ };const [startNumerator, startDenominator] = start.split("/").map(Number);const startTime = startNumerator / startDenominator;if (!Number.isFinite(startTime))