Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

fix(web): restore browser media conversions

Akshar Patel36e9134cc962
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index c6b940113..800af8130 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -126,6 +126,7 @@ jobs:
__tests__/unit/homepage-demo-accessibility.test.ts
__tests__/unit/linkified-text.test.ts
__tests__/unit/loom-import-ui.test.ts
+ __tests__/unit/media-format-converter.test.ts
__tests__/unit/media-player-store-refs.test.ts
__tests__/unit/playback-store.test.ts
__tests__/unit/seo-demo-videos.test.ts
diff --git a/apps/web/__tests__/fixtures/converter.mov b/apps/web/__tests__/fixtures/converter.mov
new file mode 100644
index 000000000..98a83cabd
Binary files /dev/null and b/apps/web/__tests__/fixtures/converter.mov differ
diff --git a/apps/web/__tests__/unit/media-format-converter.test.ts b/apps/web/__tests__/unit/media-format-converter.test.ts
new file mode 100644
index 000000000..720d504e9
--- /dev/null
+++ b/apps/web/__tests__/unit/media-format-converter.test.ts
@@ -0,0 +1,100 @@
+// @vitest-environment jsdom
+
+import { Blob, File } from "node:buffer";
+import { readFile } from "node:fs/promises";
+import { join } from "node:path";
+import { parseMedia } from "@remotion/media-parser";
+import {
+ type ButtonHTMLAttributes,
+ createElement,
+ type PropsWithChildren,
+} from "react";
+import { createRoot, type Root } from "react-dom/client";
+import { afterEach, beforeEach, expect, it, vi } from "vitest";
+import { MediaFormatConverter } from "@/components/tools/MediaFormatConverter";
+
+vi.mock("@cap/ui", () => ({
+ Button: (props: ButtonHTMLAttributes<HTMLButtonElement>) =>
+ createElement("button", { ...props, type: "button" }),
+}));
+vi.mock("next/link", () => ({
+ default: ({ children }: PropsWithChildren) => children,
+}));
+vi.mock("next/navigation", () => ({
+ usePathname: () => "/tools/convert/mov-to-mp4",
+ useRouter: () => ({ push: vi.fn() }),
+}));
+vi.mock("@/app/utils/analytics", () => ({ trackEvent: vi.fn() }));
+
+let root: Root;
+let container: HTMLDivElement;
+let output: Parameters<typeof URL.createObjectURL>[0] | undefined;
+let originalCreate: typeof URL.createObjectURL;
+let originalRevoke: typeof URL.revokeObjectURL;
+
+beforeEach(() => {
+ vi.stubGlobal("IS_REACT_ACT_ENVIRONMENT", false);
+ vi.stubGlobal("Blob", Blob);
+ vi.stubGlobal("File", File);
+ vi.stubGlobal("VideoDecoder", class {});
+ vi.stubGlobal("AudioDecoder", class {});
+ vi.stubGlobal("MediaRecorder", { isTypeSupported: () => false });
+ vi.spyOn(console, "log").mockImplementation(() => {});
+ output = undefined;
+ originalCreate = URL.createObjectURL;
+ originalRevoke = URL.revokeObjectURL;
+ URL.createObjectURL = (blob) => {
+ output = blob;
+ return "blob:converted";
+ };
+ URL.revokeObjectURL = vi.fn();
+ container = document.createElement("div");
+ document.body.append(container);
+ root = createRoot(container);
+});
+
+afterEach(() => {
+ root.unmount();
+ container.remove();
+ URL.createObjectURL = originalCreate;
+ URL.revokeObjectURL = originalRevoke;
+ vi.unstubAllGlobals();
+});
+
+it("converts a MOV to a downloadable MP4 using Remotion", async () => {
+ const bytes = await readFile(join(__dirname, "../fixtures/converter.mov"));
+ root.render(
+ createElement(MediaFormatConverter, {
+ initialConversionPath: "mov-to-mp4",
+ }),
+ );
+ await vi.waitFor(() =>
+ expect(container.querySelector("input[type=file]")).not.toBeNull(),
+ );
+ const input = container.querySelector("input[type=file]") as HTMLInputElement;
+ Object.defineProperty(input, "files", {
+ value: [new File([bytes], "clip.mov", { type: "video/quicktime" })],
+ });
+ input.dispatchEvent(new Event("change", { bubbles: true }));
+ await vi.waitFor(() => expect(container.textContent).toContain("clip.mov"));
+ const convert = Array.from(container.querySelectorAll("button")).find(
+ (button) => button.textContent === "Convert to MP4",
+ );
+ expect(convert).toBeDefined();
+ convert?.click();
+
+ await vi.waitFor(() =>
+ expect(container.textContent).toContain("Conversion complete!"),
+ );
+ if (!(output instanceof globalThis.Blob)) {
+ throw new Error("No converted media was saved");
+ }
+ expect(output.type).toBe("video/mp4");
+ const metadata = await parseMedia({
+ src: output,
+ fields: { videoCodec: true, durationInSeconds: true },
+ });
+ expect(metadata.videoCodec).toBe("h264");
+ expect(metadata.durationInSeconds).toBeGreaterThan(0);
+ expect(container.textContent).toContain("Download MP4");
+});
diff --git a/apps/web/components/tools/MediaFormatConverter.tsx b/apps/web/components/tools/MediaFormatConverter.tsx
index da68d9cf4..fd184a168 100644
--- a/apps/web/components/tools/MediaFormatConverter.tsx
+++ b/apps/web/components/tools/MediaFormatConverter.tsx
@@ -2,7 +2,6 @@
import { Button } from "@cap/ui";
import * as MediaParser from "@remotion/media-parser";
-import type { WebCodecsController } from "@remotion/webcodecs";
import Link from "next/link";
import { usePathname, useRouter } from "next/navigation";
import { useEffect, useRef, useState } from "react";
@@ -389,16 +388,13 @@ export const MediaFormatConverter = ({
const extractAudioFromVideo = async (inputFile: File): Promise<void> => {
try {
- const parser = await import("@remotion/media-parser");
const webcodecs = await import("@remotion/webcodecs");
const _handleProgress = (progressEvent: { progress: number }) => {
setProgress(Math.min(Math.round(progressEvent.progress * 100), 99));
};
- const controller = parser.mediaParserController
- ? parser.mediaParserController()
- : null;
+ const controller = webcodecs.webcodecsController();
parserControllerRef.current = controller;
const result = await webcodecs.convertMedia({
@@ -409,7 +405,7 @@ export const MediaFormatConverter = ({
setProgress(Math.min(Math.round(overallProgress * 100), 99));
}
},
- controller: controller as unknown as WebCodecsController,
+ controller,
});
const blob = await result.save();
@@ -606,9 +602,7 @@ export const MediaFormatConverter = ({
}
};
- const controller = parser.mediaParserController
- ? parser.mediaParserController()
- : null;
+ const controller = webcodecs.webcodecsController();
parserControllerRef.current = controller;
console.log(`Starting conversion with Remotion: ${conversionPath}`);
@@ -652,7 +646,7 @@ export const MediaFormatConverter = ({
container: outputContainer as any,
videoCodec: videoCodec as any,
onProgress,
- controller: controller as unknown as WebCodecsController,
+ controller,
expectedDurationInSeconds: metadata.durationInSeconds || undefined,
});