Open source Loom alternative. Beautiful, shareable screen recordings.
Rust appcapcossloommacnextjsnextjs15open-sourceossreactrecordrustscreen-capturescreen-recorderscreenshotsolidjstauritauri-apptypescriptvite
fix(media-server): write each verification chunk fragment fully before moving on
Richie McIlroy469869c24fb4
diff --git a/apps/media-server/src/__tests__/lib/recording-verification.integration.test.ts b/apps/media-server/src/__tests__/lib/recording-verification.integration.test.tsindex 2a31b372e..31042bb91 100644--- a/apps/media-server/src/__tests__/lib/recording-verification.integration.test.ts+++ b/apps/media-server/src/__tests__/lib/recording-verification.integration.test.ts@@ -2630,13 +2630,14 @@ describe("chunked packet-proven verification", () => {expect(recording.segments.length).toBeGreaterThanOrEqual(30);const warnings: string[] = [];const onWarning = (warning: Error) => warnings.push(warning.name);- process.on("warning", onWarning);+ const events = process as unknown as NodeJS.EventEmitter;+ events.on("warning", onWarning);try {const { single, chunked, fallbacks } = await both(recording);expect(fallbacks).toHaveLength(0);expect(chunked).toEqual(single);} finally {- process.off("warning", onWarning);+ events.off("warning", onWarning);}expect(warnings).not.toContain("MaxListenersExceededWarning");});diff --git a/apps/media-server/src/lib/recording-verification.ts b/apps/media-server/src/lib/recording-verification.tsindex ef2a42c3b..5ec9f4d6b 100644--- a/apps/media-server/src/lib/recording-verification.ts+++ b/apps/media-server/src/lib/recording-verification.ts@@ -727,7 +727,18 @@ async function concatFiles(for (const path of paths) {signal?.throwIfAborted();for await (const chunk of createReadStream(path, { signal })) {- await output.write(chunk);+ for (let offset = 0; offset < chunk.byteLength; ) {+ const { bytesWritten } = await output.write(+ chunk,+ offset,+ chunk.byteLength - offset,+ );+ if (bytesWritten <= 0)+ throw new Error(+ "Recording verification chunk could not be written",+ );+ offset += bytesWritten;+ }}}} finally {