Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

fix(cli): reject config commands without recording metadata

Aditya Garud4a67722e17a4
diff --git a/apps/cli/src/project.rs b/apps/cli/src/project.rs
index 5b0f8cdfb..8fbf00526 100644
--- a/apps/cli/src/project.rs
+++ b/apps/cli/src/project.rs
@@ -24,6 +24,8 @@ pub struct ProjectInspection {
}
pub fn config_get(project_path: PathBuf) -> Result<(), String> {
+ RecordingMeta::load_for_project(&project_path)
+ .map_err(|e| format!("Failed to load recording meta: {e}"))?;
let config = match cap_project::ProjectConfiguration::load(&project_path) {
Ok(config) => config,
// Instant and un-edited studio recordings have no project-config.json; return the
@@ -42,6 +44,8 @@ pub fn config_set(
) -> Result<(), String> {
let config: cap_project::ProjectConfiguration = serde_json::from_str(settings_json)
.map_err(|e| format!("Invalid project config JSON: {e}"))?;
+ RecordingMeta::load_for_project(&project_path)
+ .map_err(|e| format!("Failed to load recording meta: {e}"))?;
// write() validates internally before its atomic temp-file-then-rename.
config
.write(&project_path)
diff --git a/apps/cli/tests/cli.rs b/apps/cli/tests/cli.rs
index 712adbf74..190c6fdfd 100644
--- a/apps/cli/tests/cli.rs
+++ b/apps/cli/tests/cli.rs
@@ -660,6 +660,27 @@ fn project_config_get_without_file_returns_default() {
assert!(json.is_object(), "expected a default project config object");
}
+#[test]
+fn project_config_commands_reject_directories_without_recordings() {
+ let dir = tempfile::tempdir().unwrap();
+ let project = dir.path().join("not-a-recording.cap");
+ std::fs::create_dir(&project).unwrap();
+
+ for command in ["get", "set"] {
+ let mut args = vec!["project", "config", command, project.to_str().unwrap()];
+ if command == "set" {
+ args.extend(["--settings-json", "{}"]);
+ }
+ args.push("--json");
+
+ let output = run(&args);
+ assert!(!output.status.success(), "{command} unexpectedly succeeded");
+ assert!(parse_json(&output)["error"].is_string());
+ }
+
+ assert!(!project.join("project-config.json").exists());
+}
+
#[test]
fn export_missing_project_emits_json_error_event() {
let output = run(&["export", "/this/path/does/not/exist.cap", "--progress-json"]);