Open source Loom alternative. Beautiful, shareable screen recordings.
Rust appcapcossloommacnextjsnextjs15open-sourceossreactrecordrustscreen-capturescreen-recorderscreenshotsolidjstauritauri-apptypescriptvite
fix(media-server): tag the h264 level after nvenc instead of passing it to the encoder
Richie McIlroy526a63f4fe7e
diff --git a/apps/media-server/src/__tests__/lib/nvenc-encoder.test.ts b/apps/media-server/src/__tests__/lib/nvenc-encoder.test.tsindex aff3abd03..597855b44 100644--- a/apps/media-server/src/__tests__/lib/nvenc-encoder.test.ts+++ b/apps/media-server/src/__tests__/lib/nvenc-encoder.test.ts@@ -358,8 +358,8 @@ describe("process video args", () => {...nvencVideoArgs,"-vf",gpuScale,- "-level:v",- "4.2",+ "-bsf:v",+ "h264_metadata=level=4.2",...outputTail,]);});@@ -391,8 +391,8 @@ describe("process video args", () => {...nvencVideoArgs,"-vf",gpuScale,- "-level:v",- "4.2",+ "-bsf:v",+ "h264_metadata=level=4.2","-c:a","aac","-b:a",@@ -431,8 +431,8 @@ describe("process video args", () => {...nvencVideoArgs,"-vf",gpuScale,- "-level:v",- "4.2",+ "-bsf:v",+ "h264_metadata=level=4.2","-bf","0","-c:a",@@ -473,8 +473,8 @@ describe("process video args", () => {cpuScale,"-pix_fmt","yuv420p",- "-level:v",- "4.2",+ "-bsf:v",+ "h264_metadata=level=4.2","-bf","0","-c:a",diff --git a/apps/media-server/src/lib/media-video.ts b/apps/media-server/src/lib/media-video.tsindex 256210b4a..bdff52896 100644--- a/apps/media-server/src/lib/media-video.ts+++ b/apps/media-server/src/lib/media-video.ts@@ -1769,7 +1769,12 @@ export function buildProcessVideoArgs(input: ProcessVideoArgsInput): string[] {"yuv420p",);}- ffmpegArgs.push("-level:v", input.targetH264Level);+ if (nvenc) {+ // h264_nvenc refuses to open when the nominal frame rate exceeds the level (browser WebM often reports 1000 fps); libx264 only writes it into the SPS, so tag it the same way.+ ffmpegArgs.push("-bsf:v", `h264_metadata=level=${input.targetH264Level}`);+ } else {+ ffmpegArgs.push("-level:v", input.targetH264Level);+ }if (input.videoCodec === "vp8" || input.videoCodec === "vp9") {// Reordered B-frames can make MP4 duration exclude the tail of sparse browser captures.ffmpegArgs.push("-bf", "0");