Open source Loom alternative. Beautiful, shareable screen recordings.
Rust appcapcossloommacnextjsnextjs15open-sourceossreactrecordrustscreen-capturescreen-recorderscreenshotsolidjstauritauri-apptypescriptvite
fix(chrome-extension): preserve system audio when muting the microphone
Akshar Patel538e14ff5495
diff --git a/apps/chrome-extension/src/offscreen/recorder.test.ts b/apps/chrome-extension/src/offscreen/recorder.test.tsnew file mode 100644index 000000000..97b706470--- /dev/null+++ b/apps/chrome-extension/src/offscreen/recorder.test.ts@@ -0,0 +1,198 @@+import type { RecordingSpool } from "@cap/recorder-core";+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";+import type { OffscreenResponse, RecordingMode } from "../shared/types";++type MessageListener = Parameters<+ typeof chrome.runtime.onMessage.addListener+>[0];++class Track extends EventTarget {+ enabled = true;+ readyState = "live";+ label = "Test capture";++ constructor(readonly kind: "audio" | "video") {+ super();+ }++ getSettings() {+ return { width: 320, height: 180, frameRate: 30 };+ }+}++class Stream {+ constructor(private tracks: Track[] = []) {}++ getTracks() {+ return this.tracks;+ }++ getAudioTracks() {+ return this.tracks.filter((track) => track.kind === "audio");+ }++ getVideoTracks() {+ return this.tracks.filter((track) => track.kind === "video");+ }++ addTrack(track: Track) {+ this.tracks.push(track);+ }+}++let onMessage: MessageListener;+let capturedStream: Stream;++beforeEach(async () => {+ vi.resetModules();+ vi.useFakeTimers();+ const stored: Record<string, unknown> = {};+ const storage = {+ get: (_keys: string[], callback: (items: object) => void) =>+ callback({ ...stored }),+ set: (items: object, callback: () => void) => {+ Object.assign(stored, items);+ callback();+ },+ };+ vi.stubGlobal("window", globalThis);+ vi.stubGlobal("chrome", {+ storage: { local: storage, session: storage },+ runtime: {+ onMessage: {+ addListener: (listener: MessageListener) => {+ onMessage = listener;+ },+ },+ sendMessage: (_message: unknown, callback: () => void) => callback(),+ },+ });+ vi.stubGlobal("MediaStream", Stream);+ vi.stubGlobal(+ "MediaRecorder",+ class {+ static isTypeSupported() {+ return true;+ }++ constructor(stream: Stream) {+ capturedStream = stream;+ }++ start() {}+ },+ );+ vi.stubGlobal(+ "AudioContext",+ class {+ destination = {};++ createMediaStreamDestination() {+ return { stream: new Stream([new Track("audio")]) };+ }++ createMediaStreamSource() {+ return { connect: vi.fn() };+ }+ },+ );+ vi.stubGlobal(+ "fetch",+ vi.fn(async (input: string | URL | Request) => {+ const url = input.toString();+ if (url.endsWith("/instant-recordings")) {+ return Response.json({+ id: "video-test",+ shareUrl: "https://cap.test/s/video-test",+ });+ }+ if (url.endsWith("/initiate")) {+ return Response.json({ uploadId: "upload-test", provider: "s3" });+ }+ throw new Error(`Unexpected request: ${url}`);+ }),+ );+ const { RecordingSpool } = await import("@cap/recorder-core");+ vi.spyOn(RecordingSpool, "create").mockResolvedValue({+ sessionId: "spool-test",+ } as RecordingSpool);+});++afterEach(() => {+ vi.clearAllTimers();+ vi.useRealTimers();+ vi.restoreAllMocks();+ vi.unstubAllGlobals();+});++const send = (message: Record<string, unknown>) =>+ new Promise<OffscreenResponse>((resolve) => {+ onMessage({ target: "offscreen", ...message }, {}, resolve);+ });++describe("recording microphone mute", () => {+ it.each([+ { mode: "tab", microphone: true, systemAudio: true },+ { mode: "fullscreen", microphone: true, systemAudio: true },+ { mode: "camera", microphone: true, systemAudio: false },+ { mode: "tab", microphone: false, systemAudio: true },+ ] satisfies Array<{+ mode: RecordingMode;+ microphone: boolean;+ systemAudio: boolean;+ }>)(+ "mutes only microphone capture in $mode with microphone=$microphone",+ async ({ mode, microphone, systemAudio }) => {+ const mic = new Track("audio");+ const system = new Track("audio");+ const main = new Stream([new Track("video")]);+ if (systemAudio) main.addTrack(system);+ if (mode === "camera" && microphone) main.addTrack(mic);+ vi.stubGlobal("navigator", {+ userAgent: "Chrome/152.0.0.0",+ mediaDevices: {+ getUserMedia: async (constraints: MediaStreamConstraints) =>+ constraints.video ? main : new Stream([mic]),+ getDisplayMedia: async () => main,+ },+ });+ const { defaultSettings } = await import("../shared/storage");+ await import("./recorder");+ expect(+ await send({+ type: "start-recording",+ mode,+ tabStreamId: "tab-test",+ settings: {+ ...defaultSettings,+ apiBaseUrl: "https://cap.test",+ microphone: { enabled: microphone, deviceId: null },+ systemAudio: { enabled: systemAudio },+ sounds: { enabled: false },+ countdown: { enabled: false, seconds: 3 },+ },+ auth: { authApiKey: "test", userId: "user-test" },+ bootstrap: {+ organization: { id: "org-test" },+ plan: { isPro: true, maxRecordingSeconds: null },+ },+ }),+ ).toMatchObject({ ok: true, status: { phase: "recording" } });++ expect(+ await send({ type: "toggle-microphone-mute", muted: true }),+ ).toEqual({ ok: true });+ expect(mic.enabled).toBe(!microphone);+ expect(system.enabled).toBe(true);+ if (systemAudio) {+ expect(capturedStream.getAudioTracks()[0]?.enabled).toBe(true);+ }++ expect(+ await send({ type: "toggle-microphone-mute", muted: false }),+ ).toEqual({ ok: true });+ expect(mic.enabled).toBe(true);+ expect(system.enabled).toBe(true);+ },+ );+});diff --git a/apps/chrome-extension/src/offscreen/recorder.ts b/apps/chrome-extension/src/offscreen/recorder.tsindex c72bc9d2e..792186506 100644--- a/apps/chrome-extension/src/offscreen/recorder.ts+++ b/apps/chrome-extension/src/offscreen/recorder.ts@@ -95,6 +95,7 @@ type ActiveRecording = {recorder: MediaRecorder;stopPromise: Promise<void>;streams: MediaStream[];+ microphoneTracks: MediaStreamTrack[];recordingStream: MediaStream;statusTimer: number | null;spool: RecordingSpool;@@ -999,6 +1000,10 @@ const startRecording = async (request: StartRecordingRequest) => {recorder,stopPromise: Promise.resolve(),streams,+ microphoneTracks:+ request.mode === "camera"+ ? mainStream.getAudioTracks()+ : (microphoneStream?.getAudioTracks() ?? []),recordingStream,statusTimer: null,spool,@@ -1776,12 +1781,7 @@ const handleRequest = async (if (message.type === "toggle-microphone-mute") {const recording = activeRecording;if (recording) {- for (const stream of recording.streams) {- for (const track of stream.getAudioTracks()) {- track.enabled = !message.muted;- }- }- for (const track of recording.recordingStream.getAudioTracks()) {+ for (const track of recording.microphoneTracks) {track.enabled = !message.muted;}}