Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

ci(verify): run real capture on pull requests

Richie McIlroy5731d0f68903
diff --git a/.github/workflows/verify-recording.yml b/.github/workflows/verify-recording.yml
index 3ca5db7b4..e23087146 100644
--- a/.github/workflows/verify-recording.yml
+++ b/.github/workflows/verify-recording.yml
@@ -5,13 +5,10 @@ name: Verify recording (real capture)
# frame and audio marker against the host-clock truth. See
# crates/verify/tests/recording.rs.
-# Pushes to the suite branches that touch the capture, encode, timestamp or
-# verify code run the FAST tier once on macos-15; the FULL tier runs on
-# macos-15 and macos-26 nightly and on dispatch. Pull requests are not
-# triggered yet: real capture becomes a blocking pull-request check (FAST on
-# macos-15, path-filtered, FULL on both macOS versions for a pull request that
-# touches a high-risk region of scripts/verify/guards.toml, see the Scope job)
-# once a 5-repeat full tier per macOS version shows zero unexplained failures.
+# Pull requests (and pushes to the suite branches) that touch the capture,
+# encode, timestamp or verify code run the FAST tier once on macos-15; the
+# FULL tier runs on macos-15 and macos-26 nightly and on dispatch, and for a
+# pull request that touches a high-risk region of scripts/verify/guards.toml.
on:
workflow_dispatch:
inputs:
@@ -30,6 +27,27 @@ on:
default: false
schedule:
- cron: "41 3 * * *"
+ pull_request:
+ paths:
+ - "crates/recording/**"
+ - "crates/scap-*/**"
+ - "crates/enc-avfoundation/**"
+ - "crates/timestamp/**"
+ - "crates/camera*/**"
+ - "crates/media-info/**"
+ - "crates/verify/**"
+ - "crates/project/**"
+ - "Cargo.lock"
+ - ".github/workflows/verify-recording.yml"
+ - "crates/enc-ffmpeg/**"
+ - "crates/audio/**"
+ - "crates/editor/src/audio*.rs"
+ - "crates/rendering/src/decoder/**"
+ - "crates/video-decode/**"
+ - "apps/desktop-gpui/src/upload*"
+ - "apps/desktop-gpui/src/upload/**"
+ - "scripts/verify/guards.toml"
+
push:
branches:
- ci/verify-ci
diff --git a/scripts/verify/guards.toml b/scripts/verify/guards.toml
index e43d0dd66..e2f0cae7c 100644
--- a/scripts/verify/guards.toml
+++ b/scripts/verify/guards.toml
@@ -3,9 +3,9 @@
# [[region]]: high-risk code. A pull request whose diff touches one gets a
# "needs deep review" warning (job summary, annotation, and the
# needs-deep-review label where the token may add labels), and Engine verify
-# runs the FULL tier (real capture too, on macos-15 and macos-26, once its
-# pull-request trigger is enabled). Paths are globs relative to the
-# repository root; `/**` matches everything below a directory.
+# plus real capture run the FULL tier (real capture on macos-15 and
+# macos-26). Paths are globs relative to the repository root; `/**` matches
+# everything below a directory.
#
# [[guard]]: a protective guard whose removal changes no output of the suites
# today (an equivalent mutant), so only a sentinel notices. The sentinel is a
diff --git a/scripts/verify/plan.py b/scripts/verify/plan.py
index ccf1d83d0..cf1d9acee 100755
--- a/scripts/verify/plan.py
+++ b/scripts/verify/plan.py
@@ -56,7 +56,7 @@ def risk_report(regions, touched):
md = ["## Needs deep review", ""]
notes = []
if regions:
- md.append("This change touches high-risk engine code. A pull request that does runs the FULL Engine verify tier:")
+ md.append("This change touches high-risk engine code. A pull request that does runs the FULL tier, with real capture on both macOS versions:")
md.append("")
for name, hits in regions:
md.append(f"- **{name}**: " + ", ".join(f"`{h}`" for h in hits[:6]) + (" ..." if len(hits) > 6 else ""))