Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

fix(web): drop a pending timestamp seek once the viewer seeks

Aditya Garud5757e0f7eb20
diff --git a/apps/web/app/s/[videoId]/Share.tsx b/apps/web/app/s/[videoId]/Share.tsx
index 9e6606db9..3b8517b22 100644
--- a/apps/web/app/s/[videoId]/Share.tsx
+++ b/apps/web/app/s/[videoId]/Share.tsx
@@ -482,7 +482,10 @@ export const Share = ({
);
}, [data.source.type, searchParams]);
+ const cancelPendingSeek = useRef<(() => void) | null>(null);
+
const handleSeek = useCallback((time: number) => {
+ cancelPendingSeek.current?.();
const v =
playerRef.current ??
(document.querySelector("video") as HTMLVideoElement | null);
@@ -504,13 +507,21 @@ export const Share = ({
seekOnce(time);
return;
}
- const handleReady = () => {
- seekOnce(time);
+ // A timeline seek before metadata moves currentTime; don't undo it.
+ const requestedFrom = v.currentTime;
+ const cancel = () => {
v.removeEventListener("canplay", handleReady);
v.removeEventListener("loadedmetadata", handleReady);
+ if (cancelPendingSeek.current === cancel)
+ cancelPendingSeek.current = null;
+ };
+ const handleReady = () => {
+ cancel();
+ if (v.currentTime === requestedFrom) seekOnce(time);
};
v.addEventListener("canplay", handleReady, { once: true });
v.addEventListener("loadedmetadata", handleReady, { once: true });
+ cancelPendingSeek.current = cancel;
}, []);
useEffect(() => {