Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

test: remove the decoder model entries the AVAssetReader fixes resolve

Richie McIlroy6188bc50fcff
diff --git a/crates/rendering/src/decoder/model/expectations.toml b/crates/rendering/src/decoder/model/expectations.toml
index 80a6f350a..9dd4ccd52 100644
--- a/crates/rendering/src/decoder/model/expectations.toml
+++ b/crates/rendering/src/decoder/model/expectations.toml
@@ -1034,14 +1034,7 @@ link = ""
[[xfail]]
case = "decoder-model/ffmpeg/camera-fast/random-seeks/playback"
class = "overread"
-seeds = "7"
-reason = "Camera runaway: when the pts-hole map is full it evicts the narrowest hole, so with two requests per source frame the reader reads one frame further ahead per hole until answers come from the future"
-link = "https://github.com/CapSoftware/Cap/pull/2595"
-
-[[xfail]]
-case = "decoder-model/ffmpeg/camera-fast/random-seeks/playback"
-class = "overread"
-seeds = "0-4 6 8-12 14-16 18 19 22-32 34-51 54-59"
+seeds = "0-4 6-12 14-16 18 19 22-32 34-51 54-59"
reason = "Camera runaway: when the pts-hole map is full it evicts the narrowest hole, so with two requests per source frame the reader reads one frame further ahead per hole until answers come from the future"
link = "https://github.com/CapSoftware/Cap/pull/2595"
@@ -1055,14 +1048,7 @@ link = ""
[[xfail]]
case = "decoder-model/ffmpeg/camera-fast/sequential/export"
class = "grid-rounding"
-seeds = "4 11 22 27 29"
-reason = "Camera runaway: when the pts-hole map is full it evicts the narrowest hole, so with two requests per source frame the reader reads one frame further ahead per hole until answers come from the future"
-link = "https://github.com/CapSoftware/Cap/pull/2595"
-
-[[xfail]]
-case = "decoder-model/ffmpeg/camera-fast/sequential/export"
-class = "grid-rounding"
-seeds = "3 6 28"
+seeds = "3 4 6 11 22 27-29"
reason = "Camera runaway: when the pts-hole map is full it evicts the narrowest hole, so with two requests per source frame the reader reads one frame further ahead per hole until answers come from the future"
link = "https://github.com/CapSoftware/Cap/pull/2595"
@@ -1104,14 +1090,7 @@ link = "https://github.com/CapSoftware/Cap/pull/2595"
[[xfail]]
case = "decoder-model/ffmpeg/camera/sequential/export"
class = "grid-rounding"
-seeds = "0 2 3"
-reason = "Camera runaway: when the pts-hole map is full it evicts the narrowest hole, so with two requests per source frame the reader reads one frame further ahead per hole until answers come from the future"
-link = "https://github.com/CapSoftware/Cap/pull/2595"
-
-[[xfail]]
-case = "decoder-model/ffmpeg/camera/sequential/export"
-class = "grid-rounding"
-seeds = "1"
+seeds = "0-3"
reason = "Camera runaway: when the pts-hole map is full it evicts the narrowest hole, so with two requests per source frame the reader reads one frame further ahead per hole until answers come from the future"
link = "https://github.com/CapSoftware/Cap/pull/2595"
@@ -1167,56 +1146,28 @@ link = "https://github.com/CapSoftware/Cap/pull/2595"
[[xfail]]
case = "decoder-model/ffmpeg/cfr/keyframe-seeks/playback"
class = "future"
-seeds = "0 38 46 56 62 69 83 90 93 104 110 133 145 169 181 183 186 205 207 239 253 256 260 299"
-reason = "NEW: the FFmpeg decoder seeks with the request time rounded to the stream tick, so a request a fraction of a tick before a keyframe lands on that keyframe and is answered with a later frame"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/cfr/keyframe-seeks/playback"
-class = "future"
-seeds = "1 4 6 17 18 20 23 41 42 48 50 53 63 65 101 108 115 118 119 122 124 130 136 140 142 147 149-151 154 161 167 188 192 199-201 203 209 212 216 219 223 235 237 245 248 250 261 263 268 270 271 275 285 288 290 291"
+seeds = "0 1 4 6 17 18 20 23 38 41 42 46 48 50 53 56 62 63 65 69 83 90 93 101 104 108 110 115 118 119 122 124 130 133 136 140 142 145 147 149-151 154 161 167 169 181 183 186 188 192 199-201 203 205 207 209 212 216 219 223 235 237 239 245 248 250 253 256 260 261 263 268 270 271 275 285 288 290 291 299"
reason = "NEW: the FFmpeg decoder seeks with the request time rounded to the stream tick, so a request a fraction of a tick before a keyframe lands on that keyframe and is answered with a later frame"
link = ""
[[xfail]]
case = "decoder-model/ffmpeg/cfr/keyframe-seeks/playback"
class = "grid-rounding"
-seeds = "0 4 5 8 20 29 48 53 62 63 69 115 121 130 136 142 147 151 154 161 167 173 188 200 201 207 212 216 219 223 225 226 234 235 237-239 245 248 254 255 263 268 270 275 278 285 291 299"
-reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/cfr/keyframe-seeks/playback"
-class = "grid-rounding"
-seeds = "2 6 9 12 17 19 23 27 28 30 31 33 38 39 41 42 46 50 52 54 56 60 61 65 68 71 72 74 75 79 82-84 86 90 92 93 96 98 99 101-104 106-108 110 111 119 122 124 125 129 131 133 135 137 138 140 141 143 145 148-150 152 156 164 165 168-172 177-179 181-183 186 189-192 194 195 197-199 203 205 206 209-211 222 227 236 241 243 250 253 256 258 265 266 273 274 283 284 287 290 294 295 297"
+seeds = "0 2 4-6 8 9 12 17 19 20 23 27-31 33 38 39 41 42 46 48 50 52-54 56 60-63 65 68 69 71 72 74 75 79 82-84 86 90 92 93 96 98 99 101-104 106-108 110 111 115 119 121 122 124 125 129-131 133 135-138 140-143 145 147-152 154 156 161 164 165 167-173 177-179 181-183 186 188-192 194 195 197-201 203 205-207 209-212 216 219 222 223 225-227 234-239 241 243 245 248 250 253-256 258 263 265 266 268 270 273-275 278 283-285 287 290 291 294 295 297 299"
reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
link = ""
[[xfail]]
case = "decoder-model/ffmpeg/cfr/keyframe-seeks/playback"
class = "overread"
-seeds = "0 4-8 12 15 16 19 20 26 31 37 46 47 51 53 62 63 69 70 72 80 88 91 95 100 101 111 112 115 117 121 125 127 130 136 138 142 147 153 155 161 167 170 172 173 175 183 196 200 202-204 207-212 216 219 225-227 230 234 235 237-241 244 245 253-256 263 265 275 278 285 286 291 292 294 297 299"
-reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/cfr/keyframe-seeks/playback"
-class = "overread"
-seeds = "2 11 14 27 29 30 33 38 39 50 52 54 56 59-61 67 68 71 74 82 83 86 90 92 93 96 98 99 102-104 106 108 110 113 119 126 129 131 133 135 137 139 144 145 148 152 156 162 164 165 168 169 171 177-179 181 182 185 186 189 190 197 198 205 222 229 236 243 247 258 260 266 274 287 295"
+seeds = "0 2 4-8 11 12 14-16 19 20 26 27 29-31 33 37-39 46 47 50-54 56 59-63 67-72 74 80 82 83 86 88 90-93 95 96 98-104 106 108 110-113 115 117 119 121 125-127 129-131 133 135-139 142 144 145 147 148 152 153 155 156 161 162 164 165 167-173 175 177-179 181-183 185 186 189 190 196-198 200 202-205 207-212 216 219 222 225-227 229 230 234-241 243-245 247 253-256 258 260 263 265 266 274 275 278 285-287 291 292 294 295 297 299"
reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
link = ""
[[xfail]]
case = "decoder-model/ffmpeg/cfr/keyframe-seeks/playback"
class = "stale"
-seeds = "4 6 20 53 63 101 108 115 119 130 136 147 154 161 200 203 209 212 216 219 235 237 245 275 291"
-reason = "NEW: the FFmpeg decoder answers backward requests with a cached frame up to 2 grid frames older than the requested one, answers grid frames 0 to 2 with the first frame, and after a backward request served from the cache it reads forward from a reader that is still far ahead, answering with an older cached frame"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/cfr/keyframe-seeks/playback"
-class = "stale"
-seeds = "0 2 5 7 8 12 14-16 19 26 27 29-31 33 37-39 46 47 51 52 54 56 59-62 67-72 74 80 82 83 86 88 90-93 95 96 98-100 102-104 106 110-113 117 121 125-127 129 131 133 135 137-139 144 145 148 152 153 155 156 162 164 165 168-173 175 177-179 181-183 186 189 190 196-198 202 204 205 207 208 210 211 215 222 225-227 229 230 234 236 238-241 243 244 247 253-256 258-260 265 269 274 278 286 287 292 294 295 297 299"
+seeds = "0 2 4-8 12 14-16 19 20 26 27 29-31 33 37-39 46 47 51-54 56 59-63 67-72 74 80 82 83 86 88 90-93 95 96 98-104 106 108 110-113 115 117 119 121 125-127 129-131 133 135-139 144 145 147 148 152-156 161 162 164 165 168-173 175 177-179 181-183 186 189 190 196-198 200 202-205 207-212 215 216 219 222 225-227 229 230 234-241 243-245 247 253-256 258-260 265 269 274 275 278 286 287 291 292 294 295 297 299"
reason = "NEW: the FFmpeg decoder answers backward requests with a cached frame up to 2 grid frames older than the requested one, answers grid frames 0 to 2 with the first frame, and after a backward request served from the cache it reads forward from a reader that is still far ahead, answering with an older cached frame"
link = ""
@@ -1230,28 +1181,14 @@ link = ""
[[xfail]]
case = "decoder-model/ffmpeg/cfr/random-seeks/playback"
class = "grid-rounding"
-seeds = "67 100 254 279"
-reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/cfr/random-seeks/playback"
-class = "grid-rounding"
-seeds = "13 31 40 52 57 61 63 69 74 80 93 117 120 126 140 153 166 180 182 188 196 251 258 276 299"
+seeds = "13 31 40 52 57 61 63 67 69 74 80 93 100 117 120 126 140 153 166 180 182 188 196 251 254 258 276 279 299"
reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
link = ""
[[xfail]]
case = "decoder-model/ffmpeg/cfr/random-seeks/playback"
class = "overread"
-seeds = "0 4 10-12 16 18 25 27 30 32 42 50 55 67 73 82 89 100 108 126 128 129 134 137-139 146 147 151 164 166 171 174 178-181 207 217 220 228 232 246 247 250 254 262 273 279 281 289 290 297"
-reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/cfr/random-seeks/playback"
-class = "overread"
-seeds = "3 9 13 64 95 101 106 140 148 163 187 204 227 287 299"
+seeds = "0 3 4 9-13 16 18 25 27 30 32 42 50 55 64 67 73 82 89 95 100 101 106 108 126 128 129 134 137-140 146-148 151 163 164 166 171 174 178-181 187 204 207 217 220 227 228 232 246 247 250 254 262 273 279 281 287 289 290 297 299"
reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
link = ""
@@ -1272,28 +1209,14 @@ link = ""
[[xfail]]
case = "decoder-model/ffmpeg/cfr/scrub/playback"
class = "grid-rounding"
-seeds = "27 33 39 41 50 68 86 90 93 101 104 109 121 123 124 133 144 149 155 160 165 170 173 179 180 183 186 192 199"
-reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/cfr/scrub/playback"
-class = "grid-rounding"
-seeds = "30 62 63 84 106 122 126 143 176 187"
+seeds = "27 30 33 39 41 50 62 63 68 84 86 90 93 101 104 106 109 121-124 126 133 143 144 149 155 160 165 170 173 176 179 180 183 186 187 192 199"
reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
link = ""
[[xfail]]
case = "decoder-model/ffmpeg/cfr/scrub/playback"
class = "overread"
-seeds = "1 4 7 8 11 14 16-20 26 27 36-38 40-43 46 52 53 55 56 58 64 68 70 71 73 74 77 78 80 82 83 85 88 90-94 98-101 105 107 110 113 114 117 121 124 127 128 131-133 135 137 141 142 145 148 149 151 152 154 155 157 162 163 167 173-175 177 179 181 183 187 189 192 193 198"
-reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/cfr/scrub/playback"
-class = "overread"
-seeds = "0 3 13 21 31 33-35 39 44 50 51 54 67 75 84 86 97 103 104 106 108 109 111 115 118 119 122 123 134 138-140 144 147 158-161 165 168 170 176 180 185 186 197"
+seeds = "0 1 3 4 7 8 11 13 14 16-21 26 27 31 33-44 46 50-56 58 64 67 68 70 71 73-75 77 78 80 82-86 88 90-94 97-101 103-111 113-115 117-119 121-124 127 128 131-135 137-142 144 145 147-149 151 152 154 155 157-163 165 167 168 170 173-177 179-181 183 185-187 189 192 193 197 198"
reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
link = ""
@@ -1328,14 +1251,7 @@ link = ""
[[xfail]]
case = "decoder-model/ffmpeg/cfr/timeline/export"
class = "overread"
-seeds = "12 42 43 64 133"
-reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/cfr/timeline/export"
-class = "overread"
-seeds = "53 66 103 107 132"
+seeds = "12 42 43 53 64 66 103 107 132 133"
reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
link = ""
@@ -1349,28 +1265,14 @@ link = ""
[[xfail]]
case = "decoder-model/ffmpeg/cfr/transition/export"
class = "future"
-seeds = "73"
-reason = "NEW: the FFmpeg decoder seeks with the request time rounded to the stream tick, so a request a fraction of a tick before a keyframe lands on that keyframe and is answered with a later frame"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/cfr/transition/export"
-class = "future"
-seeds = "6 66"
+seeds = "6 66 73"
reason = "NEW: the FFmpeg decoder seeks with the request time rounded to the stream tick, so a request a fraction of a tick before a keyframe lands on that keyframe and is answered with a later frame"
link = ""
[[xfail]]
case = "decoder-model/ffmpeg/cfr/transition/export"
class = "grid-rounding"
-seeds = "0 15 22 23 25 29 66 73"
-reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/cfr/transition/export"
-class = "grid-rounding"
-seeds = "5-7 38 41 45 53 56 61 62 72"
+seeds = "0 5-7 15 22 23 25 29 38 41 45 53 56 61 62 66 72 73"
reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
link = ""
@@ -1398,14 +1300,7 @@ link = ""
[[xfail]]
case = "decoder-model/ffmpeg/cfr/transition/playback"
class = "grid-rounding"
-seeds = "14 20 21 25 31 53 54 57 61 66"
-reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/cfr/transition/playback"
-class = "grid-rounding"
-seeds = "9 19 29 42 51 58 64 65"
+seeds = "9 14 19-21 25 29 31 42 51 53 54 57 58 61 64-66"
reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
link = ""
@@ -1433,28 +1328,14 @@ link = ""
[[xfail]]
case = "decoder-model/ffmpeg/dense/random-seeks/playback"
class = "grid-rounding"
-seeds = "17 22 33"
-reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/dense/random-seeks/playback"
-class = "grid-rounding"
-seeds = "1 7 15 21 25 32 35 36 45 47 48 55 64 70 82 86 90 91 100 103 114 115 121 126 147"
+seeds = "1 7 15 17 21 22 25 32 33 35 36 45 47 48 55 64 70 82 86 90 91 100 103 114 115 121 126 147"
reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
link = ""
[[xfail]]
case = "decoder-model/ffmpeg/dense/random-seeks/playback"
class = "overread"
-seeds = "0 4 14 15 17 20 22 25 27 29 31 32 38 43 50 54 56 57 61 65 67 71 84 91 92 97 99 102 114 116 123 126 128 130 135 137 140 144"
-reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/dense/random-seeks/playback"
-class = "overread"
-seeds = "33 86"
+seeds = "0 4 14 15 17 20 22 25 27 29 31-33 38 43 50 54 56 57 61 65 67 71 84 86 91 92 97 99 102 114 116 123 126 128 130 135 137 140 144"
reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
link = ""
@@ -1496,56 +1377,28 @@ link = "https://github.com/CapSoftware/Cap/pull/2595"
[[xfail]]
case = "decoder-model/ffmpeg/vfr/keyframe-seeks/playback"
class = "future"
-seeds = "3 8 10 46 61 68 69 86 89 99"
-reason = "NEW: the FFmpeg decoder seeks with the request time rounded to the stream tick, so a request a fraction of a tick before a keyframe lands on that keyframe and is answered with a later frame"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/vfr/keyframe-seeks/playback"
-class = "future"
-seeds = "2 4 5 9 11 14 20-22 24-27 29 31 32 34 36 37 39-41 48 50 53-56 58 59 62-65 67 70 71 73 76 79 82 84 88 90 91 93-98"
+seeds = "2-5 8-11 14 20-22 24-27 29 31 32 34 36 37 39-41 46 48 50 53-56 58 59 61-65 67-71 73 76 79 82 84 86 88-91 93-99"
reason = "NEW: the FFmpeg decoder seeks with the request time rounded to the stream tick, so a request a fraction of a tick before a keyframe lands on that keyframe and is answered with a later frame"
link = ""
[[xfail]]
case = "decoder-model/ffmpeg/vfr/keyframe-seeks/playback"
class = "grid-rounding"
-seeds = "2 10 13 21 22 24 28 32 34 36 37 40 42 46 48 53-55 63-65 68 69 73 76 88 90 91 93-95"
-reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/vfr/keyframe-seeks/playback"
-class = "grid-rounding"
-seeds = "1 3-5 8 9 11 15 16 18 23 25 27 29-31 41 43 44 47 50 51 56-62 66 70-72 74 75 79-87 89 92 96 97 99"
+seeds = "1-5 8-11 13 15 16 18 21-25 27-32 34 36 37 40-44 46-48 50 51 53-66 68-76 79-97 99"
reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
link = ""
[[xfail]]
case = "decoder-model/ffmpeg/vfr/keyframe-seeks/playback"
class = "overread"
-seeds = "1-5 7 8 10-14 19-21 24 25 29 34 36 40-43 48 51 53 55 59 62 64 68 73 79 81 86 91 94 96"
-reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/vfr/keyframe-seeks/playback"
-class = "overread"
-seeds = "6 9 15 17 18 23 28 30 31 44 46 47 50 52 57 58 60 61 66 69 72 75 76 78 83 84 87 89 97 99"
+seeds = "1-15 17-21 23-25 28-31 34 36 40-44 46-48 50-53 55 57-62 64 66 68 69 72 73 75 76 78 79 81 83 84 86 87 89 91 94 96 97 99"
reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
link = ""
[[xfail]]
case = "decoder-model/ffmpeg/vfr/keyframe-seeks/playback"
class = "stale"
-seeds = "2 4 9 11 14 20 21 24 25 29 31 34 40 41 48 55 59 62 64 73 76 79 84 91 93 94 96"
-reason = "NEW: the FFmpeg decoder answers backward requests with a cached frame up to 2 grid frames older than the requested one, answers grid frames 0 to 2 with the first frame, and after a backward request served from the cache it reads forward from a reader that is still far ahead, answering with an older cached frame"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/vfr/keyframe-seeks/playback"
-class = "stale"
-seeds = "1 3 7 8 10 12 13 15 17-19 23 28 30 42-44 46 47 51 52 57 60 61 66 68 69 72 75 78 81 83 86 87 89 99"
+seeds = "1-4 7-15 17-21 23-25 28-31 34 40-44 46-48 51 52 55 57 59-62 64 66 68 69 72 73 75 76 78 79 81 83 84 86 87 89 91 93 94 96 99"
reason = "NEW: the FFmpeg decoder answers backward requests with a cached frame up to 2 grid frames older than the requested one, answers grid frames 0 to 2 with the first frame, and after a backward request served from the cache it reads forward from a reader that is still far ahead, answering with an older cached frame"
link = ""
@@ -1566,14 +1419,7 @@ link = ""
[[xfail]]
case = "decoder-model/ffmpeg/vfr/random-seeks/playback"
class = "overread"
-seeds = "3 12 18 20 29 53 55 67 79 84 93 120 148 167 177"
-reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/vfr/random-seeks/playback"
-class = "overread"
-seeds = "11 80 101 102 104 110 130 157 171 180"
+seeds = "3 11 12 18 20 29 53 55 67 79 80 84 93 101 102 104 110 120 130 148 157 167 171 177 180"
reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
link = ""
@@ -1594,28 +1440,14 @@ link = ""
[[xfail]]
case = "decoder-model/ffmpeg/vfr/scrub/playback"
class = "grid-rounding"
-seeds = "2 37 59 67 81 111"
-reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/vfr/scrub/playback"
-class = "grid-rounding"
-seeds = "23 30 46 48 78 87 114"
+seeds = "2 23 30 37 46 48 59 67 78 81 87 111 114"
reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
link = ""
[[xfail]]
case = "decoder-model/ffmpeg/vfr/scrub/playback"
class = "overread"
-seeds = "1 7 12 18 33 34 36 37 43 45 46 49 56 67 70-72 81 101 103 105 111 112"
-reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/vfr/scrub/playback"
-class = "overread"
-seeds = "2 4 10 15 19 23 25 28 38 53 54 59 69 75 80 88 91 95 98 107 110 114 119"
+seeds = "1 2 4 7 10 12 15 18 19 23 25 28 33 34 36-38 43 45 46 49 53 54 56 59 67 69-72 75 80 81 88 91 95 98 101 103 105 107 110-112 114 119"
reason = "NEW: after a backward request served from the FFmpeg decoder's cache, the reader is left far ahead and the next request reads past the frame it needs"
link = ""
@@ -1643,14 +1475,7 @@ link = ""
[[xfail]]
case = "decoder-model/ffmpeg/vfr/timeline/export"
class = "grid-rounding"
-seeds = "20"
-reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/vfr/timeline/export"
-class = "grid-rounding"
-seeds = "77 110"
+seeds = "20 77 110"
reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
link = ""
@@ -1678,14 +1503,7 @@ link = ""
[[xfail]]
case = "decoder-model/ffmpeg/vfr/transition/playback"
class = "grid-rounding"
-seeds = "10 12 13 66 71 75"
-reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
-link = ""
-
-[[xfail]]
-case = "decoder-model/ffmpeg/vfr/transition/playback"
-class = "grid-rounding"
-seeds = "15 16 19 20 28 33 34 43 47 48 56 59 62 68 70 77"
+seeds = "10 12 13 15 16 19 20 28 33 34 43 47 48 56 59 62 66 68 70 71 75 77"
reason = "NEW: the FFmpeg decoder seeks to the exact request time, so after a reset it answers with the frame on screen at that time even when its rounded grid label is after the request; sequential playback shows the previous frame for the same request"
link = ""
diff --git a/crates/video-decode/src/avassetreader.rs b/crates/video-decode/src/avassetreader.rs
index bc29aba9e..c1dc1f7ef 100644
--- a/crates/video-decode/src/avassetreader.rs
+++ b/crates/video-decode/src/avassetreader.rs
@@ -300,6 +300,7 @@ impl KeyframeIndex {
.collect();
Self {
keyframes,
+ time_base: ffmpeg::Rational::new(script.time_base.0, script.time_base.1),
fps,
duration_secs: script.duration_secs(),
pixel_format: Some(cv::PixelFormat::_420V),