Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

ci(verify): run the Windows engine suites on Blacksmith with WARP

Richie McIlroy680c62adfbd9
diff --git a/.github/actions/engine-verify-setup/action.yml b/.github/actions/engine-verify-setup/action.yml
index b14586b33..1cfedb12b 100644
--- a/.github/actions/engine-verify-setup/action.yml
+++ b/.github/actions/engine-verify-setup/action.yml
@@ -119,6 +119,33 @@ runs:
mkdir -p target/ci-verify
cp target/native-deps/dxc/dxcompiler.dll target/native-deps/dxc/dxil.dll target/ci-verify/
+ # Debug builds of wgpu (the ci-verify profile keeps debug assertions)
+ # enable the D3D12 debug layer whenever d3d12SDKLayers.dll exists. When
+ # that DLL comes from an unserviced Graphics Tools feature older than the
+ # D3D12 runtime (blacksmith-8vcpu-windows-2025: layers 10.0.26100.1591,
+ # runtime 10.0.26100.33296), D3D12CreateDevice fails with E_INVALIDARG on
+ # every adapter, WARP included, and every case fails "No GPU adapter
+ # found". Hiding the mismatched layer makes D3D12GetDebugInterface report
+ # DXGI_ERROR_SDK_COMPONENT_MISSING, which wgpu treats as "no debug layer".
+ - name: Hide a D3D12 debug layer that does not match the runtime (Windows)
+ if: runner.os == 'Windows'
+ shell: pwsh
+ run: |
+ $sys = Join-Path $env:WINDIR 'System32'
+ $layers = Join-Path $sys 'd3d12SDKLayers.dll'
+ $core = Join-Path $sys 'D3D12Core.dll'
+ if (-not (Test-Path $layers)) { Write-Host 'no D3D12 debug layer installed'; exit 0 }
+ $lv = (Get-Item $layers).VersionInfo
+ $cv = (Get-Item $core).VersionInfo
+ $lver = "$($lv.FileMajorPart).$($lv.FileMinorPart).$($lv.FileBuildPart).$($lv.FilePrivatePart)"
+ $cver = "$($cv.FileMajorPart).$($cv.FileMinorPart).$($cv.FileBuildPart).$($cv.FilePrivatePart)"
+ Write-Host "D3D12 debug layer $lver, runtime $cver"
+ if ($lver -eq $cver) { exit 0 }
+ takeown /f $layers | Out-Null
+ icacls $layers /grant "*S-1-5-32-544:F" | Out-Null
+ Rename-Item $layers 'd3d12SDKLayers.dll.mismatched'
+ Write-Host "hid the mismatched debug layer"
+
- name: FFmpeg DLLs on PATH (Windows)
if: runner.os == 'Windows'
shell: pwsh
diff --git a/scripts/verify/suites.json b/scripts/verify/suites.json
index b1e11d671..efab926d2 100644
--- a/scripts/verify/suites.json
+++ b/scripts/verify/suites.json
@@ -1,5 +1,5 @@
{
- "_doc": "Engine verification suites. Read by scripts/verify/plan.py (CI planning, change detection) and scripts/verify/run.sh (local and CI runs). Fields: cargo = the cargo target selection that builds the suite; test = optional exact test name inside that binary; platforms = where each tier runs it (platform-independent logic runs on linux only); roots = workspace packages whose dependency closure decides whether a change can affect the suite; own = files that only affect this suite (a change confined to them selects just this suite). skip = case-id globs left out of a tier on a platform (CAP_VERIFY_SKIP), to keep the FAST tier within its time budget; the FULL tier runs them. Exception: hosted Windows runners have no D3D11 video device, so every Windows case decodes with FFmpeg (the code Linux runs) and renders on the WARP software rasterizer; there the 120 s jitter-camera export and playback and the 3000-seek storms took 6 to more than 15 minutes each (killed at the 15 minute per-test limit in 4 of 5 full runs), so FULL leaves them to Linux and macOS. cases = the executed-case floor per tier and platform: the gate fails when fewer distinct cases whose id starts with prefix ran across all shards (scripts/verify/floor.py). unsupported = per-platform case globs that may report unsupported (with the reason); CI sets CAP_VERIFY_REQUIRE_SUPPORTED=1, so any other unsupported case fails.",
+ "_doc": "Engine verification suites. Read by scripts/verify/plan.py (CI planning, change detection) and scripts/verify/run.sh (local and CI runs). Fields: cargo = the cargo target selection that builds the suite; test = optional exact test name inside that binary; platforms = where each tier runs it (platform-independent logic runs on linux only); roots = workspace packages whose dependency closure decides whether a change can affect the suite; own = files that only affect this suite (a change confined to them selects just this suite). skip = case-id globs left out of a tier on a platform (CAP_VERIFY_SKIP), to keep the FAST tier within its time budget; the FULL tier runs them. Exception: CI Windows VMs (Blacksmith windows-2025, formerly hosted windows-2022) have no D3D11 video device, so every Windows case decodes with FFmpeg (the code Linux runs) and renders on the WARP software rasterizer; on hosted windows-2022 the 120 s jitter-camera export and playback and the 3000-seek storms took 6 to more than 15 minutes each (killed at the 15 minute per-test limit in 4 of 5 full runs), so FULL leaves them to Linux and macOS. cases = the executed-case floor per tier and platform: the gate fails when fewer distinct cases whose id starts with prefix ran across all shards (scripts/verify/floor.py). unsupported = per-platform case globs that may report unsupported (with the reason); CI sets CAP_VERIFY_REQUIRE_SUPPORTED=1, so any other unsupported case fails.",
"suites": [
{
"name": "verify-self",
@@ -287,7 +287,7 @@
"archive": false
},
"windows": {
- "runner": "windows-2022",
+ "runner": "blacksmith-8vcpu-windows-2025",
"target": "x86_64-pc-windows-msvc",
"shards": {
"fast": 3,