Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

perf(media-server): download recording segments 64 at a time by default

Richie McIlroy6dcbc1b3ab70
diff --git a/apps/media-server/src/__tests__/routes/segment-download-pool.test.ts b/apps/media-server/src/__tests__/routes/segment-download-pool.test.ts
index d915802fc..2eefef9f4 100644
--- a/apps/media-server/src/__tests__/routes/segment-download-pool.test.ts
+++ b/apps/media-server/src/__tests__/routes/segment-download-pool.test.ts
@@ -42,7 +42,7 @@ afterAll(async () => {
describe("segment download pool", () => {
test("reads its concurrency from the environment with a safe default and cap", () => {
- expect(segmentDownloadConcurrencyFromEnv({})).toBe(10);
+ expect(segmentDownloadConcurrencyFromEnv({})).toBe(64);
expect(
segmentDownloadConcurrencyFromEnv({
MEDIA_SERVER_SEGMENT_DOWNLOAD_CONCURRENCY: "48",
@@ -57,7 +57,7 @@ describe("segment download pool", () => {
segmentDownloadConcurrencyFromEnv({
MEDIA_SERVER_SEGMENT_DOWNLOAD_CONCURRENCY: "nope",
}),
- ).toBe(10);
+ ).toBe(64);
});
test("downloads video and audio segments from one bounded pool", async () => {
diff --git a/apps/media-server/src/routes/video.ts b/apps/media-server/src/routes/video.ts
index 9bc9662f9..32b8e5b9f 100644
--- a/apps/media-server/src/routes/video.ts
+++ b/apps/media-server/src/routes/video.ts
@@ -2849,6 +2849,9 @@ async function downloadUrlToFile(
throw lastError ?? new Error("Download failed");
}
+// Storage that struggles with this many small concurrent reads can lower it through the env.
+const SEGMENT_DOWNLOAD_CONCURRENCY = 64;
+
export function segmentDownloadConcurrencyFromEnv(
env: Record<string, string | undefined> = process.env,
): number {
@@ -2856,7 +2859,9 @@ export function segmentDownloadConcurrencyFromEnv(
env.MEDIA_SERVER_SEGMENT_DOWNLOAD_CONCURRENCY ?? "",
10,
);
- return Number.isFinite(value) && value > 0 ? Math.min(value, 64) : 10;
+ return Number.isFinite(value) && value > 0
+ ? Math.min(value, SEGMENT_DOWNLOAD_CONCURRENCY)
+ : SEGMENT_DOWNLOAD_CONCURRENCY;
}
interface SegmentTrackDownload {