Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

fix(media-server): stop mux preview rendering once the job fails

Richie McIlroy72a4e1816c4d
diff --git a/apps/media-server/src/__tests__/lib/media-routes-real-world.integration.test.ts b/apps/media-server/src/__tests__/lib/media-routes-real-world.integration.test.ts
index 22d62a847..3615180ad 100644
--- a/apps/media-server/src/__tests__/lib/media-routes-real-world.integration.test.ts
+++ b/apps/media-server/src/__tests__/lib/media-routes-real-world.integration.test.ts
@@ -982,6 +982,28 @@ describe("media routes real-world integration tests", () => {
}
}, 30_000);
+ test("skips mux previews when the uploaded recording fails its remote check", async () => {
+ corruptRecordingReadback = true;
+ const body = {
+ ...fencedMuxRequest("mux-previews-corrupt"),
+ thumbnailPresignedUrl: uploadUrl("mux-previews-corrupt.jpg"),
+ previewGifPresignedUrl: uploadUrl("mux-previews-corrupt.gif"),
+ };
+ const response = await app.fetch(
+ mediaPostRequest("/video/mux-segments", body),
+ );
+ expect(response.status).toBe(200);
+ const { jobId } = (await response.json()) as { jobId: string };
+ try {
+ const job = await waitForTerminalJob(jobId);
+ expect(job.phase).toBe("error");
+ expect(job.errorCode).toBe("output-invalid");
+ expect(uploadRequests).toEqual(["/uploads/mux-previews-corrupt.mp4"]);
+ } finally {
+ deleteJob(jobId);
+ }
+ }, 30_000);
+
test("does not overwrite an existing immutable candidate", async () => {
const original = new Uint8Array([1, 2, 3]);
uploadedArtifacts.set("/uploads/fenced-existing.mp4", original);
diff --git a/apps/media-server/src/routes/video.ts b/apps/media-server/src/routes/video.ts
index e498caf3d..3755d3951 100644
--- a/apps/media-server/src/routes/video.ts
+++ b/apps/media-server/src/routes/video.ts
@@ -2802,6 +2802,7 @@ async function muxSegmentsAsync(
: undefined;
const startedAt = Date.now();
let previewAssets: Promise<PreviewAssets> | undefined;
+ const previewAbort = new AbortController();
try {
if (!beginRecordingProcessing(jobId, SEGMENTED_RECORDING_TIMEOUT_MS))
@@ -3017,7 +3018,7 @@ async function muxSegmentsAsync(
localVerified.video.duration,
Boolean(thumbnailPresignedUrl),
Boolean(previewGifPresignedUrl),
- abortController.signal,
+ AbortSignal.any([abortController.signal, previewAbort.signal]),
videoId,
);
@@ -3247,6 +3248,8 @@ async function muxSegmentsAsync(
sendCurrentJobWebhook(jobId);
} finally {
if (processingTimeout) clearTimeout(processingTimeout);
+ // Previews still rendering here belong to a job that failed before using them.
+ previewAbort.abort();
await (await previewAssets)?.previewGif?.cleanup();
await rm(workDir, { recursive: true, force: true }).catch(() => {});
releaseWorkDir();