Skip to content

armgit / Cap

Public Imported from GitHub
0

Open source Loom alternative. Beautiful, shareable screen recordings.

perf(media-server): render mux previews while the recording uploads

Richie McIlroy82c1d5ee329c
diff --git a/apps/media-server/src/__tests__/lib/media-routes-real-world.integration.test.ts b/apps/media-server/src/__tests__/lib/media-routes-real-world.integration.test.ts
index 1c7a4cc54..22d62a847 100644
--- a/apps/media-server/src/__tests__/lib/media-routes-real-world.integration.test.ts
+++ b/apps/media-server/src/__tests__/lib/media-routes-real-world.integration.test.ts
@@ -687,6 +687,58 @@ describe("media routes real-world integration tests", () => {
}
}, 30_000);
+ test("uploads mux previews only after the recording output is verified", async () => {
+ const body = {
+ ...fencedMuxRequest("mux-previews"),
+ thumbnailPresignedUrl: uploadUrl("mux-previews.jpg"),
+ previewGifPresignedUrl: uploadUrl("mux-previews.gif"),
+ };
+ const response = await app.fetch(
+ mediaPostRequest("/video/mux-segments", body),
+ );
+ expect(response.status).toBe(200);
+ const { jobId } = (await response.json()) as { jobId: string };
+ try {
+ const job = await waitForTerminalJob(jobId);
+ expect(job.phase).toBe("complete");
+ expect(uploadRequests[0]).toBe("/uploads/mux-previews.mp4");
+ expect([...uploadRequests].sort()).toEqual([
+ "/uploads/mux-previews.gif",
+ "/uploads/mux-previews.jpg",
+ "/uploads/mux-previews.mp4",
+ ]);
+ expect(
+ uploadedBytes("/uploads/mux-previews.jpg").byteLength,
+ ).toBeGreaterThan(0);
+ expect(
+ uploadedBytes("/uploads/mux-previews.gif").byteLength,
+ ).toBeGreaterThan(0);
+ } finally {
+ deleteJob(jobId);
+ }
+ }, 30_000);
+
+ test("skips mux previews when the recording output upload fails", async () => {
+ uploadFailures.set("/uploads/mux-previews-failed.mp4", 403);
+ const body = {
+ ...fencedMuxRequest("mux-previews-failed"),
+ thumbnailPresignedUrl: uploadUrl("mux-previews-failed.jpg"),
+ previewGifPresignedUrl: uploadUrl("mux-previews-failed.gif"),
+ };
+ const response = await app.fetch(
+ mediaPostRequest("/video/mux-segments", body),
+ );
+ expect(response.status).toBe(200);
+ const { jobId } = (await response.json()) as { jobId: string };
+ try {
+ const job = await waitForTerminalJob(jobId);
+ expect(job.phase).toBe("error");
+ expect(uploadRequests).toEqual(["/uploads/mux-previews-failed.mp4"]);
+ } finally {
+ deleteJob(jobId);
+ }
+ }, 30_000);
+
test("runs optional audio correction on the local verified file after publication and retains success if it fails", async () => {
let observed: () => void = () => {};
const observations: Record<string, unknown>[] = [];
diff --git a/apps/media-server/src/routes/video.ts b/apps/media-server/src/routes/video.ts
index ac9ad4392..e498caf3d 100644
--- a/apps/media-server/src/routes/video.ts
+++ b/apps/media-server/src/routes/video.ts
@@ -2801,6 +2801,7 @@ async function muxSegmentsAsync(
? new Map(context.sourceObjects.map((source) => [source.url, source]))
: undefined;
const startedAt = Date.now();
+ let previewAssets: Promise<PreviewAssets> | undefined;
try {
if (!beginRecordingProcessing(jobId, SEGMENTED_RECORDING_TIMEOUT_MS))
@@ -3008,6 +3009,17 @@ async function muxSegmentsAsync(
durationMs: Date.now() - startedAt,
resources: getSystemResources(),
});
+ const outputReadyAt = Date.now();
+ // The result is final here, so render previews while the upload and its
+ // remote check run; they are still only uploaded once the recording passes.
+ previewAssets = renderPreviewAssets(
+ resultPath,
+ localVerified.video.duration,
+ Boolean(thumbnailPresignedUrl),
+ Boolean(previewGifPresignedUrl),
+ abortController.signal,
+ videoId,
+ );
let metadata = await withJobHeartbeat(jobId, () =>
probeVideoFile(resultPath),
@@ -3125,18 +3137,14 @@ async function muxSegmentsAsync(
sendCurrentJobWebhook(jobId);
}
- const assetDuration = metadata?.duration ?? 0;
+ const uploadedAt = Date.now();
await withJobHeartbeat(jobId, async () => {
- if (thumbnailPresignedUrl) {
+ const assets = await previewAssets;
+ abortController.signal.throwIfAborted();
+ if (thumbnailPresignedUrl && assets?.thumbnail) {
try {
- const thumbnailData = await generateThumbnail(
- resultPath,
- assetDuration,
- {},
- abortController.signal,
- );
await uploadToS3(
- thumbnailData,
+ assets.thumbnail,
thumbnailPresignedUrl,
"image/jpeg",
abortController.signal,
@@ -3149,14 +3157,22 @@ async function muxSegmentsAsync(
);
}
}
-
- await generateAndUploadPreviewGif(
- resultPath,
- assetDuration,
- previewGifPresignedUrl,
- abortController.signal,
- "mux-segments",
- );
+ if (previewGifPresignedUrl && assets?.previewGif) {
+ try {
+ await uploadFileToS3(
+ assets.previewGif.path,
+ previewGifPresignedUrl,
+ "image/gif",
+ abortController.signal,
+ );
+ } catch (previewErr) {
+ abortController.signal.throwIfAborted();
+ console.warn(
+ "[mux-segments] Preview GIF generation failed:",
+ previewErr,
+ );
+ }
+ }
});
abortController.signal.throwIfAborted();
@@ -3171,6 +3187,8 @@ async function muxSegmentsAsync(
jobId,
videoId,
durationMs: Date.now() - startedAt,
+ uploadMs: uploadedAt - outputReadyAt,
+ previewMs: Date.now() - uploadedAt,
metadata,
resources: getSystemResources(),
});
@@ -3229,9 +3247,46 @@ async function muxSegmentsAsync(
sendCurrentJobWebhook(jobId);
} finally {
if (processingTimeout) clearTimeout(processingTimeout);
+ await (await previewAssets)?.previewGif?.cleanup();
await rm(workDir, { recursive: true, force: true }).catch(() => {});
releaseWorkDir();
}
}
+interface PreviewAssets {
+ thumbnail: Uint8Array | null;
+ previewGif: TempFileHandle | null;
+}
+
+// Never rejects: a failed preview only costs the asset, and the caller checks for abort.
+async function renderPreviewAssets(
+ resultPath: string,
+ duration: number,
+ thumbnail: boolean,
+ previewGif: boolean,
+ signal: AbortSignal,
+ videoId: string,
+): Promise<PreviewAssets> {
+ const [thumbnailResult, previewGifResult] = await Promise.allSettled([
+ thumbnail ? generateThumbnail(resultPath, duration, {}, signal) : null,
+ previewGif ? generatePreviewGif(resultPath, duration, {}, signal) : null,
+ ]);
+ if (thumbnailResult.status === "rejected" && !signal.aborted)
+ console.warn(
+ `[mux-segments] Thumbnail generation failed for ${videoId}:`,
+ thumbnailResult.reason,
+ );
+ if (previewGifResult.status === "rejected" && !signal.aborted)
+ console.warn(
+ "[mux-segments] Preview GIF generation failed:",
+ previewGifResult.reason,
+ );
+ return {
+ thumbnail:
+ thumbnailResult.status === "fulfilled" ? thumbnailResult.value : null,
+ previewGif:
+ previewGifResult.status === "fulfilled" ? previewGifResult.value : null,
+ };
+}
+
export default video;